mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	stable@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-security-module@vger.kernel.org (open list:SECURITY
	SUBSYSTEM), linux-kernel@vger.kernel.org (open list)
Subject: [RFC PATCH 3/8] KEYS: Reject @desclen values over U16_MAX in key_alloc()
Date: Mon, 19 Oct 2026 17:25:03 +0300	[thread overview]
Message-ID: <20261019142516.300040-4-jarkko@kernel.org> (raw)
In-Reply-To: <20261019142516.300040-1-jarkko@kernel.org>

@desclen in key_alloc() is saved to the 16-bit wide desc_len field in
struct keyring_index_key.

Reject @desclen values over U16_MAX with -EINVAL in order to prevent
integer overflow.

Cc: stable@vger.kernel.org
Assisted-by: LLM
Fixes: f771fde82051 ("keys: Simplify key description management")
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
 security/keys/key.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/security/keys/key.c b/security/keys/key.c
index 6ebb8691551f..7888c0c6a772 100644
--- a/security/keys/key.c
+++ b/security/keys/key.c
@@ -245,6 +245,8 @@ struct key *key_alloc(struct key_type *type, const char *desc,
 	}
 
 	desclen = strlen(desc);
+	if (desclen > U16_MAX)
+		goto error;
 	quotalen = desclen + 1 + type->def_datalen;
 
 	/* get hold of the key tracking for this user */
-- 
2.47.3


  parent reply	other threads:[~2026-10-19 14:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 14:25 [RFC PATCH 0/8] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 1/8] KEYS: Change the type of key->quotalen to unsigned int Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 2/8] KEYS: Change the type of key->datalen " Jarkko Sakkinen
2026-10-19 14:25 ` Jarkko Sakkinen [this message]
2026-10-19 14:25 ` [RFC PATCH 4/8] KEYS: Prevent overflow of user->qnkeys in key_alloc() Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 5/8] KEYS: Prevent overflow of quota " Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 6/8] KEYS: Prevent overflow of user->qnbytes " Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 8/8] KEYS: Verify the key identity in __keyctl_unlink Jarkko Sakkinen
2026-10-19 14:33 ` [RFC PATCH 0/8] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 15:33 ` [RFC PATCH 2/8] KEYS: Change the type of key->datalen to unsigned int David Howells
2026-10-19 16:31   ` Jarkko Sakkinen
2026-10-19 15:35 ` [RFC PATCH 3/8] KEYS: Reject @desclen values over U16_MAX in key_alloc() David Howells
2026-10-19 16:32   ` Jarkko Sakkinen
2026-10-19 15:40 ` [RFC PATCH 5/8] KEYS: Prevent overflow of quota " David Howells
2026-10-19 16:33   ` Jarkko Sakkinen
2026-10-19 15:41 ` [RFC PATCH 6/8] KEYS: Prevent overflow of user->qnbytes " David Howells
2026-10-19 16:34   ` Jarkko Sakkinen
2026-10-19 15:43 ` [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX David Howells
2026-10-19 16:35   ` Jarkko Sakkinen
2026-10-19 15:55 ` [RFC PATCH 8/8] KEYS: Verify the key identity in __keyctl_unlink David Howells
2026-10-19 16:37   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019142516.300040-4-jarkko@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®