From: David Howells <dhowells@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
Eric Biggers <ebiggers@kernel.org>,
stable@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org (open list:SECURITY
SUBSYSTEM), linux-kernel@vger.kernel.org (open list)
Subject: Re: [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX
Date: Mon, 19 Oct 2026 16:43:27 +0100 [thread overview]
Message-ID: <2610186.1792424607@warthog.procyon.org.uk> (raw)
In-Reply-To: <20261019142516.300040-8-jarkko@kernel.org>
Jarkko Sakkinen <jarkko@kernel.org> wrote:
> - int delta = (int)datalen - key->datalen;
> + int delta;
> int ret = 0;
>
> key_check(key);
>
> + if (datalen > INT_MAX)
> + return -EINVAL;
> +
> + delta = (int)datalen - key->datalen;
> +
You don't actually need to move the subtraction.
But apart from that:
Signed-off-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2026-10-19 15:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 14:25 [RFC PATCH 0/8] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 1/8] KEYS: Change the type of key->quotalen to unsigned int Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 2/8] KEYS: Change the type of key->datalen " Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 3/8] KEYS: Reject @desclen values over U16_MAX in key_alloc() Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 4/8] KEYS: Prevent overflow of user->qnkeys " Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 5/8] KEYS: Prevent overflow of quota " Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 6/8] KEYS: Prevent overflow of user->qnbytes " Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX Jarkko Sakkinen
2026-10-19 14:25 ` [RFC PATCH 8/8] KEYS: Verify the key identity in __keyctl_unlink Jarkko Sakkinen
2026-10-19 14:33 ` [RFC PATCH 0/8] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 15:33 ` [RFC PATCH 2/8] KEYS: Change the type of key->datalen to unsigned int David Howells
2026-10-19 16:31 ` Jarkko Sakkinen
2026-10-19 15:35 ` [RFC PATCH 3/8] KEYS: Reject @desclen values over U16_MAX in key_alloc() David Howells
2026-10-19 16:32 ` Jarkko Sakkinen
2026-10-19 15:40 ` [RFC PATCH 5/8] KEYS: Prevent overflow of quota " David Howells
2026-10-19 16:33 ` Jarkko Sakkinen
2026-10-19 15:41 ` [RFC PATCH 6/8] KEYS: Prevent overflow of user->qnbytes " David Howells
2026-10-19 16:34 ` Jarkko Sakkinen
2026-10-19 15:43 ` David Howells [this message]
2026-10-19 16:35 ` [RFC PATCH 7/8] KEYS: Reject @datalen values over INT_MAX Jarkko Sakkinen
2026-10-19 15:55 ` [RFC PATCH 8/8] KEYS: Verify the key identity in __keyctl_unlink David Howells
2026-10-19 16:37 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2610186.1792424607@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®