From: Pierre Gondois <pierre.gondois@arm.com>
To: linux-kernel@vger.kernel.org
Cc: James Morse <james.morse@arm.com>,
Mark Brown <broonie@kernel.org>,
Pierre Gondois <pierre.gondois@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Borislav Petkov <bp@alien8.de>, Hanjun Guo <guohanjun@huawei.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
Pawel Chmielewski <pawel.chmielewski@intel.com>,
Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>,
Dave Jiang <dave.jiang@intel.com>,
"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
Breno Leitao <leitao@debian.org>, Dan Williams <djbw@kernel.org>,
Terry Bowman <terry.bowman@amd.com>,
Ard Biesheuvel <ardb@kernel.org>,
Morduan Zang <zhangdandan@uniontech.com>,
linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
acpica-devel@lists.linux.dev
Subject: [PATCH 3/6] cper: use BIT_ULL() for processor and memory validation bits
Date: Mon, 19 Oct 2026 16:56:10 +0200 [thread overview]
Message-ID: <20261019145643.1877246-4-pierre.gondois@arm.com> (raw)
In-Reply-To: <20261019145643.1877246-1-pierre.gondois@arm.com>
Use the BIT_ULL() macro to describe flag bits instead of
hexadecimal values which are harder to read.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
include/linux/cper.h | 72 ++++++++++++++++++++++----------------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/include/linux/cper.h b/include/linux/cper.h
index 76e82a8d29a2..ed355b240685 100644
--- a/include/linux/cper.h
+++ b/include/linux/cper.h
@@ -229,42 +229,42 @@ enum {
GUID_INIT(0x036F84E1, 0x7F37, 0x428c, 0xA7, 0x9E, 0x57, 0x5F, \
0xDF, 0xAA, 0x84, 0xEC)
-#define CPER_PROC_VALID_TYPE 0x0001
-#define CPER_PROC_VALID_ISA 0x0002
-#define CPER_PROC_VALID_ERROR_TYPE 0x0004
-#define CPER_PROC_VALID_OPERATION 0x0008
-#define CPER_PROC_VALID_FLAGS 0x0010
-#define CPER_PROC_VALID_LEVEL 0x0020
-#define CPER_PROC_VALID_VERSION 0x0040
-#define CPER_PROC_VALID_BRAND_INFO 0x0080
-#define CPER_PROC_VALID_ID 0x0100
-#define CPER_PROC_VALID_TARGET_ADDRESS 0x0200
-#define CPER_PROC_VALID_REQUESTOR_ID 0x0400
-#define CPER_PROC_VALID_RESPONDER_ID 0x0800
-#define CPER_PROC_VALID_IP 0x1000
-
-#define CPER_MEM_VALID_ERROR_STATUS 0x0001
-#define CPER_MEM_VALID_PA 0x0002
-#define CPER_MEM_VALID_PA_MASK 0x0004
-#define CPER_MEM_VALID_NODE 0x0008
-#define CPER_MEM_VALID_CARD 0x0010
-#define CPER_MEM_VALID_MODULE 0x0020
-#define CPER_MEM_VALID_BANK 0x0040
-#define CPER_MEM_VALID_DEVICE 0x0080
-#define CPER_MEM_VALID_ROW 0x0100
-#define CPER_MEM_VALID_COLUMN 0x0200
-#define CPER_MEM_VALID_BIT_POSITION 0x0400
-#define CPER_MEM_VALID_REQUESTOR_ID 0x0800
-#define CPER_MEM_VALID_RESPONDER_ID 0x1000
-#define CPER_MEM_VALID_TARGET_ID 0x2000
-#define CPER_MEM_VALID_ERROR_TYPE 0x4000
-#define CPER_MEM_VALID_RANK_NUMBER 0x8000
-#define CPER_MEM_VALID_CARD_HANDLE 0x10000
-#define CPER_MEM_VALID_MODULE_HANDLE 0x20000
-#define CPER_MEM_VALID_ROW_EXT 0x40000
-#define CPER_MEM_VALID_BANK_GROUP 0x80000
-#define CPER_MEM_VALID_BANK_ADDRESS 0x100000
-#define CPER_MEM_VALID_CHIP_ID 0x200000
+#define CPER_PROC_VALID_TYPE BIT_ULL(0)
+#define CPER_PROC_VALID_ISA BIT_ULL(1)
+#define CPER_PROC_VALID_ERROR_TYPE BIT_ULL(2)
+#define CPER_PROC_VALID_OPERATION BIT_ULL(3)
+#define CPER_PROC_VALID_FLAGS BIT_ULL(4)
+#define CPER_PROC_VALID_LEVEL BIT_ULL(5)
+#define CPER_PROC_VALID_VERSION BIT_ULL(6)
+#define CPER_PROC_VALID_BRAND_INFO BIT_ULL(7)
+#define CPER_PROC_VALID_ID BIT_ULL(8)
+#define CPER_PROC_VALID_TARGET_ADDRESS BIT_ULL(9)
+#define CPER_PROC_VALID_REQUESTOR_ID BIT_ULL(10)
+#define CPER_PROC_VALID_RESPONDER_ID BIT_ULL(11)
+#define CPER_PROC_VALID_IP BIT_ULL(12)
+
+#define CPER_MEM_VALID_ERROR_STATUS BIT_ULL(0)
+#define CPER_MEM_VALID_PA BIT_ULL(1)
+#define CPER_MEM_VALID_PA_MASK BIT_ULL(2)
+#define CPER_MEM_VALID_NODE BIT_ULL(3)
+#define CPER_MEM_VALID_CARD BIT_ULL(4)
+#define CPER_MEM_VALID_MODULE BIT_ULL(5)
+#define CPER_MEM_VALID_BANK BIT_ULL(6)
+#define CPER_MEM_VALID_DEVICE BIT_ULL(7)
+#define CPER_MEM_VALID_ROW BIT_ULL(8)
+#define CPER_MEM_VALID_COLUMN BIT_ULL(9)
+#define CPER_MEM_VALID_BIT_POSITION BIT_ULL(10)
+#define CPER_MEM_VALID_REQUESTOR_ID BIT_ULL(11)
+#define CPER_MEM_VALID_RESPONDER_ID BIT_ULL(12)
+#define CPER_MEM_VALID_TARGET_ID BIT_ULL(13)
+#define CPER_MEM_VALID_ERROR_TYPE BIT_ULL(14)
+#define CPER_MEM_VALID_RANK_NUMBER BIT_ULL(15)
+#define CPER_MEM_VALID_CARD_HANDLE BIT_ULL(16)
+#define CPER_MEM_VALID_MODULE_HANDLE BIT_ULL(17)
+#define CPER_MEM_VALID_ROW_EXT BIT_ULL(18)
+#define CPER_MEM_VALID_BANK_GROUP BIT_ULL(19)
+#define CPER_MEM_VALID_BANK_ADDRESS BIT_ULL(20)
+#define CPER_MEM_VALID_CHIP_ID BIT_ULL(21)
/* Memory Error Section 2 validation bits, UEFI v2.11 sec N.2.6. */
#define CPER_MEM2_VALID_ERROR_STATUS BIT_ULL(0)
--
2.43.0
next prev parent reply other threads:[~2026-10-19 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 14:56 [PATCH 0/6] CPER: Add Memory Error Section 2 support Pierre Gondois
2026-10-19 14:56 ` [PATCH 1/6] ACPI: extlog: fix extlog_mem_event build issue Pierre Gondois
2026-10-19 16:36 ` Jonathan Cameron
2026-10-19 17:55 ` Pierre Gondois
2026-10-19 14:56 ` [PATCH 2/6] cper: add Memory Error Section 2 structures Pierre Gondois
2026-10-19 18:16 ` Jonathan Cameron
2026-10-19 14:56 ` Pierre Gondois [this message]
2026-10-19 18:21 ` [PATCH 3/6] cper: use BIT_ULL() for processor and memory validation bits Jonathan Cameron
2026-10-19 14:56 ` [PATCH 4/6] cper: add helpers to handle Memory Error Section 2 Pierre Gondois
2026-10-19 19:13 ` Jonathan Cameron
2026-10-19 14:56 ` [PATCH 5/6] ACPI: APEI: add separate Memory Error Section 2 handlers Pierre Gondois
2026-10-19 19:24 ` Jonathan Cameron
2026-10-19 14:56 ` [RFC PATCH 6/6] ACPI: extlog: add Memory Error Section 2 trace event Pierre Gondois
2026-10-19 19:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019145643.1877246-4-pierre.gondois@arm.com \
--to=pierre.gondois@arm.com \
--cc=acpica-devel@lists.linux.dev \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=dave.jiang@intel.com \
--cc=djbw@kernel.org \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=leitao@debian.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mchehab@kernel.org \
--cc=pawel.chmielewski@intel.com \
--cc=rafael@kernel.org \
--cc=terry.bowman@amd.com \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
--cc=zhangdandan@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®