* [PATCH 1/2] soc: qcom: llcc-qcom: Use lowercase hex consistently
2026-10-20 16:54 [PATCH 0/2] Miscellaneous updates to the Qualcomm LLCC driver Kathiravan Thirumoorthy
@ 2026-10-20 16:54 ` Kathiravan Thirumoorthy
2026-10-20 16:54 ` [PATCH 2/2] soc: qcom: llcc-qcom: Fix whitespace in slice config arrays Kathiravan Thirumoorthy
1 sibling, 0 replies; 3+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-10-20 16:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa
Cc: linux-arm-msm, linux-kernel, Kathiravan Thirumoorthy
Convert the hex values in the Glymur and IPQ5424 configurations to
lowercase so that they are consistent with the rest of the driver.
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
drivers/soc/qcom/llcc-qcom.c | 44 ++++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index d7a42a8040a1..2edc5ec31249 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -439,7 +439,7 @@ static const struct llcc_slice_config glymur_data[] = {
.slice_id = 1,
.max_cap = 7680,
.priority = 1,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
.activate_on_init = true,
@@ -449,7 +449,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 512,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -458,7 +458,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 1024,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -467,7 +467,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 512,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -476,7 +476,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 7680,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -485,7 +485,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 512,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -493,7 +493,7 @@ static const struct llcc_slice_config glymur_data[] = {
.slice_id = 9,
.max_cap = 7680,
.priority = 1,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.write_scid_en = true,
.write_scid_cacheable_en = true,
@@ -505,7 +505,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 768,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
.activate_on_init = true,
@@ -515,7 +515,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 1024,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -524,7 +524,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 64,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -533,7 +533,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 1536,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
.activate_on_init = true,
@@ -543,7 +543,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 256,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -552,7 +552,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 768,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.alloc_oneway_en = true,
.vict_prio = true,
@@ -563,7 +563,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 3072,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.cache_mode = 2,
.vict_prio = true,
@@ -582,7 +582,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 256,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -590,7 +590,7 @@ static const struct llcc_slice_config glymur_data[] = {
.slice_id = 5,
.max_cap = 512,
.priority = 1,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}, {
@@ -608,7 +608,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 256,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
.activate_on_init = true,
@@ -618,7 +618,7 @@ static const struct llcc_slice_config glymur_data[] = {
.max_cap = 256,
.priority = 3,
.fixed_size = true,
- .bonus_ways = 0xFFF,
+ .bonus_ways = 0xfff,
.res_ways = 0x0,
.vict_prio = true,
}
@@ -630,7 +630,7 @@ static const struct llcc_slice_config ipq5424_data[] = {
.slice_id = 1,
.max_cap = 128,
.priority = 3,
- .bonus_ways = 0x0FFF,
+ .bonus_ways = 0xfff,
.retain_on_pc = true,
.activate_on_init = true,
.write_scid_cacheable_en = true,
@@ -647,7 +647,7 @@ static const struct llcc_slice_config ipq5424_data[] = {
.max_cap = 768,
.priority = 1,
.fixed_size = true,
- .bonus_ways = 0x0FFF,
+ .bonus_ways = 0xfff,
.retain_on_pc = true,
.activate_on_init = true,
.write_scid_cacheable_en = true,
@@ -659,7 +659,7 @@ static const struct llcc_slice_config ipq5424_data[] = {
.slice_id = 5,
.max_cap = 128,
.priority = 3,
- .bonus_ways = 0x0FFF,
+ .bonus_ways = 0xfff,
.retain_on_pc = true,
.activate_on_init = true,
.write_scid_cacheable_en = true,
@@ -675,7 +675,7 @@ static const struct llcc_slice_config ipq5424_data[] = {
.slice_id = 6,
.max_cap = 128,
.priority = 3,
- .bonus_ways = 0xC000,
+ .bonus_ways = 0xc000,
.retain_on_pc = true,
.activate_on_init = true,
.write_scid_cacheable_en = true,
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/2] soc: qcom: llcc-qcom: Fix whitespace in slice config arrays
2026-10-20 16:54 [PATCH 0/2] Miscellaneous updates to the Qualcomm LLCC driver Kathiravan Thirumoorthy
2026-10-20 16:54 ` [PATCH 1/2] soc: qcom: llcc-qcom: Use lowercase hex consistently Kathiravan Thirumoorthy
@ 2026-10-20 16:54 ` Kathiravan Thirumoorthy
1 sibling, 0 replies; 3+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-10-20 16:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa
Cc: linux-arm-msm, linux-kernel, Kathiravan Thirumoorthy
Some slice configuration arrays use two spaces before the opening brace.
Also, sdm845_data has the first element's opening brace on the same line
as the array declaration.
Use a single space before the opening brace and move the first element's
opening brace to a new line to match the rest of the driver.
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
drivers/soc/qcom/llcc-qcom.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 2edc5ec31249..aaebe71e2b01 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -624,7 +624,7 @@ static const struct llcc_slice_config glymur_data[] = {
}
};
-static const struct llcc_slice_config ipq5424_data[] = {
+static const struct llcc_slice_config ipq5424_data[] = {
{
.usecase_id = LLCC_PPE_RXDESC,
.slice_id = 1,
@@ -1176,7 +1176,7 @@ static const struct llcc_slice_config nord_data[] = {
},
};
-static const struct llcc_slice_config sa8775p_data[] = {
+static const struct llcc_slice_config sa8775p_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -1724,7 +1724,7 @@ static const struct llcc_slice_config sar2130p_data[] = {
},
};
-static const struct llcc_slice_config sc7180_data[] = {
+static const struct llcc_slice_config sc7180_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -1761,7 +1761,7 @@ static const struct llcc_slice_config sc7180_data[] = {
},
};
-static const struct llcc_slice_config sc7280_data[] = {
+static const struct llcc_slice_config sc7280_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -2283,7 +2283,8 @@ static const struct llcc_slice_config sdm670_data[] = {
},
};
-static const struct llcc_slice_config sdm845_data[] = {{
+static const struct llcc_slice_config sdm845_data[] = {
+ {
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
.max_cap = 2816,
@@ -2481,7 +2482,7 @@ static const struct llcc_slice_config shikra_data[] = {
},
};
-static const struct llcc_slice_config sm6350_data[] = {
+static const struct llcc_slice_config sm6350_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -2544,7 +2545,7 @@ static const struct llcc_slice_config sm6350_data[] = {
},
};
-static const struct llcc_slice_config sm7150_data[] = {
+static const struct llcc_slice_config sm7150_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -2591,7 +2592,7 @@ static const struct llcc_slice_config sm7150_data[] = {
},
};
-static const struct llcc_slice_config sm8150_data[] = {
+static const struct llcc_slice_config sm8150_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -2784,7 +2785,7 @@ static const struct llcc_slice_config sm8150_data[] = {
},
};
-static const struct llcc_slice_config sm8250_data[] = {
+static const struct llcc_slice_config sm8250_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -2925,7 +2926,7 @@ static const struct llcc_slice_config sm8250_data[] = {
},
};
-static const struct llcc_slice_config sm8350_data[] = {
+static const struct llcc_slice_config sm8350_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -3098,7 +3099,7 @@ static const struct llcc_slice_config sm8350_data[] = {
},
};
-static const struct llcc_slice_config sm8450_data[] = {
+static const struct llcc_slice_config sm8450_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
@@ -3307,7 +3308,7 @@ static const struct llcc_slice_config sm8450_data[] = {
},
};
-static const struct llcc_slice_config sm8550_data[] = {
+static const struct llcc_slice_config sm8550_data[] = {
{
.usecase_id = LLCC_CPUSS,
.slice_id = 1,
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread