From: Takashi Iwai <tiwai@suse.de>
To: linux-acpi@vger.kernel.org
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Hanjun Guo <guohanjun@huawei.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] efi/cper: Fix forgotten type check in cper_print_arm_err_info()
Date: Tue, 20 Oct 2026 17:34:29 +0200 [thread overview]
Message-ID: <20261020153449.419646-1-tiwai@suse.de> (raw)
In the previous conversion of CPER type to bitmap in the commit
96b010536ee0 ("efi/cper: align ARM CPER type with UEFI 2.9A/2.10
specs"), one place was forgotten to be replaced, ended up with the
incorrect comparison. Fix it to the bitmap comparison.
Fixes: 96b010536ee0 ("efi/cper: align ARM CPER type with UEFI 2.9A/2.10 specs")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
Just spotted by a code review, not really tested
drivers/firmware/efi/cper-arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/cper-arm.c b/drivers/firmware/efi/cper-arm.c
index b21cb1232d82..b620cc9f8b5d 100644
--- a/drivers/firmware/efi/cper-arm.c
+++ b/drivers/firmware/efi/cper-arm.c
@@ -181,7 +181,7 @@ static void cper_print_arm_err_info(const char *pfx, u32 type,
}
/* The rest of the fields are specific to bus errors */
- if (type != CPER_ARM_BUS_ERROR)
+ if (!(type & CPER_ARM_BUS_ERROR))
return;
if (error_info & CPER_ARM_ERR_VALID_PARTICIPATION_TYPE) {
--
2.55.0
reply other threads:[~2026-10-20 15:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020153449.419646-1-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=bp@alien8.de \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®