* [PATCH] efi/cper: Fix forgotten type check in cper_print_arm_err_info()
@ 2026-10-20 15:34 Takashi Iwai
0 siblings, 0 replies; only message in thread
From: Takashi Iwai @ 2026-10-20 15:34 UTC (permalink / raw)
To: linux-acpi
Cc: Rafael J . Wysocki, Tony Luck, Borislav Petkov, Hanjun Guo,
Mauro Carvalho Chehab, Shuai Xue, linux-kernel
In the previous conversion of CPER type to bitmap in the commit
96b010536ee0 ("efi/cper: align ARM CPER type with UEFI 2.9A/2.10
specs"), one place was forgotten to be replaced, ended up with the
incorrect comparison. Fix it to the bitmap comparison.
Fixes: 96b010536ee0 ("efi/cper: align ARM CPER type with UEFI 2.9A/2.10 specs")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
Just spotted by a code review, not really tested
drivers/firmware/efi/cper-arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/cper-arm.c b/drivers/firmware/efi/cper-arm.c
index b21cb1232d82..b620cc9f8b5d 100644
--- a/drivers/firmware/efi/cper-arm.c
+++ b/drivers/firmware/efi/cper-arm.c
@@ -181,7 +181,7 @@ static void cper_print_arm_err_info(const char *pfx, u32 type,
}
/* The rest of the fields are specific to bus errors */
- if (type != CPER_ARM_BUS_ERROR)
+ if (!(type & CPER_ARM_BUS_ERROR))
return;
if (error_info & CPER_ARM_ERR_VALID_PARTICIPATION_TYPE) {
--
2.55.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-20 15:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-20 15:34 [PATCH] efi/cper: Fix forgotten type check in cper_print_arm_err_info() Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®