* [PATCH v1 1/1] drm/amdkfd: Do not use internal implementation of tolower()
@ 2026-10-21 8:46 Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2026-10-21 8:46 UTC (permalink / raw)
To: Alex Deucher, amd-gfx, dri-devel, linux-kernel
Cc: Felix Kuehling, Christian König, David Airlie,
Simona Vetter, Andy Shevchenko
ctype.h provides tolower() macro specifically for the cases
that might be architecture-optimised. Using __tolower(),
which is internal implementation, needs a good justification,
as this driver is the only user of that and there is no evidence
it's required.
Note, currently it's no difference as the macro always defined
to the internal implementation, but it might change in the future.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 35b3abe57b80..1ef4d26a0ac6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -2091,7 +2091,7 @@ int kfd_topology_add_device(struct kfd_node *gpu)
* needed for the topology
*/
for (i = 0; i < KFD_TOPOLOGY_PUBLIC_NAME_SIZE-1; i++) {
- dev->node_props.name[i] = __tolower(asic_name[i]);
+ dev->node_props.name[i] = tolower(asic_name[i]);
if (asic_name[i] == '\0')
break;
}
--
2.50.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-21 8:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-21 8:46 [PATCH v1 1/1] drm/amdkfd: Do not use internal implementation of tolower() Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®