[PATCH] phy: rockchip: inno-usb2: Remove redundant dev_err()

[PATCH] phy: rockchip: inno-usb2: Remove redundant dev_err()

[Diederik de Haas]

The devm_request_threaded_irq() function already automatically logs
detailed error messages on failure since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
So remove the now-redundant driver-specific dev_err() calls.

Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 23 ++++---------------
 1 file changed, 5 insertions(+), 18 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index e47b89015586..0a8a22e7aa9c 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1183,10 +1183,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy,
 						rockchip_usb2phy_linestate_irq,
 						IRQF_ONESHOT,
 						"rockchip_usb2phy", rport);
-		if (ret) {
-			dev_err(rphy->dev, "failed to request linestate irq handle\n");
+		if (ret)
 			return ret;
-		}
 		break;
 	case USB2PHY_PORT_OTG:
 		/*
@@ -1202,11 +1200,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy,
 							IRQF_ONESHOT,
 							"rockchip_usb2phy_otg",
 							rport);
-			if (ret) {
-				dev_err(rphy->dev,
-					"failed to request otg-mux irq handle\n");
+			if (ret)
 				return ret;
-			}
 		} else {
 			rport->bvalid_irq = of_irq_get_byname(child_np, "otg-bvalid");
 			if (rport->bvalid_irq < 0) {
@@ -1221,11 +1216,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy,
 							IRQF_ONESHOT,
 							"rockchip_usb2phy_bvalid",
 							rport);
-			if (ret) {
-				dev_err(rphy->dev,
-					"failed to request otg-bvalid irq handle\n");
+			if (ret)
 				return ret;
-			}
 
 			rport->id_irq = of_irq_get_byname(child_np, "otg-id");
 			if (rport->id_irq < 0) {
@@ -1240,11 +1232,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy,
 							IRQF_ONESHOT,
 							"rockchip_usb2phy_id",
 							rport);
-			if (ret) {
-				dev_err(rphy->dev,
-					"failed to request otg-id irq handle\n");
+			if (ret)
 				return ret;
-			}
 		}
 		break;
 	default:
@@ -1491,10 +1480,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
 						IRQF_ONESHOT,
 						"rockchip_usb2phy",
 						rphy);
-		if (ret) {
-			dev_err_probe(rphy->dev, ret, "failed to request usb2phy irq handle\n");
+		if (ret)
 			return ret;
-		}
 	}
 
 	return PTR_ERR_OR_ZERO(provider);
-- 
2.55.0

Re: [PATCH] phy: rockchip: inno-usb2: Remove redundant dev_err()

[Heiko Stübner]

Am Mittwoch, 21. Oktober 2026, 12:21:20 Mitteleuropäische Sommerzeit schrieb Diederik de Haas:
> The devm_request_threaded_irq() function already automatically logs
> detailed error messages on failure since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> So remove the now-redundant driver-specific dev_err() calls.
> 
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>