From: Jinyu Tang <jinyu.tang@linux.dev>
To: SeungJu Cheon <suunj1331@gmail.com>
Cc: Jinyu Tang <jinyu.tang@linux.dev>,
anup@brainfault.org, atish.patra@linux.dev, tjytimi@163.com,
inochiama@gmail.com, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, andrew.jones@linux.dev,
pbonzini@redhat.com, seanjc@google.com,
kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: riscv: Set Accessed bit in dirty-log write fault fast path
Date: Wed, 21 Oct 2026 19:30:10 +0800 [thread overview]
Message-ID: <20261021113010.2476783-1-jinyu.tang@linux.dev> (raw)
In-Reply-To: <20261016101458.221648-1-suunj1331@gmail.com>
On Fri, Oct 16, 2026 at 07:14:58PM +0900, SeungJu Cheon wrote:
> @@ -591,14 +591,15 @@ static bool kvm_riscv_mmu_dirty_log_write_fault_fast(struct kvm *kvm,
> dirty_marked = true;
> }
>
> - if ((pte_val(old_pte) & (_PAGE_WRITE | _PAGE_DIRTY)) ==
> - (_PAGE_WRITE | _PAGE_DIRTY)) {
> + if ((pte_val(old_pte) &
> + (_PAGE_WRITE | _PAGE_DIRTY | _PAGE_ACCESSED)) ==
> + (_PAGE_WRITE | _PAGE_DIRTY | _PAGE_ACCESSED)) {
> new_pte = old_pte;
> ret = true;
> break;
> }
>
> - new_pte = pte_mkdirty(pte_mkwrite_novma(old_pte));
> + new_pte = pte_mkyoung(pte_mkdirty(pte_mkwrite_novma(old_pte)));
I tested this on QEMU 10.2.1 with Svade enabled and Svadu disabled.
With dirty logging enabled, the test clears A through page-idle tracking,
write-protects the page with KVM_GET_DIRTY_LOG, and resumes the guest
write. The unpatched kernel times out after 10 seconds, while the same
test completes with this patch applied.
Reviewed-by: Jinyu Tang <jinyu.tang@linux.dev>
Thanks,
Jinyu
prev parent reply other threads:[~2026-10-21 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 10:14 SeungJu Cheon
2026-10-21 11:30 ` Jinyu Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021113010.2476783-1-jinyu.tang@linux.dev \
--to=jinyu.tang@linux.dev \
--cc=alex@ghiti.fr \
--cc=andrew.jones@linux.dev \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=inochiama@gmail.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=pjw@kernel.org \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=suunj1331@gmail.com \
--cc=tjytimi@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®