mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lee Yongjun <jun85566@gmail.com>,
	stern@rowland.harvard.edu, gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, digidietze@draisberghof.de,
	xiehongyu1@kylinos.cn, linux-usb@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	syzbot+7317196294d50d6e55c3@syzkaller.appspotmail.com,
	Lee Yongjun <jun85566@gmail.com>
Subject: Re: [PATCH v2] usb-storage: option_ms: bound probe-time bulk transfers
Date: Thu, 22 Oct 2026 06:22:03 +0800	[thread overview]
Message-ID: <202610220624.5aofbefV-lkp@intel.com> (raw)
In-Reply-To: <20261021081616.89976-1-jun85566@gmail.com>

Hi Lee,

kernel test robot noticed the following build errors:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master v7.3 next-20261020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lee-Yongjun/usb-storage-option_ms-bound-probe-time-bulk-transfers/20261021-171616
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20261021081616.89976-1-jun85566%40gmail.com
patch subject: [PATCH v2] usb-storage: option_ms: bound probe-time bulk transfers
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20261022/202610220624.5aofbefV-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261022/202610220624.5aofbefV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610220624.5aofbefV-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/usb/storage/option_ms.c: In function 'option_rezero':
>> drivers/usb/storage/option_ms.c:49:18: error: implicit declaration of function 'usb_stor_bulk_transfer_buf_timeout'; did you mean 'usb_stor_bulk_transfer_buf'? [-Wimplicit-function-declaration]
      49 |         result = usb_stor_bulk_transfer_buf_timeout(us, us->send_bulk_pipe,
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                  usb_stor_bulk_transfer_buf


vim +49 drivers/usb/storage/option_ms.c

    30	
    31	static int option_rezero(struct us_data *us)
    32	{
    33		static const unsigned char rezero_msg[] = {
    34		  0x55, 0x53, 0x42, 0x43, 0x78, 0x56, 0x34, 0x12,
    35		  0x01, 0x00, 0x00, 0x00, 0x80, 0x00, 0x06, 0x01,
    36		  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    37		  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
    38		};
    39		char *buffer;
    40		int result;
    41	
    42		usb_stor_dbg(us, "Option MS: %s\n", "DEVICE MODE SWITCH");
    43	
    44		buffer = kzalloc(RESPONSE_LEN, GFP_KERNEL);
    45		if (buffer == NULL)
    46			return USB_STOR_TRANSPORT_ERROR;
    47	
    48		memcpy(buffer, rezero_msg, sizeof(rezero_msg));
  > 49		result = usb_stor_bulk_transfer_buf_timeout(us, us->send_bulk_pipe,
    50							    buffer, sizeof(rezero_msg), NULL,
    51							    OPTION_MS_PROBE_TIMEOUT);
    52		if (result != USB_STOR_XFER_GOOD) {
    53			result = USB_STOR_XFER_ERROR;
    54			goto out;
    55		}
    56	
    57		/*
    58		 * Some of the devices need to be asked for a response, but we don't
    59		 * care what that response is.
    60		 */
    61		usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
    62						   buffer, RESPONSE_LEN, NULL,
    63						   OPTION_MS_PROBE_TIMEOUT);
    64	
    65		/* Read the CSW */
    66		usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
    67						   buffer, 13, NULL,
    68						   OPTION_MS_PROBE_TIMEOUT);
    69	
    70		result = USB_STOR_XFER_GOOD;
    71	
    72	out:
    73		kfree(buffer);
    74		return result;
    75	}
    76	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2026-10-21 22:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  8:16 Lee Yongjun
2026-10-21  9:48 ` Oliver Neukum
2026-10-21 22:22 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202610220624.5aofbefV-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=digidietze@draisberghof.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun85566@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+7317196294d50d6e55c3@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=usb-storage@lists.one-eyed-alien.net \
    --cc=xiehongyu1@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®