From: Oliver Neukum <oneukum@suse.com>
To: Lee Yongjun <jun85566@gmail.com>,
stern@rowland.harvard.edu, gregkh@linuxfoundation.org
Cc: digidietze@draisberghof.de, xiehongyu1@kylinos.cn,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
syzbot+7317196294d50d6e55c3@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] usb-storage: option_ms: bound probe-time bulk transfers
Date: Wed, 21 Oct 2026 11:48:28 +0200 [thread overview]
Message-ID: <d7475b92-a7c9-4b0d-98dd-37d081cb46ef@suse.com> (raw)
In-Reply-To: <20261021081616.89976-1-jun85566@gmail.com>
Hi,
On 21.10.26 10:16, Lee Yongjun wrote:
> @@ -112,9 +114,9 @@ static int option_inquiry(struct us_data *us)
> result = memcmp(buffer+8, "ZCOPTION", 8);
>
> /* Read the CSW */
> - usb_stor_bulk_transfer_buf(us,
> - us->recv_bulk_pipe,
> - buffer, 13, NULL);
> + usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
You have introduced an additional failure mode with giving a timeout.
If you run into the timeout, the device will not work. That means
you can no longer ignore error returns.
Regards
Oliver
next prev parent reply other threads:[~2026-10-21 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 8:16 Lee Yongjun
2026-10-21 9:48 ` Oliver Neukum [this message]
2026-10-21 22:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7475b92-a7c9-4b0d-98dd-37d081cb46ef@suse.com \
--to=oneukum@suse.com \
--cc=digidietze@draisberghof.de \
--cc=gregkh@linuxfoundation.org \
--cc=jun85566@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+7317196294d50d6e55c3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=xiehongyu1@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®