* [PATCH] staging: greybus: Use GFP_KERNEL for audio manager allocation
@ 2026-10-23 13:40 Torra Sowmya
2026-10-23 14:07 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Torra Sowmya @ 2026-10-23 13:40 UTC (permalink / raw)
To: outreachy
Cc: vaibhav.sr, mgreer, johan, elder, gregkh, greybus-dev,
linux-staging, linux-kernel
The audio manager module is created in a context that permits
sleeping. Its caller, gb_audio_manager_add(), already uses
GFP_KERNEL through ida_alloc(), and module creation subsequently
calls kobject_init_and_add().
GFP_ATOMIC is unnecessary in this context and restricts memory
reclaim. Remove the explicit flag to use the default GFP_KERNEL
allocation.
Signed-off-by: Torra Sowmya <sowmyatorra@gmail.com>
---
drivers/staging/greybus/audio_manager_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index dc90cc2d2308..8a9f7e7d1766 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -187,7 +187,7 @@ int gb_audio_manager_module_create(struct gb_audio_manager_module **module,
int err;
struct gb_audio_manager_module *m;
- m = kzalloc_obj(*m, GFP_ATOMIC);
+ m = kzalloc_obj(*m);
if (!m)
return -ENOMEM;
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: Use GFP_KERNEL for audio manager allocation
2026-10-23 13:40 [PATCH] staging: greybus: Use GFP_KERNEL for audio manager allocation Torra Sowmya
@ 2026-10-23 14:07 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2026-10-23 14:07 UTC (permalink / raw)
To: Torra Sowmya, outreachy
Cc: vaibhav.sr, mgreer, johan, elder, gregkh, greybus-dev,
linux-staging, linux-kernel
On 10/23/26 8:40 AM, Torra Sowmya wrote:
> The audio manager module is created in a context that permits
> sleeping. Its caller, gb_audio_manager_add(), already uses
> GFP_KERNEL through ida_alloc(), and module creation subsequently
> calls kobject_init_and_add().
>
> GFP_ATOMIC is unnecessary in this context and restricts memory
> reclaim. Remove the explicit flag to use the default GFP_KERNEL
> allocation.
>
> Signed-off-by: Torra Sowmya <sowmyatorra@gmail.com>
Looks good to me.
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> drivers/staging/greybus/audio_manager_module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index dc90cc2d2308..8a9f7e7d1766 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -187,7 +187,7 @@ int gb_audio_manager_module_create(struct gb_audio_manager_module **module,
> int err;
> struct gb_audio_manager_module *m;
>
> - m = kzalloc_obj(*m, GFP_ATOMIC);
> + m = kzalloc_obj(*m);
> if (!m)
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-23 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-23 13:40 [PATCH] staging: greybus: Use GFP_KERNEL for audio manager allocation Torra Sowmya
2026-10-23 14:07 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®