From: Jakub Kicinski <kuba@kernel.org>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: "Oliver Neukum" <oliver@neukum.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Sjur Brændeland" <sjur.brandeland@stericsson.com>,
"Alexey Orishko" <alexey.orishko@gmail.com>,
"Bjørn Mork" <bjorn@mork.no>,
"Greg Suarez" <gsuarez@smithmicro.com>,
"Breno Leitao" <leitao@debian.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] net: usb: cdc_mbim: don't enable BHs in tx_fixup under netpoll
Date: Fri, 23 Oct 2026 13:46:41 -0700 [thread overview]
Message-ID: <20261023134641.4c08e3b9@kernel.org> (raw)
In-Reply-To: <20261021-cdc-ncm-netpoll-v2-2-8818965bbb69@tipi-net.de>
On Wed, 21 Oct 2026 09:56:19 +0200 Nicolai Buchwitz wrote:
> - spin_lock_bh(&ctx->mtx);
> + /* IRQs are off and BHs on under netpoll, see cdc_ncm_tx_fixup() */
> + spin_lock_irqsave(&ctx->mtx, irqflags);
> skb_out = cdc_ncm_fill_tx_frame(dev, skb, sign);
Sashiko is concerned that we are now running cdc_ncm_fill_tx_frame()
with IRQs disabled, I think the suggestion to use plain spin_lock()
would work? The xmit lock shields us from recursion here.
Same for patch 1.
--
pw-bot: cr
prev parent reply other threads:[~2026-10-23 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 7:56 [PATCH net v2 0/2] net: usb: cdc_ncm/cdc_mbim: fix netpoll lockup in tx_fixup Nicolai Buchwitz
2026-10-21 7:56 ` [PATCH net v2 1/2] net: usb: cdc_ncm: don't enable BHs in tx_fixup under netpoll Nicolai Buchwitz
2026-10-22 12:58 ` Simon Horman
2026-10-21 7:56 ` [PATCH net v2 2/2] net: usb: cdc_mbim: " Nicolai Buchwitz
2026-10-22 12:58 ` Simon Horman
2026-10-23 20:46 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023134641.4c08e3b9@kernel.org \
--to=kuba@kernel.org \
--cc=alexey.orishko@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gsuarez@smithmicro.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®