mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: "Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Prabhakar <prabhakar.csengg+renesas@gmail.com>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v3 6/8] iio: adc: rzt2h: Prepare for SoCs with different ADC info
Date: Fri, 23 Oct 2026 21:45:42 +0100	[thread overview]
Message-ID: <20261023214542.49c6304f@jic23-hlaptop> (raw)
In-Reply-To: <20261023175919.160103-7-prabhakar.mahadev-lad.rj@bp.renesas.com>

On Fri, 23 Oct 2026 18:59:17 +0100
Prabhakar <prabhakar.csengg@gmail.com> wrote:

> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Prepare the driver for RZ/V2H(P) support, where the ADC supports 8-bit and
> 12-bit conversion modes with channel configurations that differ from
> RZ/T2H.
> 
> Allow each SoC to provide its own IIO info structure and use the
> chip-specific configuration when registering the IIO device.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

FWIW as I'm not going to ask you to respin for this...
I think this should just have been squashed with patch 3 where
*_chip_info was originally introduced.

> ---
> v2->v3:
> - No change
> 
> v1->v2:
> - No change
> ---
>  drivers/iio/adc/rzt2h_adc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/rzt2h_adc.c b/drivers/iio/adc/rzt2h_adc.c
> index 94dad479abff..dbe82939acc2 100644
> --- a/drivers/iio/adc/rzt2h_adc.c
> +++ b/drivers/iio/adc/rzt2h_adc.c
> @@ -68,6 +68,7 @@ struct rzt2h_adc;
>  struct rzt2h_adc_chip_info {
>  	const struct iio_chan_spec *chan_template;
>  	int (*sst_to_freq)(struct rzt2h_adc *adc, u8 sst);
> +	const struct iio_info *info;
>  	unsigned int num_channels;
>  	u8 features;
>  };
> @@ -763,7 +764,7 @@ static int rzt2h_adc_probe(struct platform_device *pdev)
>  		return ret;
>  
>  	indio_dev->name = "rzt2h-adc";
> -	indio_dev->info = &rzt2h_adc_iio_info;
> +	indio_dev->info = chip_info->info;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->channels = adc->channels;
>  	indio_dev->num_channels = adc->num_channels;
> @@ -778,6 +779,7 @@ static int rzt2h_adc_probe(struct platform_device *pdev)
>  static const struct rzt2h_adc_chip_info rzt2h_adc_info = {
>  	.chan_template = &rzt2h_adc_chan_template,
>  	.sst_to_freq = rzt2h_adc_sst_to_freq,
> +	.info = &rzt2h_adc_iio_info,
>  	.num_channels = 16,
>  	.features = RZT2H_ADC_FEATURE_CALIBRATION | RZT2H_ADC_FEATURE_SAMPLE_STATE,
>  };


  reply	other threads:[~2026-10-23 20:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 17:59 [PATCH v3 0/8] Add ADC driver support for RZ/V2H(P) and RZ/V2N SoCs Prabhakar
2026-10-23 17:59 ` [PATCH v3 1/8] dt-bindings: iio: adc: renesas,r9a09g077-adc: Add RZ/V2H(P) and RZ/V2N support Prabhakar
2026-10-23 17:59 ` [PATCH v3 2/8] iio: adc: rzt2h: Wait for the analog part to stop after a forced stop Prabhakar
2026-10-23 17:59 ` [PATCH v3 3/8] iio: adc: rzt2h: Add chip-specific configuration Prabhakar
2026-10-23 17:59 ` [PATCH v3 4/8] iio: adc: rzt2h: Add optional reset support Prabhakar
2026-10-23 17:59 ` [PATCH v3 5/8] iio: adc: rzt2h: Prepare for SoCs without sample state registers Prabhakar
2026-10-23 17:59 ` [PATCH v3 6/8] iio: adc: rzt2h: Prepare for SoCs with different ADC info Prabhakar
2026-10-23 20:45   ` Jonathan Cameron [this message]
2026-10-23 17:59 ` [PATCH v3 7/8] iio: adc: rzt2h: Use scan type for ADC scale Prabhakar
2026-10-23 17:59 ` [PATCH v3 8/8] iio: adc: rzt2h: Add support for RZ/V2H(P) SoC Prabhakar
2026-10-24 10:38   ` Andy Shevchenko
2026-10-23 20:49 ` [PATCH v3 0/8] Add ADC driver support for RZ/V2H(P) and RZ/V2N SoCs Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261023214542.49c6304f@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=p.zabel@pengutronix.de \
    --cc=prabhakar.csengg+renesas@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®