mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jesper X Nilsson <jesper.x.nilsson@axis.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Stefan Windfeldt-Prytz" <stefan.windfeldt-prytz@axis.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: light: opt4001: add opt4041
Date: Fri, 23 Oct 2026 21:54:09 +0100	[thread overview]
Message-ID: <20261023215409.4c4ff7d6@jic23-hlaptop> (raw)
In-Reply-To: <20261023-opt4041-v2-1-ee320812804c@axis.com>

On Fri, 23 Oct 2026 14:30:28 +0200
Jesper X Nilsson <jesper.x.nilsson@axis.com> wrote:

> Add a new compatible for opt4041. The opt4041 is only available in the
> SOT-5X3 package. The device is pin compatible with the opt4001-sot-5x3
> and shares the same properties. The opt4041 has one additional channel
> compared to opt4001, the extra channel has a wide spectral bandwidth
> ranging from 380nm to 1000nm.
> 
> Datasheet: https://www.ti.com/lit/gpn/opt4041
> Signed-off-by: Jesper X Nilsson <jesper.x.nilsson@axis.com>
> ---
>  Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml
> index 12b0c7ed5d72..35e9b0deb944 100644
> --- a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/light/ti,opt4001.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Texas Instruments OPT4001 Ambient Light Sensor
> +title: Texas Instruments OPT4001/OPT4041 Ambient Light Sensor
>  
>  maintainers:
>    - Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
> @@ -13,13 +13,16 @@ description:
>    Ambient light sensor with an i2c interface.
>    Last part of compatible is for the packaging used.
>    Picostar is a 4 pinned SMT and sot-5x3 is a 8 pinned SOT.
> +  OPT4041 is only available as sot-5x3 and adds a wide band channel.

I guess we keep the compatible naming because some crazy
person might one day release it in a different package.

J
>    https://www.ti.com/lit/gpn/opt4001
> +  https://www.ti.com/lit/gpn/opt4041
>  
>  properties:
>    compatible:
>      enum:
>        - ti,opt4001-picostar
>        - ti,opt4001-sot-5x3
> +      - ti,opt4041-sot-5x3
>  
>    reg:
>      maxItems: 1
> @@ -39,7 +42,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: ti,opt4001-sot-5x3
> +            enum:
> +              - ti,opt4001-sot-5x3
> +              - ti,opt4041-sot-5x3
>      then:
>        properties:
>          interrupts:
> 


  parent reply	other threads:[~2026-10-23 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 12:30 [PATCH v2 0/4] This series adds support for Texas Instruments OPT4041 Ambient light sensor Jesper X Nilsson
2026-10-23 12:30 ` [PATCH v2 1/4] dt-bindings: iio: light: opt4001: add opt4041 Jesper X Nilsson
2026-10-23 17:37   ` Conor Dooley
2026-10-23 20:54   ` Jonathan Cameron [this message]
2026-10-23 12:30 ` [PATCH v2 2/4] iio: light: opt4001: Re-use generic struct s32_fract Jesper X Nilsson
2026-10-23 12:30 ` [PATCH v2 3/4] iio: light: opt4001: refactor driver to prepare to support more devices Jesper X Nilsson
2026-10-23 13:51   ` Andy Shevchenko
2026-10-23 12:30 ` [PATCH v2 4/4] iio: light: opt4001: add support for opt4041 Jesper X Nilsson
2026-10-23 13:53   ` Andy Shevchenko
2026-10-23 20:58 ` [PATCH v2 0/4] This series adds support for Texas Instruments OPT4041 Ambient light sensor Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261023215409.4c4ff7d6@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jesper.x.nilsson@axis.com \
    --cc=kernel@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=stefan.windfeldt-prytz@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®