mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Akhil P Oommen <akhilpo@oss.qualcomm.com>
To: "Rob Clark" <robin.clark@oss.qualcomm.com>,
	"Sean Paul" <sean@poorly.run>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Dmitry Baryshkov" <lumag@kernel.org>,
	"Abhinav Kumar" <abhinav.kumar@linux.dev>,
	"Jessica Zhang" <jesszhan0024@gmail.com>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Jordan Crouse" <jordan@cosmicpenguin.net>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Luben Tuikov" <ltuikov89@gmail.com>,
	"Antonino Maniscalco" <antomani103@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Jie Zhang <jie.zhang@oss.qualcomm.com>,
	stable@vger.kernel.org
Subject: [PATCH 4/8] drm/msm/devfreq: Record idle_time at GPU idle onset
Date: Sat, 24 Oct 2026 16:00:10 +0530	[thread overview]
Message-ID: <20261024-assorted-fixes-oct-v1-4-2977f974ddb7@oss.qualcomm.com> (raw)
In-Reply-To: <20261024-assorted-fixes-oct-v1-0-2977f974ddb7@oss.qualcomm.com>

From: Jie Zhang <jie.zhang@oss.qualcomm.com>

Setting df->idle_time in msm_devfreq_idle_work() means a cancelled
idle_work leaves a stale timestamp, causing idle_time to accumulate
across idle cycles and potentially trigger a spurious devfreq boost.

Move the assignment to msm_devfreq_idle() so the timestamp always
reflects the actual GPU idle onset.

Fixes: 658f4c829688 ("drm/msm/devfreq: Add 1ms delay before clamping freq")
Cc: stable@vger.kernel.org
Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
 drivers/gpu/drm/msm/msm_gpu_devfreq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
index 2e1d5c343272..f3c664b20a1b 100644
--- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
+++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
@@ -357,7 +357,6 @@ static void msm_devfreq_idle_work(struct kthread_work *work)
 	if (priv->gpu_clamp_to_idle)
 		msm_devfreq_target(&gpu->pdev->dev, &target_freq, 0);
 
-	df->idle_time = ktime_get();
 	df->idle_freq = idle_freq;
 
 	mutex_unlock(&df->devfreq->lock);
@@ -370,6 +369,8 @@ void msm_devfreq_idle(struct msm_gpu *gpu)
 	if (!has_devfreq(gpu))
 		return;
 
+	df->idle_time = ktime_get();
+
 	msm_hrtimer_queue_work(&df->idle_work, ms_to_ktime(1),
 			       HRTIMER_MODE_REL);
 }

-- 
2.55.0


  parent reply	other threads:[~2026-10-24 10:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 10:30 [PATCH 0/8] drm/msm: Assorted fixes - October Akhil P Oommen
2026-10-24 10:30 ` [PATCH 1/8] drm/msm/a6xx: Check BX dependency vote index Akhil P Oommen
2026-10-26  9:46   ` Konrad Dybcio
2026-10-24 10:30 ` [PATCH 2/8] drm/msm/a6xx: Fix GMU shutdown idle check Akhil P Oommen
2026-10-26  9:47   ` Konrad Dybcio
2026-10-24 10:30 ` [PATCH 3/8] drm/msm/a6xx: Fix stale boot up BW vote Akhil P Oommen
2026-10-26  9:52   ` Konrad Dybcio
2026-10-24 10:30 ` Akhil P Oommen [this message]
2026-10-26  9:48   ` [PATCH 4/8] drm/msm/devfreq: Record idle_time at GPU idle onset Konrad Dybcio
2026-10-24 10:30 ` [PATCH 5/8] drm/msm: Fix sched_prio inversion within a ring Akhil P Oommen
2026-10-26  9:53   ` Konrad Dybcio
2026-10-24 10:30 ` [PATCH 6/8] drm/msm/a6xx: Reset preemption records across suspend Akhil P Oommen
2026-10-24 18:29   ` Connor Abbott
2026-10-24 10:30 ` [PATCH 7/8] drm/msm/a6xx: Request CLX enable from secure world Akhil P Oommen
2026-10-26  9:54   ` Konrad Dybcio
2026-10-24 10:30 ` [PATCH 8/8] drm/msm/a8xx: Add AQE firmware to Adreno X2-90 GPU Akhil P Oommen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024-assorted-fixes-oct-v1-4-2977f974ddb7@oss.qualcomm.com \
    --to=akhilpo@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=antomani103@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=jie.zhang@oss.qualcomm.com \
    --cc=jordan@cosmicpenguin.net \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltuikov89@gmail.com \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®