mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>,
	 Cosmo Chou <cosmo.chou@quantatw.com>,
	Andy Chung <andy.chung@amd.com>,
	 Ninad Palsule <ninad@linux.ibm.com>,
	 Abdurrahman Hussain <abdurrahman@nexthop.ai>,
	 Robert Marko <robert.marko@sartura.hr>,
	 Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>,
	 Daniel Nilsson <daniel.nilsson@flex.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 00/31] hwmon: convert i2c_smbus_read_block_data() users to pass buffer length
Date: Sat, 24 Oct 2026 20:06:03 -0700	[thread overview]
Message-ID: <20261024-hwmon-i2c-smbus-read-block-data-v1-0-e81941ad0cd3@gmail.com> (raw)

Convert all callers of i2c_smbus_read_block_data() across the hwmon
and PMBus subsystems to pass destination buffer sizes, adopting the
4-argument form introduced in commit 68f382641f8c ("i2c: smbus: make
i2c_smbus_read_block_data() safer").

For drivers that used intermediate bounce buffers (lineage-pem, lm93,
and pt5161l), redundant buffer allocations and memcpy() calls are
dropped so data is read directly into target structures.

For drivers performing string comparisons on the read data
(acbel-fsg032, bpa-rs600, ltc4286, max15301, pim4328, and stpddc60),
ensure the destination buffer is explicitly NUL-terminated before
comparison, and pass a length that reserves space for the terminator.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Dmitry Torokhov (31):
      hwmon: (lineage-pem) use 4-argument i2c_smbus_read_block_data()
      hwmon: (lm93) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pt5161l) use 4-argument i2c_smbus_read_block_data()
      hwmon: (kb9002) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/acbel-fsg032) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/adm1266) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/aps-379) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/bpa-rs600) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/crps) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/d1u74t) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/dps920ab) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/fsp-3y) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/ibm-cffps) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/inspur-ipsps) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/ir35221) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/lt7182s) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/ltc4286) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/lx1308) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/max15301) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/max16601) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/max20730) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/mp5920) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/pim4328) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/pxe1610) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/q54sj108a2) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/stpddc60) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/tps53679) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/ucd9000) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/ucd9200) use 4-argument i2c_smbus_read_block_data()
      hwmon: (pmbus/zl6100) use 4-argument i2c_smbus_read_block_data()

 drivers/hwmon/kb9002.c             |  6 ++++--
 drivers/hwmon/lineage-pem.c        | 17 ++++++-----------
 drivers/hwmon/lm93.c               | 12 ++----------
 drivers/hwmon/pmbus/acbel-fsg032.c | 16 +++++++++-------
 drivers/hwmon/pmbus/adm1266.c      | 25 ++++++++++++++++---------
 drivers/hwmon/pmbus/aps-379.c      |  3 ++-
 drivers/hwmon/pmbus/bpa-rs600.c    |  5 +++--
 drivers/hwmon/pmbus/crps.c         |  5 +++--
 drivers/hwmon/pmbus/d1u74t.c       |  8 +++++---
 drivers/hwmon/pmbus/dps920ab.c     |  6 ++++--
 drivers/hwmon/pmbus/fsp-3y.c       |  3 ++-
 drivers/hwmon/pmbus/ibm-cffps.c    |  5 +++--
 drivers/hwmon/pmbus/inspur-ipsps.c |  4 ++--
 drivers/hwmon/pmbus/ir35221.c      |  6 ++++--
 drivers/hwmon/pmbus/lt7182s.c      |  6 ++++--
 drivers/hwmon/pmbus/ltc4286.c      |  8 ++++++--
 drivers/hwmon/pmbus/lx1308.c       |  9 ++++++---
 drivers/hwmon/pmbus/max15301.c     |  4 +++-
 drivers/hwmon/pmbus/max16601.c     |  7 ++++---
 drivers/hwmon/pmbus/max20730.c     |  9 ++++++---
 drivers/hwmon/pmbus/mp5920.c       |  3 ++-
 drivers/hwmon/pmbus/pim4328.c      |  4 +++-
 drivers/hwmon/pmbus/pmbus_core.c   |  3 ++-
 drivers/hwmon/pmbus/pxe1610.c      |  2 +-
 drivers/hwmon/pmbus/q54sj108a2.c   | 27 ++++++++++++++++++---------
 drivers/hwmon/pmbus/stpddc60.c     |  4 +++-
 drivers/hwmon/pmbus/tps53679.c     |  9 ++++++---
 drivers/hwmon/pmbus/ucd9000.c      |  8 +++++---
 drivers/hwmon/pmbus/ucd9200.c      |  4 ++--
 drivers/hwmon/pmbus/zl6100.c       |  2 +-
 drivers/hwmon/pt5161l.c            |  5 ++---
 31 files changed, 139 insertions(+), 96 deletions(-)
---
base-commit: 20a33c6b6cbe7e4805dfb6cd68816937443aa148
change-id: 20261022-hwmon-i2c-smbus-read-block-data-554b91958a09

Thanks.

-- 
Dmitry


             reply	other threads:[~2026-10-25  3:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25  3:06 Dmitry Torokhov [this message]
2026-10-25  3:06 ` [PATCH 01/31] hwmon: (lineage-pem) use 4-argument i2c_smbus_read_block_data() Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 02/31] hwmon: (lm93) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 03/31] hwmon: (pt5161l) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 04/31] hwmon: (kb9002) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 05/31] hwmon: (pmbus/acbel-fsg032) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 06/31] hwmon: (pmbus/adm1266) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 07/31] hwmon: (pmbus/aps-379) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 08/31] hwmon: (pmbus/bpa-rs600) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 09/31] hwmon: (pmbus/crps) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 10/31] hwmon: (pmbus/d1u74t) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 11/31] hwmon: (pmbus/dps920ab) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 12/31] hwmon: (pmbus/fsp-3y) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 13/31] hwmon: (pmbus/ibm-cffps) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 14/31] hwmon: (pmbus/inspur-ipsps) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 15/31] hwmon: (pmbus/ir35221) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 16/31] hwmon: (pmbus/lt7182s) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 17/31] hwmon: (pmbus/ltc4286) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 18/31] hwmon: (pmbus/lx1308) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 19/31] hwmon: (pmbus/max15301) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 20/31] hwmon: (pmbus/max16601) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 21/31] hwmon: (pmbus/max20730) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 22/31] hwmon: (pmbus/mp5920) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 23/31] hwmon: (pmbus/pim4328) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 24/31] hwmon: (pmbus) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 25/31] hwmon: (pmbus/pxe1610) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 26/31] hwmon: (pmbus/q54sj108a2) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 27/31] hwmon: (pmbus/stpddc60) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 28/31] hwmon: (pmbus/tps53679) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 29/31] hwmon: (pmbus/ucd9000) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 30/31] hwmon: (pmbus/ucd9200) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 31/31] hwmon: (pmbus/zl6100) " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024-hwmon-i2c-smbus-read-block-data-v1-0-e81941ad0cd3@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=Delphine_CC_Chiu@Wiwynn.com \
    --cc=abdurrahman@nexthop.ai \
    --cc=andy.chung@amd.com \
    --cc=cosmo.chou@quantatw.com \
    --cc=daniel.nilsson@flex.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ninad@linux.ibm.com \
    --cc=robert.marko@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®