mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>,
	 Cosmo Chou <cosmo.chou@quantatw.com>,
	Andy Chung <andy.chung@amd.com>,
	 Ninad Palsule <ninad@linux.ibm.com>,
	 Abdurrahman Hussain <abdurrahman@nexthop.ai>,
	 Robert Marko <robert.marko@sartura.hr>,
	 Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>,
	 Daniel Nilsson <daniel.nilsson@flex.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 01/31] hwmon: (lineage-pem) use 4-argument i2c_smbus_read_block_data()
Date: Sat, 24 Oct 2026 20:06:04 -0700	[thread overview]
Message-ID: <20261024-hwmon-i2c-smbus-read-block-data-v1-1-e81941ad0cd3@gmail.com> (raw)
In-Reply-To: <20261024-hwmon-i2c-smbus-read-block-data-v1-0-e81941ad0cd3@gmail.com>

Pass the expected data length and destination buffer directly to
i2c_smbus_read_block_data() instead of copying through an intermediate
buffer.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/hwmon/lineage-pem.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
index 2553e49f8401..75a44b0639dc 100644
--- a/drivers/hwmon/lineage-pem.c
+++ b/drivers/hwmon/lineage-pem.c
@@ -130,20 +130,15 @@ struct pem_data {
 static int pem_read_block(struct i2c_client *client, u8 command, u8 *data,
 			  int data_len)
 {
-	u8 block_buffer[I2C_SMBUS_BLOCK_MAX];
 	int result;
 
-	result = i2c_smbus_read_block_data(client, command, block_buffer);
+	result = i2c_smbus_read_block_data(client, command, data_len, data);
 	if (unlikely(result < 0))
-		goto abort;
-	if (unlikely(result == 0xff || result != data_len)) {
-		result = -EIO;
-		goto abort;
-	}
-	memcpy(data, block_buffer, data_len);
-	result = 0;
-abort:
-	return result;
+		return result;
+	if (unlikely(result == 0xff || result != data_len))
+		return -EIO;
+
+	return 0;
 }
 
 static struct pem_data *pem_update_device(struct device *dev)

-- 
2.56.0.257.gf7497c7d27-goog


  reply	other threads:[~2026-10-25  3:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25  3:06 [PATCH 00/31] hwmon: convert i2c_smbus_read_block_data() users to pass buffer length Dmitry Torokhov
2026-10-25  3:06 ` Dmitry Torokhov [this message]
2026-10-25  3:06 ` [PATCH 02/31] hwmon: (lm93) use 4-argument i2c_smbus_read_block_data() Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 03/31] hwmon: (pt5161l) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 04/31] hwmon: (kb9002) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 05/31] hwmon: (pmbus/acbel-fsg032) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 06/31] hwmon: (pmbus/adm1266) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 07/31] hwmon: (pmbus/aps-379) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 08/31] hwmon: (pmbus/bpa-rs600) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 09/31] hwmon: (pmbus/crps) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 10/31] hwmon: (pmbus/d1u74t) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 11/31] hwmon: (pmbus/dps920ab) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 12/31] hwmon: (pmbus/fsp-3y) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 13/31] hwmon: (pmbus/ibm-cffps) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 14/31] hwmon: (pmbus/inspur-ipsps) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 15/31] hwmon: (pmbus/ir35221) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 16/31] hwmon: (pmbus/lt7182s) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 17/31] hwmon: (pmbus/ltc4286) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 18/31] hwmon: (pmbus/lx1308) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 19/31] hwmon: (pmbus/max15301) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 20/31] hwmon: (pmbus/max16601) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 21/31] hwmon: (pmbus/max20730) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 22/31] hwmon: (pmbus/mp5920) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 23/31] hwmon: (pmbus/pim4328) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 24/31] hwmon: (pmbus) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 25/31] hwmon: (pmbus/pxe1610) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 26/31] hwmon: (pmbus/q54sj108a2) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 27/31] hwmon: (pmbus/stpddc60) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 28/31] hwmon: (pmbus/tps53679) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 29/31] hwmon: (pmbus/ucd9000) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 30/31] hwmon: (pmbus/ucd9200) " Dmitry Torokhov
2026-10-25  3:06 ` [PATCH 31/31] hwmon: (pmbus/zl6100) " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024-hwmon-i2c-smbus-read-block-data-v1-1-e81941ad0cd3@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=Delphine_CC_Chiu@Wiwynn.com \
    --cc=abdurrahman@nexthop.ai \
    --cc=andy.chung@amd.com \
    --cc=cosmo.chou@quantatw.com \
    --cc=daniel.nilsson@flex.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ninad@linux.ibm.com \
    --cc=robert.marko@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®