mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] docs: changes.rst: set the pahole minimum back to 1.22
@ 2026-10-22  1:34 Mark Severson
  2026-10-22  1:48 ` [PATCH v2] " Mark Severson
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Severson @ 2026-10-22  1:34 UTC (permalink / raw)
  To: Jonathan Corbet, Federico Vaga
  Cc: Shuah Khan, Randy Dunlap, Ihor Solodrai, Eduard Zingerman,
	workflows, linux-doc, bpf, linux-kernel

Commit fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF
annotation emission") removed the paragraph saying that kfuncs annotated
with KF_IMPLICIT_ARGS need pahole v1.26, because resolve_btfids now
emits the kfunc BTF annotations that pahole used to produce. That
paragraph was the reason the requirements table lists pahole 1.26, and
the table was left unchanged. The text below the table and
lib/Kconfig.debug (DEBUG_INFO_BTF depends on PAHOLE_VERSION >= 122)
both still say 1.22.

Set the table back to 1.22, in the English document and in the Italian
translation, which carries the same table.

Checked by building linux-next 20261021 with pahole v1.25 and
CONFIG_DEBUG_INFO_BTF=y: in the vmlinux BTF,
bpf_task_work_schedule_signal has four arguments and the bpf_kfunc decl
tag, and bpf_task_work_schedule_signal_impl keeps the
struct bpf_prog_aux * argument, as Documentation/bpf/kfuncs.rst
describes for KF_IMPLICIT_ARGS.

Fixes: fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF annotation emission")
Assisted-by: Claude
Signed-off-by: Mark Severson <gr3yf0x87@skyn3tlab.com>
---
checkpatch reports the Assisted-by tag as non-standard; it follows the
Attribution section of Documentation/process/coding-assistants.rst as
published on docs.kernel.org. Not run: make htmldocs; the change keeps
the table's column widths.

 Documentation/process/changes.rst                    | 2 +-
 Documentation/translations/it_IT/process/changes.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst
index 28f2ca633..13093c5c2 100644
--- a/Documentation/process/changes.rst
+++ b/Documentation/process/changes.rst
@@ -53,7 +53,7 @@ mcelog                 0.6              mcelog --version
 mkimage (optional)     2017.01          mkimage --version
 nfs-utils              1.0.5            showmount --version
 openssl & libcrypto    1.0.0            openssl version
-pahole                 1.26             pahole --version
+pahole                 1.22             pahole --version
 pcmciautils            004              pccardctl -V
 pigz (optional)        2.4              pigz --version
 PPP                    2.4.0            pppd --version
diff --git a/Documentation/translations/it_IT/process/changes.rst b/Documentation/translations/it_IT/process/changes.rst
index 0be1292a8..5adeee24c 100644
--- a/Documentation/translations/it_IT/process/changes.rst
+++ b/Documentation/translations/it_IT/process/changes.rst
@@ -57,7 +57,7 @@ mcelog                 0.6              mcelog --version
 mkimage (opzionale)    2017.01          mkimage --version
 nfs-utils              1.0.5            showmount --version
 openssl & libcrypto    1.0.0            openssl version
-pahole                 1.26             pahole --version
+pahole                 1.22             pahole --version
 pcmciautils            004              pccardctl -V
 PPP                    2.4.0            pppd --version
 procps                 3.2.0            ps --version
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] docs: changes.rst: set the pahole minimum back to 1.22
  2026-10-22  1:34 [PATCH] docs: changes.rst: set the pahole minimum back to 1.22 Mark Severson
@ 2026-10-22  1:48 ` Mark Severson
  2026-10-24 10:09   ` Nguyen Duc Thinh
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Severson @ 2026-10-22  1:48 UTC (permalink / raw)
  To: Jonathan Corbet, Federico Vaga
  Cc: Shuah Khan, Randy Dunlap, Ihor Solodrai, Eduard Zingerman,
	workflows, linux-doc, bpf, linux-kernel

Commit fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF
annotation emission") removed the paragraph saying that kfuncs annotated
with KF_IMPLICIT_ARGS need pahole v1.26, because resolve_btfids now
emits the kfunc BTF annotations that pahole used to produce. That
paragraph was the reason the requirements table lists pahole 1.26, and
the table was left unchanged. The text below the table and
lib/Kconfig.debug (DEBUG_INFO_BTF depends on PAHOLE_VERSION >= 122)
both still say 1.22.

Set the table back to 1.22, in the English document and in the Italian
translation, which carries the same table, and remove the Italian
translation's copy of the paragraph that the English document no longer
has.

Checked by building linux-next 20261021 with pahole v1.25 and
CONFIG_DEBUG_INFO_BTF=y: in the vmlinux BTF,
bpf_task_work_schedule_signal has four arguments and the bpf_kfunc decl
tag, and bpf_task_work_schedule_signal_impl keeps the
struct bpf_prog_aux * argument, as Documentation/bpf/kfuncs.rst
describes for KF_IMPLICIT_ARGS.

Fixes: fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF annotation emission")
Assisted-by: Claude
Signed-off-by: Mark Severson <gr3yf0x87@skyn3tlab.com>
---
v2:
- Also remove the Italian translation's copy of the KF_IMPLICIT_ARGS /
  pahole 1.26 paragraph, which fd5425b67355 removed from the English
  document only; v1 left the Italian text contradicting its own table.
  Found by the Sashiko review of v1.
v1: https://lore.kernel.org/all/20261022013432.2638010-1-gr3yf0x87@skyn3tlab.com/

checkpatch reports the Assisted-by tag as non-standard; it follows the
Attribution section of Documentation/process/coding-assistants.rst as
published on docs.kernel.org. Not run: make htmldocs; the change keeps
the table's column widths and removes a whole paragraph.

 Documentation/process/changes.rst                    | 2 +-
 Documentation/translations/it_IT/process/changes.rst | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst
index 28f2ca633..13093c5c2 100644
--- a/Documentation/process/changes.rst
+++ b/Documentation/process/changes.rst
@@ -53,7 +53,7 @@ mcelog                 0.6              mcelog --version
 mkimage (optional)     2017.01          mkimage --version
 nfs-utils              1.0.5            showmount --version
 openssl & libcrypto    1.0.0            openssl version
-pahole                 1.26             pahole --version
+pahole                 1.22             pahole --version
 pcmciautils            004              pccardctl -V
 pigz (optional)        2.4              pigz --version
 PPP                    2.4.0            pppd --version
diff --git a/Documentation/translations/it_IT/process/changes.rst b/Documentation/translations/it_IT/process/changes.rst
index 0be1292a8..b4accd428 100644
--- a/Documentation/translations/it_IT/process/changes.rst
+++ b/Documentation/translations/it_IT/process/changes.rst
@@ -57,7 +57,7 @@ mcelog                 0.6              mcelog --version
 mkimage (opzionale)    2017.01          mkimage --version
 nfs-utils              1.0.5            showmount --version
 openssl & libcrypto    1.0.0            openssl version
-pahole                 1.26             pahole --version
+pahole                 1.22             pahole --version
 pcmciautils            004              pccardctl -V
 PPP                    2.4.0            pppd --version
 procps                 3.2.0            ps --version
@@ -149,12 +149,6 @@ Dalla versione 5.2, quando viene impostato CONFIG_DEBUG_INFO_BTF, il sistema di
 compilazione genera BTF (BPF Type Format) a partire da DWARF per vmlinux. Più
 tardi anche per i moduli. Questo richiede pahole v1.22 o successivo.
 
-Dalla versione 7.0, le kfunc annotate con KF_IMPLICIT_ARGS richiedono pahole
-v1.26 o successivo. Senza questa versione, tali kfunc avranno prototipi BTF
-errati in vmlinux, causando il fallimento del caricamento dei programmi BPF con
-l'errore "func_proto incompatible with vmlinux". Molte kfunc in sched_ext sono
-interessate da questo problema.
-
 A seconda della distribuzione, lo si può trovare nei pacchetti 'dwarves' o
 'pahole'. Oppure lo si può trovare qui: https://fedorapeople.org/~acme/dwarves/.
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] docs: changes.rst: set the pahole minimum back to 1.22
  2026-10-22  1:48 ` [PATCH v2] " Mark Severson
@ 2026-10-24 10:09   ` Nguyen Duc Thinh
  0 siblings, 0 replies; 3+ messages in thread
From: Nguyen Duc Thinh @ 2026-10-24 10:09 UTC (permalink / raw)
  To: Mark Severson
  Cc: Jonathan Corbet, Federico Vaga, Shuah Khan, Randy Dunlap, bpf,
	linux-doc, linux-kernel, Nguyen Duc Thinh

On Wed, Oct 21, 2026 at 21:48:11 -0400, Mark Severson wrote:
> Set the table back to 1.22, in the English document and in the Italian
> translation, which carries the same table, and remove the Italian
> translation's copy of the paragraph that the English document no longer
> has.
> 
> Fixes: fd5425b67355 ("docs, resolve_btfids: Document kfunc BTF annotation emission")
> Signed-off-by: Mark Severson <gr3yf0x87@skyn3tlab.com>

Hi Mark,

Thank you for catching the mismatching requirements (pahole)
alongside the Italian documentation update. The patch makes 
complete sense and resolves the contradiction cleanly.

Reviewed-by: Nguyen Duc Thinh <ducthinh100812@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-24 10:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-22  1:34 [PATCH] docs: changes.rst: set the pahole minimum back to 1.22 Mark Severson
2026-10-22  1:48 ` [PATCH v2] " Mark Severson
2026-10-24 10:09   ` Nguyen Duc Thinh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®