From: Zhu Ling <zhuling2709@phytium.com.cn>
To: tglx@kernel.org
Cc: Zhu Ling <zhuling2709@phytium.com.cn>,
Marc Zyngier <maz@kernel.org>, Radu Rendec <radu@rendec.net>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq/PM: Re-enable chained interrupts after hibernation
Date: Sat, 24 Oct 2026 22:46:21 +0800 [thread overview]
Message-ID: <20261024144623.112667-1-zhuling2709@phytium.com.cn> (raw)
In-Reply-To: <87mrtr1p8i.ffs@fw13>
Hi Thomas,
Thank you for the review. I am withdrawing the previous genirq/PM
proposal. Please do not apply it: forcing chained IRQs through generic
resume treats the symptom rather than restoring controller state.
I have since reproduced the failure on the Phytium E2000Q platform
using upstream base 17bb0e2f6c8043f70a693a5f3797471cbed354c8.
GPIOLIB is disabled and no vendor GPIO driver is involved. An independent
module registers either an ordinary or chained handler on an idle
GICv3 SPI (INTID 189) and injects a real GIC pending event before and
after hibernation. It has no PM callbacks or automatic recovery.
On separate fresh boots, the ordinary IRQ delivers both injections.
The chained IRQ delivers only the first. After real S4, its descriptor
still reports started=1, disabled=0 and sw_masked=0, but the hardware
enable bit is clear and the second event remains pending. An explicit
unmask delivers that queued event without another injection or handler
reinstallation.
A GICv3-side SPI context save/restore revision passes the same test
in both modes: hits=2, injected=2, unexpected=0 and rescued=0. Each
mode was tested for one real S4 cycle on a fresh boot, with CPU0,
disk=shutdown and pm_test=none. No introducing commit is claimed.
The test kernels contain a separate 8-line USB host enablement, but
the unpatched test leaves the IRQ/GIC/PM paths unchanged. The test
module sets the out-of-tree taint bit; both conditions are disclosed
in the new cover letter.
I will send v2 as a separate thread, linking this discussion. It
preserves SPI distributor configuration in GICv3 and does not change
genirq policy. It is not a claim of complete GICv3/ITS S4 support.
Thanks,
Zhu Ling
prev parent reply other threads:[~2026-10-24 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 15:27 Zhu Ling
2026-09-08 20:07 ` Thomas Gleixner
2026-10-24 14:46 ` Zhu Ling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024144623.112667-1-zhuling2709@phytium.com.cn \
--to=zhuling2709@phytium.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=radu@rendec.net \
--cc=rafael@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®