From: Eric Biggers <ebiggers@kernel.org>
To: Harshal Dev <harshal.dev@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
Sumit Garg <sumit.garg@oss.qualcomm.com>,
Selvam Sathappan Periakaruppan
<selvam.periakaruppan@oss.qualcomm.com>,
Basant Kumar <basantk@qti.qualcomm.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/5] Add support for a TEE agnostic Inline Crypto Engine service
Date: Sat, 24 Oct 2026 11:56:02 -0700 [thread overview]
Message-ID: <20261024185602.GF2553@quark> (raw)
In-Reply-To: <20261021-ice-migrate-tee-svc-v1-0-b035be7aab0a@oss.qualcomm.com>
On Wed, Oct 21, 2026 at 09:13:06PM +0530, Harshal Dev wrote:
> This patch series adds a generic ICE service which provides TEE agnostic
> APIs
There is already an ICE driver: drivers/soc/qcom/ice.c. If it needs to
do different things on different platforms, then it should be updated to
do so. Adding a separate middleware module underneath it, with the ICE
driver as its sole user, is unnecessary complexity that will just cause
problems.
In fact the middleware module is called qcom_ice.ko, which is the exact
same name as the ICE driver. That's broken, as it's a name collision.
I think the fact they have the same name hints pretty strongly that the
functionality should just be incorporated into the existing qcom_ice.ko.
AFAICT, this series also breaks boot on platforms without ICE firmware
support, due to indefinite EPROBE_DEFER. Choosing a simpler design
would help avoid issues like that.
- Eric
prev parent reply other threads:[~2026-10-24 18:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 15:43 Harshal Dev
2026-10-21 15:43 ` [PATCH 1/5] firmware: qcom: Add a generic ICE service Harshal Dev
2026-10-22 7:45 ` Konrad Dybcio
2026-10-24 13:46 ` Harshal Dev
2026-10-21 15:43 ` [PATCH 2/5] firmware: qcom_scm: Transition to the " Harshal Dev
2026-10-23 7:21 ` Abel Vesa
2026-10-21 15:43 ` [PATCH 3/5] firmware: qcom: Add an TEE bus based ICE back-end Harshal Dev
2026-10-22 7:47 ` Konrad Dybcio
2026-10-24 13:46 ` Harshal Dev
2026-10-22 7:51 ` Konrad Dybcio
2026-10-24 13:46 ` Harshal Dev
2026-10-22 7:52 ` Konrad Dybcio
2026-10-24 13:47 ` Harshal Dev
2026-10-21 15:43 ` [PATCH 4/5] soc: qcom: ice: Migrate to the generic ICE service Harshal Dev
2026-10-23 7:15 ` Abel Vesa
2026-10-21 15:43 ` [PATCH 5/5] firmware: qcom: scm: Drop exported ICE wrapper functions Harshal Dev
2026-10-23 7:16 ` Abel Vesa
2026-10-24 18:56 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024185602.GF2553@quark \
--to=ebiggers@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=basantk@qti.qualcomm.com \
--cc=harshal.dev@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=selvam.periakaruppan@oss.qualcomm.com \
--cc=sumit.garg@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®