[RFC PATCH 7.2.y] mm/damon/core: error damos_commit_quota_goal() for zero target_value

[RFC PATCH 7.2.y] mm/damon/core: error damos_commit_quota_goal() for zero target_value

[SJ Park]

Patch series "mm/damon: move zero damos quota target_value handling to the
core layer".

Having zero DAMOS quota target value can cause division by zero.  DAMON
API callers are checking the target value parameters to avoid that.  It is
easy to make mistakes in some of the multiple API callers.  Move that to
the core layer.

Patch 1 adds the corner case handling into the core layer DAMON parameters
validation logic.  Patches 2 and 3 remove no more needed DAMON API callers
side handling of the corner case in DAMON_LRU_SORT and DMON_SAMPLIE_MTIER,
respectively.

This patch (of 3):

If a DAMOS scheme has a damos_quota_goal of zero target_value,
damos_quota_goal() could trigger division-by-zero error.  Hence each DAMON
API callers should do the zero target_value validation.  It is easy to
make mistakes.  Actually such bugs in DAMON_LRU_SORT and
DAMON_SAMPLE_MTIER were found and fixed [1].

It is better to handle the corner case only once in the core layer,
instead of multiple places in all DAMON API callers.  One straightforward
option is using an alternative denominator for the corner case in the
damos_quota_goal().  However, the zero target_value is meaningless.  In
this case, the quota goal is always evaluated as achieved or
over-achieved.  The quota will only keep being reduced.

Simply avoid using zero target_value by adding a check in the core layer
DAMOS quota goal parameters validation/commit path,
damos_commit_quota_goal().  Update it to return an error in the case.
Also update its caller to propagate the error.

Notes for stable kernel porting.  The upstream commit doesn't have
Fixes: and therefore not ported to stable kernels.  It turned out it
fixes commit 8b549a4fd3c5 ("mm/damon/sysfs-schemes: commit damos quota
goals user input to DAMOS") which was merged into v6.8.  The user impact
is a race condition that can result in divide-by-zero.  Hence backport.
Reproducing the issue requires sysfs write permission, certain DAMON ABI
usages that are supposed to be uncommon, and a rare race timing, though.
The issue was discovered [2] by Sashiko as a part [3] of its bug report.

[2] https://sashiko.dev/#/bug/linux-7f814c9a-986f-4103-a55a-ef9537dcf62b
[3] https://lore.kernel.org/20261021005234.94107-1-sj@kernel.org

Link: https://lore.kernel.org/20260903010722.94244-1-sj@kernel.org
Link: https://lore.kernel.org/20260903010722.94244-2-sj@kernel.org
Link: https://lore.kernel.org/20260803134034.15217-1-sj@kernel.org [1]
Signed-off-by: SJ Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
(cherry picked from commit 610c4438fb66e06d9e693c0ad3b2c1be54c0d61f)
Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/core.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 40714c69d1b18..0aefaef46d655 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -999,15 +999,18 @@ static void damos_commit_quota_goal_union(
 	}
 }
 
-static void damos_commit_quota_goal(
+static int damos_commit_quota_goal(
 		struct damos_quota_goal *dst, struct damos_quota_goal *src)
 {
+	if (!src->target_value)
+		return  -EINVAL;
 	dst->metric = src->metric;
 	dst->target_value = src->target_value;
 	if (dst->metric == DAMOS_QUOTA_USER_INPUT)
 		dst->current_value = src->current_value;
 	/* keep last_psi_total as is, since it will be updated in next cycle */
 	damos_commit_quota_goal_union(dst, src);
+	return 0;
 }
 
 /**
@@ -1025,14 +1028,17 @@ static void damos_commit_quota_goal(
 int damos_commit_quota_goals(struct damos_quota *dst, struct damos_quota *src)
 {
 	struct damos_quota_goal *dst_goal, *next, *src_goal, *new_goal;
-	int i = 0, j = 0;
+	int i = 0, j = 0, err;
 
 	damos_for_each_quota_goal_safe(dst_goal, next, dst) {
 		src_goal = damos_nth_quota_goal(i++, src);
-		if (src_goal)
-			damos_commit_quota_goal(dst_goal, src_goal);
-		else
+		if (src_goal) {
+			err = damos_commit_quota_goal(dst_goal, src_goal);
+			if (err)
+				return err;
+		} else {
 			damos_destroy_quota_goal(dst_goal);
+		}
 	}
 	damos_for_each_quota_goal_safe(src_goal, next, src) {
 		if (j++ < i)
@@ -1041,7 +1047,11 @@ int damos_commit_quota_goals(struct damos_quota *dst, struct damos_quota *src)
 				src_goal->metric, src_goal->target_value);
 		if (!new_goal)
 			return -ENOMEM;
-		damos_commit_quota_goal(new_goal, src_goal);
+		err = damos_commit_quota_goal(new_goal, src_goal);
+		if (err) {
+			damos_free_quota_goal(new_goal);
+			return err;
+		}
 		damos_add_quota_goal(dst, new_goal);
 	}
 	return 0;

base-commit: cc9de5d4b5ab6459f5774946aa3195ad51236fa8
-- 
2.47.3

Re: [RFC PATCH 7.2.y] mm/damon/core: error damos_commit_quota_goal() for zero target_value

[SJ Park]

On Sun, 25 Oct 2026 10:24:33 -0700 SJ Park <sj@kernel.org> wrote:

> Patch series "mm/damon: move zero damos quota target_value handling to the
> core layer".
> 
> Having zero DAMOS quota target value can cause division by zero.  DAMON
> API callers are checking the target value parameters to avoid that.  It is
> easy to make mistakes in some of the multiple API callers.  Move that to
> the core layer.
> 
> Patch 1 adds the corner case handling into the core layer DAMON parameters
> validation logic.  Patches 2 and 3 remove no more needed DAMON API callers
> side handling of the corner case in DAMON_LRU_SORT and DMON_SAMPLIE_MTIER,
> respectively.
> 
> This patch (of 3):
> 
> If a DAMOS scheme has a damos_quota_goal of zero target_value,
> damos_quota_goal() could trigger division-by-zero error.  Hence each DAMON
> API callers should do the zero target_value validation.  It is easy to
> make mistakes.  Actually such bugs in DAMON_LRU_SORT and
> DAMON_SAMPLE_MTIER were found and fixed [1].
> 
> It is better to handle the corner case only once in the core layer,
> instead of multiple places in all DAMON API callers.  One straightforward
> option is using an alternative denominator for the corner case in the
> damos_quota_goal().  However, the zero target_value is meaningless.  In
> this case, the quota goal is always evaluated as achieved or
> over-achieved.  The quota will only keep being reduced.
> 
> Simply avoid using zero target_value by adding a check in the core layer
> DAMOS quota goal parameters validation/commit path,
> damos_commit_quota_goal().  Update it to return an error in the case.
> Also update its caller to propagate the error.
> 
> Notes for stable kernel porting.  The upstream commit doesn't have
> Fixes: and therefore not ported to stable kernels.  It turned out it
> fixes commit 8b549a4fd3c5 ("mm/damon/sysfs-schemes: commit damos quota
> goals user input to DAMOS") which was merged into v6.8.  The user impact
> is a race condition that can result in divide-by-zero.  Hence backport.
> Reproducing the issue requires sysfs write permission, certain DAMON ABI
> usages that are supposed to be uncommon, and a rare race timing, though.
> The issue was discovered [2] by Sashiko as a part [3] of its bug report.
> 
> [2] https://sashiko.dev/#/bug/linux-7f814c9a-986f-4103-a55a-ef9537dcf62b
> [3] https://lore.kernel.org/20261021005234.94107-1-sj@kernel.org

On v7.2, DAMON sysfs interface calls damon_commit_ctx() for validation purpose,
for parameters commit but initial DAMON start.  Hence this patch fixes the
issue in parmeters commit but initial DAMON start.  I will post a new version
to cover the start case.


Thanks,
SJ

[...]

Re: [RFC PATCH 7.2.y] mm/damon/core: error damos_commit_quota_goal() for zero target_value

[SJ Park]

On Sun, 25 Oct 2026 10:46:46 -0700 SJ Park <sj@kernel.org> wrote:

> On Sun, 25 Oct 2026 10:24:33 -0700 SJ Park <sj@kernel.org> wrote:
> 
> > Patch series "mm/damon: move zero damos quota target_value handling to the
> > core layer".
> > 
> > Having zero DAMOS quota target value can cause division by zero.  DAMON
> > API callers are checking the target value parameters to avoid that.  It is
> > easy to make mistakes in some of the multiple API callers.  Move that to
> > the core layer.
> > 
> > Patch 1 adds the corner case handling into the core layer DAMON parameters
> > validation logic.  Patches 2 and 3 remove no more needed DAMON API callers
> > side handling of the corner case in DAMON_LRU_SORT and DMON_SAMPLIE_MTIER,
> > respectively.
> > 
> > This patch (of 3):
> > 
> > If a DAMOS scheme has a damos_quota_goal of zero target_value,
> > damos_quota_goal() could trigger division-by-zero error.  Hence each DAMON
> > API callers should do the zero target_value validation.  It is easy to
> > make mistakes.  Actually such bugs in DAMON_LRU_SORT and
> > DAMON_SAMPLE_MTIER were found and fixed [1].
> > 
> > It is better to handle the corner case only once in the core layer,
> > instead of multiple places in all DAMON API callers.  One straightforward
> > option is using an alternative denominator for the corner case in the
> > damos_quota_goal().  However, the zero target_value is meaningless.  In
> > this case, the quota goal is always evaluated as achieved or
> > over-achieved.  The quota will only keep being reduced.
> > 
> > Simply avoid using zero target_value by adding a check in the core layer
> > DAMOS quota goal parameters validation/commit path,
> > damos_commit_quota_goal().  Update it to return an error in the case.
> > Also update its caller to propagate the error.
> > 
> > Notes for stable kernel porting.  The upstream commit doesn't have
> > Fixes: and therefore not ported to stable kernels.  It turned out it
> > fixes commit 8b549a4fd3c5 ("mm/damon/sysfs-schemes: commit damos quota
> > goals user input to DAMOS") which was merged into v6.8.  The user impact
> > is a race condition that can result in divide-by-zero.  Hence backport.
> > Reproducing the issue requires sysfs write permission, certain DAMON ABI
> > usages that are supposed to be uncommon, and a rare race timing, though.
> > The issue was discovered [2] by Sashiko as a part [3] of its bug report.
> > 
> > [2] https://sashiko.dev/#/bug/linux-7f814c9a-986f-4103-a55a-ef9537dcf62b
> > [3] https://lore.kernel.org/20261021005234.94107-1-sj@kernel.org
> 
> On v7.2, DAMON sysfs interface calls damon_commit_ctx() for validation purpose,
> for parameters commit but initial DAMON start.  Hence this patch fixes the
> issue in parmeters commit but initial DAMON start.  I will post a new version
> to cover the start case.

For minimum change, the next version will add one more validation in DAMON
start path, like below.

'''
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2226,6 +2226,20 @@ static int damon_sysfs_repeat_call_fn(void *data)
        return 0;
 }

+static bool damon_sysfs_valid_start_ctx(struct damon_ctx *ctx)
+{
+       struct damos *s;
+       struct damos_quota_goal *g;
+
+       damon_for_each_scheme(s, ctx) {
+               damos_for_each_quota_goal(g, &s->quota) {
+                       if (!g->targe_value)
+                               return false;
+               }
+       }
+       return true;
+}
+
 static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
 {
        struct damon_ctx *ctx;
@@ -2251,6 +2265,8 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
                kfree(repeat_call_control);
                return PTR_ERR(ctx);
        }
+       if (!damon_sysfs_valid_start_ctx(ctx))
+               return -EINVAL;
        err = damon_start(&ctx, 1, false);
        if (err) {
                kfree(repeat_call_control);
'''


Thanks,
SJ

[...]