mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: proximity: sx9500: ignore event config writes that don't change state
Date: Sun, 25 Oct 2026 23:37:07 +0000	[thread overview]
Message-ID: <20261025233707.3673d808@jic23-hlaptop> (raw)
In-Reply-To: <20261024175658.130546-1-kapoorarnav43@gmail.com>

On Sat, 24 Oct 2026 23:26:53 +0530
Arnav Kapoor <kapoorarnav43@gmail.com> wrote:

> sx9500_write_event_config() adjusts the channel and close/far user
> counts on every write, even when the event is already in the requested
> state. Writing 0 to a disabled event and then 1 leaves the counts at 0,
> so the channel and its interrupts stay off while the event reads as
> enabled. As channel_users[] is shared with raw reads, those can then
> wait forever for a conversion. Writing 1 twice and then 0 has the
> opposite effect.
> 
> Return early when the state doesn't change, as
> sx_common_write_event_config() does.
> 
> Fixes: 4193c0f1d863 ("iio: driver for Semtech SX9500 proximity solution")
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Applied and marked for stable.

thanks

Jonathan

      reply	other threads:[~2026-10-25 23:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 17:56 Arnav Kapoor
2026-10-25 23:37 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261025233707.3673d808@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®