* [PATCH v1 1/1] arm64: dts: freescale: imx8mm-var-dart-sonata: Fix TPM reset polarity
@ 2026-10-26 12:35 Stefano Radaelli
2026-10-26 13:18 ` Daniel Baluta
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Radaelli @ 2026-10-26 12:35 UTC (permalink / raw)
To: Frank Li, linux-kernel, devicetree, imx, linux-arm-kernel
Cc: pierluigi.p, Stefano Radaelli, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Luan Rafael Carneiro
From: Stefano Radaelli <stefano.r@variscite.com>
The reset input of the ST33KTPM on the Sonata carrier is active low,
but its reset-gpios property is declared GPIO_ACTIVE_HIGH. This
reverses the asserted and deasserted levels of the reset signal.
Use GPIO_ACTIVE_LOW to describe the reset polarity correctly. This
fixes the TPM not responding on I2C and the resulting absence of
/dev/tpm0.
Fixes: 770aba46ea0f ("arm64: dts: imx8mm-var-dart: Add support for Variscite Sonata board")
Co-developed-by: Luan Rafael Carneiro <luan.r@variscite.com>
Signed-off-by: Luan Rafael Carneiro <luan.r@variscite.com>
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
index 57d29a5c3821..2644b7c1239c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
@@ -259,7 +259,7 @@ st33ktpm2xi2c: tpm@2e {
compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
reg = <0x2e>;
label = "tpm";
- reset-gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pca9534 0 GPIO_ACTIVE_LOW>;
};
};
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: freescale: imx8mm-var-dart-sonata: Fix TPM reset polarity
2026-10-26 12:35 [PATCH v1 1/1] arm64: dts: freescale: imx8mm-var-dart-sonata: Fix TPM reset polarity Stefano Radaelli
@ 2026-10-26 13:18 ` Daniel Baluta
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Baluta @ 2026-10-26 13:18 UTC (permalink / raw)
To: Stefano Radaelli, Frank Li, linux-kernel, devicetree, imx,
linux-arm-kernel
Cc: pierluigi.p, Stefano Radaelli, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Luan Rafael Carneiro
On 10/26/26 14:35, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> The reset input of the ST33KTPM on the Sonata carrier is active low,
> but its reset-gpios property is declared GPIO_ACTIVE_HIGH. This
> reverses the asserted and deasserted levels of the reset signal.
>
> Use GPIO_ACTIVE_LOW to describe the reset polarity correctly. This
> fixes the TPM not responding on I2C and the resulting absence of
> /dev/tpm0.
>
> Fixes: 770aba46ea0f ("arm64: dts: imx8mm-var-dart: Add support for Variscite Sonata board")
> Co-developed-by: Luan Rafael Carneiro <luan.r@variscite.com>
> Signed-off-by: Luan Rafael Carneiro <luan.r@variscite.com>
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> index 57d29a5c3821..2644b7c1239c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> @@ -259,7 +259,7 @@ st33ktpm2xi2c: tpm@2e {
> compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
> reg = <0x2e>;
> label = "tpm";
> - reset-gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pca9534 0 GPIO_ACTIVE_LOW>;
> };
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-26 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-26 12:35 [PATCH v1 1/1] arm64: dts: freescale: imx8mm-var-dart-sonata: Fix TPM reset polarity Stefano Radaelli
2026-10-26 13:18 ` Daniel Baluta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®