[PATCH] net: 8390: fix kernel-doc warning for __ei_tx_timeout

[PATCH] net: 8390: fix kernel-doc warning for __ei_tx_timeout

[Ayush Yaduvanshi]

---
 drivers/net/ethernet/8390/lib8390.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/8390/lib8390.c b/drivers/net/ethernet/8390/lib8390.c
index 84aeb8054304..c1b7e3e9ee9c 100644
--- a/drivers/net/ethernet/8390/lib8390.c
+++ b/drivers/net/ethernet/8390/lib8390.c
@@ -246,8 +246,9 @@ static int __ei_close(struct net_device *dev)
 }
 
 /**
- * ei_tx_timeout - handle transmit time out condition
+ * __ei_tx_timeout - handle transmit time out condition
  * @dev: network device which has apparently fallen asleep
+ * @txqueue: transmit queue index
  *
  * Called by kernel when device never acknowledges a transmit has
  * completed (or failed) - i.e. never posted a Tx related interrupt.
-- 
2.53.0

Re: [PATCH] net: 8390: fix kernel-doc warning for __ei_tx_timeout

[Simon Horman]

On Thu, Oct 22, 2026 at 02:10:46PM +0530, Ayush Yaduvanshi wrote:

A description and your Signed-off-by needs to go here.

> ---
>  drivers/net/ethernet/8390/lib8390.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

But, more importantly, this is an orphaned driver, and:

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject