From: Eric Biggers <ebiggers@kernel.org>
To: Antonio Quartulli <antonio@mandelbit.com>
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] lib/crypto: tests: Add KUnit tests and benchmark for ChaCha
Date: Mon, 26 Oct 2026 18:53:13 -0700 [thread overview]
Message-ID: <20261027015313.GD2395@quark> (raw)
In-Reply-To: <20261025234758.3219829-2-antonio@mandelbit.com>
On Mon, Oct 26, 2026 at 12:47:54AM +0100, Antonio Quartulli wrote:
> + for (size_t i = 0; i < 10000000; i += max_len)
> + chacha_crypt(&st, data, data, max_len, 20);
The calls to chacha_crypt() with constant 20 argument should be
chacha20_crypt(). Mainly so that if people copy-and-paste this outside
of test code, they use the right one.
Otherwise this test looks fine. I'll apply it once the merge window
closes.
- Eric
next prev parent reply other threads:[~2026-10-27 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 23:47 [PATCH 0/2] lib/crypto: x86/chacha: Add 16-block AVX-512 implementation Antonio Quartulli
2026-10-25 23:47 ` [PATCH 1/2] lib/crypto: tests: Add KUnit tests and benchmark for ChaCha Antonio Quartulli
2026-10-27 1:53 ` Eric Biggers [this message]
2026-10-27 8:51 ` Antonio Quartulli
2026-10-25 23:47 ` [PATCH 2/2] lib/crypto: x86/chacha: Add 16-block AVX-512 (zmm) implementation Antonio Quartulli
2026-10-26 0:35 ` [PATCH 0/2] lib/crypto: x86/chacha: Add 16-block AVX-512 implementation Eric Biggers
2026-10-26 0:46 ` Antonio Quartulli
2026-10-26 18:36 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027015313.GD2395@quark \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=antonio@mandelbit.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®