mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jianfeng Liu <liujianfeng1994@gmail.com>
To: heiko@sntech.de
Cc: HystericalDragons@proton.me, amadeus@jmu.edu.cn,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	hrushirajg23@gmail.com, krzk+dt@kernel.org, krzk@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	liujianfeng1994@gmail.com, macromorgan@hotmail.com,
	michael.opdenacker@rootcommit.com, naoki@radxa.com,
	robh@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7s
Date: Tue, 27 Oct 2026 10:28:01 +0800	[thread overview]
Message-ID: <20261027022801.377819-1-liujianfeng1994@gmail.com> (raw)
In-Reply-To: <5520293.6fTUFtlzNn@phil>

Hi Heiko,

On 2026-10-26 11:43 UTC, Heiko Stuebner wrote:
>> I confirmed this with ArmSoM. They purchased the original CoolPi 4B
>> hardware design from CoolPi and confirmed that no hardware design
>> modifications were made for the Sige7s.
>> 
>> So the Sige7s uses the same hardware design as the CoolPi 4B, rather
>> than being independently designed.
>
>if it's the completely same board, just with a different print on
>the board, why does it need an empty devicetree. When it's completely
>unchanged, what's speaking against just re-using the original one?

The existing CoolPi 4B DTB does work on the Sige7s, and I agree that there
is no hardware difference requiring a separate device tree.

My main reason for adding a separate DTS is to preserve the Sige7s board
identity for long-term upstream support.

The CoolPi 4B appears to be discontinued and is no longer readily available
through the purchase channels listed on its official website
(https://www.cool-pi.com/buy/). In contrast, ArmSoM is actively selling the
Sige7s and has committed to producing it until at least January 2034.

I'm also planning to add mainline U-Boot support for the Sige7s and
integrate it with Stubble-based UEFI booting.

While U-Boot could update the model and compatible properties before
booting Linux, Stubble may replace the firmware-provided DTB with one
bundled with the kernel. Having a Sige7s-specific DTB would preserve the
correct board identity throughout this process without requiring additional
distribution-specific modifications.

This would also avoid confusing users who purchase a Sige7s but find their
system identified as a CoolPi 4B.

The shared dtsi ensures that we do not duplicate the hardware description,
with the two board DTS files differing only in model and compatible.

Would this be a reasonable justification for keeping a separate board DTS?

Best regards,
Jianfeng

  reply	other threads:[~2026-10-27  2:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 12:52 [PATCH 0/3] arm64: dts: rockchip: Add ArmSoM Sige7s support Jianfeng Liu
2026-10-22 12:52 ` [PATCH 1/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7s Jianfeng Liu
2026-10-26  7:08   ` Krzysztof Kozlowski
2026-10-26  7:59     ` Jianfeng Liu
2026-10-26 11:43       ` Heiko Stuebner
2026-10-27  2:28         ` Jianfeng Liu [this message]
2026-10-27  7:48           ` Krzysztof Kozlowski
2026-10-27  8:56             ` Jianfeng Liu
2026-10-27  9:56               ` Krzysztof Kozlowski
2026-10-22 12:52 ` [PATCH 2/3] arm64: dts: rockchip: Extract common CoolPi 4B board description Jianfeng Liu
2026-10-22 12:52 ` [PATCH 3/3] arm64: dts: rockchip: Add ArmSoM Sige7s board Jianfeng Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027022801.377819-1-liujianfeng1994@gmail.com \
    --to=liujianfeng1994@gmail.com \
    --cc=HystericalDragons@proton.me \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hrushirajg23@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macromorgan@hotmail.com \
    --cc=michael.opdenacker@rootcommit.com \
    --cc=naoki@radxa.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®