From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jianfeng Liu <liujianfeng1994@gmail.com>
Cc: HystericalDragons@proton.me, amadeus@jmu.edu.cn,
conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de,
hrushirajg23@gmail.com, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
macromorgan@hotmail.com, michael.opdenacker@rootcommit.com,
naoki@radxa.com, robh@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7s
Date: Tue, 27 Oct 2026 10:56:44 +0100 [thread overview]
Message-ID: <7b993a3e-d2b4-417b-90a3-a41d1f454cda@kernel.org> (raw)
In-Reply-To: <20261027085634.380872-1-liujianfeng1994@gmail.com>
On 27/10/2026 09:56, Jianfeng Liu wrote:
> Hi Krzysztof,
>
> On 2026-10-27 7:48 UTC, Krzysztof wrote:
>> Maybe just install the DTB under new name if they are identical?
>
> Thanks for the suggestion.
>
> Installing the existing CoolPi 4B DTB under a different filename would
> solve the DTB naming issue, but the model and compatible properties would
> still identify the device as a CoolPi 4B.
>
> This is my main concern. Users running Linux on a Sige7s would still see
> "RK3588S CoolPi 4 Model B" in /proc/device-tree/model, even though they
> purchased an ArmSoM Sige7s.
>
> I agree that we should avoid duplicating the hardware description, since
> the boards are identical. However, I think preserving the correct board
> identity in the device tree is useful, especially for a product that is
> still being manufactured and will receive ongoing upstream support.
>
> Would it be acceptable to share the entire hardware description while
> keeping separate model and compatible properties for the two boards?
Yes, just be sure to capture this in commit msg and maybe Sige7s DTS
comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-27 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 12:52 [PATCH 0/3] arm64: dts: rockchip: Add ArmSoM Sige7s support Jianfeng Liu
2026-10-22 12:52 ` [PATCH 1/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7s Jianfeng Liu
2026-10-26 7:08 ` Krzysztof Kozlowski
2026-10-26 7:59 ` Jianfeng Liu
2026-10-26 11:43 ` Heiko Stuebner
2026-10-27 2:28 ` Jianfeng Liu
2026-10-27 7:48 ` Krzysztof Kozlowski
2026-10-27 8:56 ` Jianfeng Liu
2026-10-27 9:56 ` Krzysztof Kozlowski [this message]
2026-10-27 16:03 ` Quentin Schulz
2026-10-22 12:52 ` [PATCH 2/3] arm64: dts: rockchip: Extract common CoolPi 4B board description Jianfeng Liu
2026-10-22 12:52 ` [PATCH 3/3] arm64: dts: rockchip: Add ArmSoM Sige7s board Jianfeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b993a3e-d2b4-417b-90a3-a41d1f454cda@kernel.org \
--to=krzk@kernel.org \
--cc=HystericalDragons@proton.me \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hrushirajg23@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=michael.opdenacker@rootcommit.com \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®