From: Kevin Loughlin <kevinloughlin@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@kernel.org>,
"Jason Wang" <jasowangio@gmail.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Kiryl Shutsemau" <kas@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Ashish Kalra" <ashish.kalra@amd.com>,
"Michael Roth" <michael.roth@amd.com>,
"Rick Edgecombe" <rick.p.edgecombe@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Brendan Jackman" <brendan.jackman@linux.dev>,
"Johannes Weiner" <hannes@cmpxchg.org>, "Zi Yan" <ziy@nvidia.com>,
"Alexander Duyck" <alexanderduyck@fb.com>
Cc: virtualization@lists.linux.dev, linux-coco@lists.linux.dev,
linux-efi@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Sidharth Telang <sidtelang@google.com>,
Punit Salian <psalian@google.com>,
Peter Gonda <pgonda@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Jacky Li <jackyli@google.com>,
Steve Rutherford <srutherford@google.com>,
David Skidmore <davidskidmore@google.com>,
Kevin Loughlin <kevinloughlin@google.com>
Subject: [PATCH 13/13] virtio_balloon: enforce ACCESS_PLATFORM in CoCo
Date: Tue, 27 Oct 2026 02:56:16 +0000 [thread overview]
Message-ID: <20261027025616.1632690-14-kevinloughlin@google.com> (raw)
In-Reply-To: <20261027025616.1632690-1-kevinloughlin@google.com>
In confidential computing environments (CC_ATTR_GUEST_MEM_ENCRYPT),
virtio devices require VIRTIO_F_ACCESS_PLATFORM to negotiate restricted
memory access and DMA bounce buffering for virtqueue rings and
metadata buffers.
Currently, virtballoon_validate() unconditionally clears
VIRTIO_F_ACCESS_PLATFORM, causing virtio_features_ok() to reject probing
the balloon device (-ENODEV) when restricted memory access is active.
Preserve VIRTIO_F_ACCESS_PLATFORM in virtballoon_validate() when
CC_ATTR_GUEST_MEM_ENCRYPT is active, clear VIRTIO_BALLOON_F_FREE_PAGE_HINT
in CoCo since free_page_vq maps MAX_PAGE_ORDER blocks through standard DMA
ops without unaccepting them. Reject probing (-ENODEV) on CoCo
platforms where balloon page state transitions are unsupported.
Signed-off-by: Kevin Loughlin <kevinloughlin@google.com>
---
drivers/virtio/virtio_balloon.c | 36 ++++++++++++++++++++++++++++++++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 217431e75751..ae011636c07f 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -1311,6 +1311,14 @@ static int virtballoon_restore(struct virtio_device *vdev)
}
#endif
+static bool virtballoon_cc_supported(void)
+{
+ if (cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
+ return has_unaccepted_memory();
+
+ return cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT);
+}
+
static int virtballoon_validate(struct virtio_device *vdev)
{
/*
@@ -1318,7 +1326,17 @@ static int virtballoon_validate(struct virtio_device *vdev)
* initialized. If we cannot do that then we should disable
* page reporting as it could potentially change the contents
* of our free pages.
+ *
+ * In encrypted guests without unaccepted memory (e.g. SEV-ES), the
+ * hypervisor cannot populate discarded pages with guest-encrypted
+ * poison/zero values and the guest does not re-initialize reported
+ * pages on return. Clear VIRTIO_BALLOON_F_PAGE_POISON so reporting
+ * is disabled when init_on_free or page_poison is active.
*/
+ if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) &&
+ !has_unaccepted_memory())
+ __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON);
+
if (!want_init_on_free() && !page_poisoning_enabled_static())
__virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON);
else if (!virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON))
@@ -1329,7 +1347,23 @@ static int virtballoon_validate(struct virtio_device *vdev)
* virtqueue_add during page reporting.
*/
__virtio_clear_bit(vdev, VIRTIO_RING_F_INDIRECT_DESC);
- __virtio_clear_bit(vdev, VIRTIO_F_ACCESS_PLATFORM);
+
+ /*
+ * The balloon bypasses the DMA API for page addresses and cannot
+ * support a physical or virtual IOMMU on non-CoCo guests. In CoCo
+ * guests, VIRTIO_F_ACCESS_PLATFORM is required for bounce-buffering
+ * virtqueue rings and metadata. Disable free page hinting in CoCo
+ * guests as free_page_vq maps MAX_PAGE_ORDER blocks through standard
+ * DMA ops, and reject probing on CoCo platforms where balloon page
+ * state transitions are not supported.
+ */
+ if (!cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) {
+ __virtio_clear_bit(vdev, VIRTIO_F_ACCESS_PLATFORM);
+ } else {
+ if (!virtballoon_cc_supported())
+ return -ENODEV;
+ __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT);
+ }
return 0;
}
--
2.56.0.307.g5fe7bd680c-goog
next prev parent reply other threads:[~2026-10-27 2:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 2:56 [PATCH 00/13] virtio_balloon, efi/unaccepted: support memory ballooning and free page reporting in CoCo guests Kevin Loughlin
2026-10-27 2:56 ` [PATCH 01/13] virtio_ring: support per-virtqueue DMA mapping ops Kevin Loughlin
2026-10-27 9:42 ` Michael S. Tsirkin
2026-10-28 15:38 ` Kevin Loughlin
2026-10-27 2:56 ` [PATCH 02/13] virtio_balloon: add reporting_vq DMA map ops Kevin Loughlin
2026-10-27 2:56 ` [PATCH 03/13] x86/coco/sev: add snp_unaccept_memory() Kevin Loughlin
2026-10-27 2:56 ` [PATCH 04/13] x86/coco/sev: fix zeropad #VC on unaccepted memory Kevin Loughlin
2026-10-27 2:56 ` [PATCH 05/13] efi/libstub: start unaccepted bitmap at address 0 Kevin Loughlin
2026-10-27 2:56 ` [PATCH 06/13] efi/unaccepted: add mark_memory_unaccepted() Kevin Loughlin
2026-10-27 2:56 ` [PATCH 07/13] mm/page_alloc: allow lower-order unaccepted_pages Kevin Loughlin
2026-10-27 2:56 ` [PATCH 08/13] mm/page_alloc: route unaccepted isolated pages Kevin Loughlin
2026-10-27 2:56 ` [PATCH 09/13] mm/page_reporting: account for unaccepted memory Kevin Loughlin
2026-10-27 2:56 ` [PATCH 10/13] virtio_balloon: add higher-order page inflation Kevin Loughlin
2026-10-27 9:35 ` Michael S. Tsirkin
2026-10-28 15:39 ` Kevin Loughlin
2026-10-27 9:36 ` Michael S. Tsirkin
2026-10-28 8:58 ` David Hildenbrand (Arm)
2026-10-28 15:40 ` Kevin Loughlin
2026-10-27 2:56 ` [PATCH 11/13] virtio_balloon: unaccept free reporting ranges Kevin Loughlin
2026-10-27 2:56 ` [PATCH 12/13] virtio_balloon: unaccept inflated balloon pages Kevin Loughlin
2026-10-27 2:56 ` Kevin Loughlin [this message]
2026-10-27 10:29 ` [PATCH 00/13] virtio_balloon, efi/unaccepted: support memory ballooning and free page reporting in CoCo guests Michael S. Tsirkin
2026-10-27 20:39 ` Michael S. Tsirkin
2026-10-28 17:51 ` Kevin Loughlin
2026-10-28 9:00 ` David Hildenbrand (Arm)
2026-10-28 18:12 ` Kevin Loughlin
2026-10-28 18:54 ` Michael S. Tsirkin
2026-10-28 19:49 ` Kevin Loughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027025616.1632690-14-kevinloughlin@google.com \
--to=kevinloughlin@google.com \
--cc=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexanderduyck@fb.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=brendan.jackman@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=davidskidmore@google.com \
--cc=eperezma@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=jackyli@google.com \
--cc=jasowangio@gmail.com \
--cc=kas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=pgonda@google.com \
--cc=psalian@google.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=sidtelang@google.com \
--cc=srutherford@google.com \
--cc=surenb@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=vbabka@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®