* [PATCH] platform/x86: dell-wmi-ddv: switch sensor mutex to devm_mutex_init()
@ 2026-10-27 4:48 chitranshmandhaniya
0 siblings, 0 replies; only message in thread
From: chitranshmandhaniya @ 2026-10-27 4:48 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: platform-driver-x86, linux-kernel, Chitransh_Mandhaniya, W_Armin
From: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>
Replace mutex_init() with devm_mutex_init() for the sensor caching
mutex so the mutex lifecycle is managed by devres. This allows
removing the manual mutex_destroy() call from the
dell_wmi_ddv_hwmon_cache_destroy() cleanup callback.
The translation_cache_lock in the same driver already uses
devm_mutex_init(); this brings the sensor lock in line.
Signed-off-by: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>
---
drivers/platform/x86/dell/dell-wmi-ddv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c
index f8903ced461b..c7f3d07abbc7 100644
--- a/drivers/platform/x86/dell/dell-wmi-ddv.c
+++ b/drivers/platform/x86/dell/dell-wmi-ddv.c
@@ -548,7 +548,6 @@ static void dell_wmi_ddv_hwmon_cache_destroy(void *data)
struct dell_wmi_ddv_sensors *sensors = data;
sensors->active = false;
- mutex_destroy(&sensors->lock);
kfree(sensors->buffer);
}
@@ -566,7 +565,9 @@ static struct hwmon_channel_info *dell_wmi_ddv_channel_init(struct wmi_device *w
if (ret < 0)
return ERR_PTR(ret);
- mutex_init(&sensors->lock);
+ ret = devm_mutex_init(&wdev->dev, &sensors->lock);
+ if (ret < 0)
+ return ERR_PTR(ret);
sensors->active = true;
ret = devm_add_action_or_reset(&wdev->dev, dell_wmi_ddv_hwmon_cache_destroy, sensors);
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-27 4:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-27 4:48 [PATCH] platform/x86: dell-wmi-ddv: switch sensor mutex to devm_mutex_init() chitranshmandhaniya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®