From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-doc@vger.kernel.org, workflows@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH] docs: submitting-patches: Require base tree information
Date: Tue, 27 Oct 2026 06:55:07 -0500 [thread overview]
Message-ID: <20261027115507.GD3598537-robh@kernel.org> (raw)
In-Reply-To: <43ef0af4-0594-41f1-9ad3-499bfb3352a9@kernel.org>
On Tue, Oct 27, 2026 at 08:28:06AM +0100, Krzysztof Kozlowski wrote:
> On 26/10/2026 21:12, Rob Herring wrote:
> > On Wed, Oct 21, 2026 at 6:55 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>>
> >>>> All these tools should just work on top of linux-next. Requiring people
> >>>> to add base like "next-20261021" or "tip-of-obvious-maintainer-tree" is
> >>>> pointless. I understand that base is helping, but helping and requiring
> >>>> an obvious information just do not go together.
> >>>>
> >>>> So again: base has ZERO meaning to the maintainer process. It has
> >>>> meaning to tools, so fix the tools to work on known and obvious trees.
> >>>
> >>> So what is your proposed algorithm to apply an arbitrary patch when
> >>
> >> Already provided that, so to recap:
> >>
> >>> there's no base-commit? Including any historical patch (from
> >>> months/years ago), patches with dependencies, etc.
> >>
> >> Dependency is something else, but for every other patch:
> >> 1. For testing/CI: you apply on top of next
> >> 2. Every other case the maintainer knows where to apply it, because it
> >> is his HEAD of next-branch.
> >>
> >> I am repeating myself, but I really had no single problem of lack of
> >> knowledge where to apply a patch as a maintainer or reviewer of some
> >> subsystem, thus maybe I do not understand the actual problem you are
> >> experiencing.
> >
> > Look at our DT PW. There are numerous patches that don't apply and
> > then we silently don't test them at all. Here's one example[1] (3
> > actually as the whole series doesn't apply). The more base-commit
> > tags, the better. If b4 can't apply it, then I do try just linux-next,
> > but is that today's, yesterday's or 2 weeks ago? That still doesn't
> > work sometimes.
>
> I have doubts that DT CI would know these mentioned bases, unless
> everyone develops on master, which is obviously not possible. It could
> work if CI has all possible next tags fetched, but then I argue that
> without base commit such CI could apply to closest linux-next tag by date.
I fetch the last 5 next trees or so. b4 will also try to guess the base,
but that doesn't seem to work all that well. If this is "easy", then b4
should just work without issue, right?
Rob
next prev parent reply other threads:[~2026-10-27 11:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 21:22 Eric Biggers
2026-10-20 22:07 ` Konstantin Ryabitsev
2026-10-21 6:07 ` Randy Dunlap
2026-10-21 6:35 ` Krzysztof Kozlowski
2026-10-21 6:44 ` Eric Biggers
2026-10-21 6:47 ` Krzysztof Kozlowski
2026-10-21 3:17 ` Weijie Yuan
2026-10-21 6:26 ` Krzysztof Kozlowski
2026-10-21 6:39 ` Eric Biggers
2026-10-21 6:41 ` Krzysztof Kozlowski
2026-10-21 6:49 ` Eric Biggers
2026-10-21 11:55 ` Krzysztof Kozlowski
2026-10-21 15:04 ` Konstantin Ryabitsev
2026-10-21 15:49 ` Krzysztof Kozlowski
2026-10-21 16:37 ` Konstantin Ryabitsev
2026-10-21 16:32 ` Laurent Pinchart
2026-10-22 6:57 ` Krzysztof Kozlowski
2026-10-22 7:25 ` Eric Biggers
2026-10-22 8:29 ` Krzysztof Kozlowski
2026-10-22 10:03 ` Laurent Pinchart
2026-10-26 10:40 ` Laurent Pinchart
2026-10-26 10:48 ` Krzysztof Kozlowski
2026-10-26 11:27 ` Mark Brown
2026-10-27 12:29 ` Laurent Pinchart
2026-10-27 14:31 ` Krzysztof Kozlowski
2026-10-26 14:02 ` Geert Uytterhoeven
2026-10-26 14:53 ` Laurent Pinchart
2026-10-26 15:37 ` Geert Uytterhoeven
2026-10-26 20:19 ` Laurent Pinchart
2026-10-26 20:51 ` Mark Brown
2026-10-27 12:33 ` Laurent Pinchart
2026-10-26 20:12 ` Rob Herring
2026-10-27 7:28 ` Krzysztof Kozlowski
2026-10-27 11:55 ` Rob Herring [this message]
2026-10-27 8:10 ` Geert Uytterhoeven
2026-10-27 12:23 ` Laurent Pinchart
2026-10-21 14:19 ` Jonathan Corbet
2026-10-21 15:59 ` Krzysztof Kozlowski
2026-10-22 10:04 ` Geert Uytterhoeven
2026-10-22 10:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027115507.GD3598537-robh@kernel.org \
--to=robh@kernel.org \
--cc=corbet@lwn.net \
--cc=ebiggers@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®