From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Guangshuo Li <lgs201920130244@gmail.com>,
John Stultz <john.stultz@linaro.org>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mfd: hi655x-pmic: fix IRQ action memory leak on removal
Date: Tue, 27 Oct 2026 16:23:24 +0000 [thread overview]
Message-ID: <20261027162324.GI2195460@google.com> (raw)
In-Reply-To: <c04f2ba8-fc83-4118-a26a-76ea8cbee518@kernel.org>
On Tue, 27 Oct 2026, Krzysztof Kozlowski wrote:
> On 27/10/2026 03:46, Guangshuo Li wrote:
> > hi655x_pmic_remove() currently removes the regmap IRQ chip before
> > removing the MFD child devices. regmap_del_irq_chip() disposes the
> > child IRQ mappings and removes their IRQ descriptors.
> >
> > The hi65xx-powerkey child registers interrupt handlers using
> > devm_request_any_context_irq(). During child device removal, the
> > device-managed cleanup calls free_irq(), but the corresponding IRQ
> > descriptors are no longer available. As a result, the allocated
> > struct irqaction objects referenced by irq_desc->action are not
> > freed, causing a memory leak.
> >
> > Remove the MFD child devices first, allowing their device-managed
> > IRQ handlers to be released while the IRQ mappings are still valid.
> > Then remove the regmap IRQ chip and its IRQ domain.
> >
> > This issue was found by our static analysis tool under development.
>
> More of postings by bot ignoring any feedback.
What did I miss?
This person seems to be answering to my feedback:
https://lore.kernel.org/r/CANUHTR9B84LoCjOtS5N5qGO0KXSXUbZkrKZ3_GFTwXmVoPQ0SA@mail.gmail.com
--
Lee Jones
next prev parent reply other threads:[~2026-10-27 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 2:46 Guangshuo Li
2026-10-27 15:27 ` Krzysztof Kozlowski
2026-10-27 16:22 ` Guangshuo Li
2026-10-27 16:23 ` Lee Jones [this message]
2026-10-27 16:42 ` Krzysztof Kozlowski
2026-10-27 16:24 ` Lee Jones
2026-10-27 16:34 ` Guangshuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027162324.GI2195460@google.com \
--to=lee@kernel.org \
--cc=john.stultz@linaro.org \
--cc=krzk@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®