Re: [PATCH] mfd: hi655x-pmic: fix IRQ action memory leak on removal

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/10/2026 17:23, Lee Jones wrote:
> On Tue, 27 Oct 2026, Krzysztof Kozlowski wrote:
> 
>> On 27/10/2026 03:46, Guangshuo Li wrote:
>>> hi655x_pmic_remove() currently removes the regmap IRQ chip before
>>> removing the MFD child devices. regmap_del_irq_chip() disposes the
>>> child IRQ mappings and removes their IRQ descriptors.
>>>
>>> The hi65xx-powerkey child registers interrupt handlers using
>>> devm_request_any_context_irq(). During child device removal, the
>>> device-managed cleanup calls free_irq(), but the corresponding IRQ
>>> descriptors are no longer available. As a result, the allocated
>>> struct irqaction objects referenced by irq_desc->action are not
>>> freed, causing a memory leak.
>>>
>>> Remove the MFD child devices first, allowing their device-managed
>>> IRQ handlers to be released while the IRQ mappings are still valid.
>>> Then remove the regmap IRQ chip and its IRQ domain.
>>>
>>> This issue was found by our static analysis tool under development.
>>
>> More of postings by bot ignoring any feedback.
> 
> What did I miss?
> 
> This person seems to be answering to my feedback:
> 
> https://lore.kernel.org/r/CANUHTR9B84LoCjOtS5N5qGO0KXSXUbZkrKZ3_GFTwXmVoPQ0SA@mail.gmail.com

To mine not really. This all is again spread patch-per-patch, exactly
like I asked to fix last time, more than once.

Best regards,
Krzysztof