mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wang Guangke <gkwang@linx-info.com>
Cc: rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix typo in comment
Date: Tue, 27 Oct 2026 21:33:25 -0700	[thread overview]
Message-ID: <20261027213325.d28fb3a913c68a982b5a6591@linux-foundation.org> (raw)
In-Reply-To: <20261028040625.204-1-gkwang@linx-info.com>

On Wed, 28 Oct 2026 12:06:25 +0800 Wang Guangke <gkwang@linx-info.com> wrote:

> Correct "pages frames" to "page frames".
> Only touches comments,no code changes.
> 
> Signed-off-by: Wang Guangke <gkwang@linx-info.com>
> ---
>  mm/mm_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 1533aebafb68..9d233b6af7ab 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1179,7 +1179,7 @@ static unsigned long __init __absent_pages_in_range(int nid,
>   * @start_pfn: The start PFN to start searching for holes
>   * @end_pfn: The end PFN to stop searching for holes
>   *
> - * Return: the number of pages frames in memory holes within a range.
> + * Return: the number of page frames in memory holes within a range.
>   */
>  unsigned long __init absent_pages_in_range(unsigned long start_pfn,
>  							unsigned long end_pfn)

Sorry, but a one-line comment typo fix just isn't worth a kernel commit.

A more substantial file-wide sweep might receive more consideration.  I
asked LLM to do that and came up with the below.

But even a fix for these wouldn't be smiled upon at this time.  We're
all swamped and stressed out over a maelstrom of bug reports and fixes.


I found these comment typos in mm/mm_init.c, against mm-unstable
4685a28187f4:

  55: "then end" -> "the end"
  377: "before borrow the nodemask" -> "before borrowing the nodemask"
  1090: "smaller that" -> "smaller than"
  1092-1093: "in the lack of an altmap" ->
             "in the absence of an altmap"
  1217: "sized independent of architecture" ->
        "sized independently of architecture"
  1223: "in order of monotonic increases memory addresses" ->
        "in order of monotonically increasing memory addresses"
  1279: "pages frames" -> "page frames"
  1524: "been setup" -> "been set up"
  1631: "0 ," -> "0,"
  1651: "`struct *page`,so" -> "`struct page` objects, so"
  1921-1925: missing spaces after the leading '*'
  1957: "pfn's" -> "PFNs"

Two comments also name the wrong thing:

  1481: "multiple of pageblock_order" should be
        "multiple of pageblock_nr_pages", matching the rounding below.
  1834: "arch_max_dma32_pfn has no pages" should be
        "ZONE_DMA32 has no pages".


  reply	other threads:[~2026-10-28  4:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  4:06 Wang Guangke
2026-10-28  4:33 ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-08-01 15:47 Joel Savitz
2019-08-01 15:55 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027213325.d28fb3a913c68a982b5a6591@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=gkwang@linx-info.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®