mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mm: fix typo in comment
@ 2026-10-28  4:06 Wang Guangke
  2026-10-28  4:33 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Wang Guangke @ 2026-10-28  4:06 UTC (permalink / raw)
  To: rppt, akpm; +Cc: linux-mm, linux-kernel, Wang Guangke

Correct "pages frames" to "page frames".
Only touches comments,no code changes.

Signed-off-by: Wang Guangke <gkwang@linx-info.com>
---
 mm/mm_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index 1533aebafb68..9d233b6af7ab 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1179,7 +1179,7 @@ static unsigned long __init __absent_pages_in_range(int nid,
  * @start_pfn: The start PFN to start searching for holes
  * @end_pfn: The end PFN to stop searching for holes
  *
- * Return: the number of pages frames in memory holes within a range.
+ * Return: the number of page frames in memory holes within a range.
  */
 unsigned long __init absent_pages_in_range(unsigned long start_pfn,
 							unsigned long end_pfn)
-- 
2.47.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: fix typo in comment
  2026-10-28  4:06 [PATCH] mm: fix typo in comment Wang Guangke
@ 2026-10-28  4:33 ` Andrew Morton
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2026-10-28  4:33 UTC (permalink / raw)
  To: Wang Guangke; +Cc: rppt, linux-mm, linux-kernel

On Wed, 28 Oct 2026 12:06:25 +0800 Wang Guangke <gkwang@linx-info.com> wrote:

> Correct "pages frames" to "page frames".
> Only touches comments,no code changes.
> 
> Signed-off-by: Wang Guangke <gkwang@linx-info.com>
> ---
>  mm/mm_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 1533aebafb68..9d233b6af7ab 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1179,7 +1179,7 @@ static unsigned long __init __absent_pages_in_range(int nid,
>   * @start_pfn: The start PFN to start searching for holes
>   * @end_pfn: The end PFN to stop searching for holes
>   *
> - * Return: the number of pages frames in memory holes within a range.
> + * Return: the number of page frames in memory holes within a range.
>   */
>  unsigned long __init absent_pages_in_range(unsigned long start_pfn,
>  							unsigned long end_pfn)

Sorry, but a one-line comment typo fix just isn't worth a kernel commit.

A more substantial file-wide sweep might receive more consideration.  I
asked LLM to do that and came up with the below.

But even a fix for these wouldn't be smiled upon at this time.  We're
all swamped and stressed out over a maelstrom of bug reports and fixes.


I found these comment typos in mm/mm_init.c, against mm-unstable
4685a28187f4:

  55: "then end" -> "the end"
  377: "before borrow the nodemask" -> "before borrowing the nodemask"
  1090: "smaller that" -> "smaller than"
  1092-1093: "in the lack of an altmap" ->
             "in the absence of an altmap"
  1217: "sized independent of architecture" ->
        "sized independently of architecture"
  1223: "in order of monotonic increases memory addresses" ->
        "in order of monotonically increasing memory addresses"
  1279: "pages frames" -> "page frames"
  1524: "been setup" -> "been set up"
  1631: "0 ," -> "0,"
  1651: "`struct *page`,so" -> "`struct page` objects, so"
  1921-1925: missing spaces after the leading '*'
  1957: "pfn's" -> "PFNs"

Two comments also name the wrong thing:

  1481: "multiple of pageblock_order" should be
        "multiple of pageblock_nr_pages", matching the rounding below.
  1834: "arch_max_dma32_pfn has no pages" should be
        "ZONE_DMA32 has no pages".


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: fix typo in comment
  2019-08-01 15:47 Joel Savitz
@ 2019-08-01 15:55 ` Matthew Wilcox
  0 siblings, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2019-08-01 15:55 UTC (permalink / raw)
  To: Joel Savitz
  Cc: linux-kernel, Andrew Morton, Mel Gorman, Vlastimil Babka,
	Randy Dunlap, Yu Zhao, trivial

On Thu, Aug 01, 2019 at 11:47:34AM -0400, Joel Savitz wrote:
> Fix spelling of successful (currently spelled successfull in kernel
> source)

If you're going to bother fixing the spelling, may as well fix the grammar
at the same time.

>  	/*
> -	 * The full zone was compacted scanned but wasn't successfull to compact
> +	 * The full zone was compacted scanned but wasn't successful to compact
>  	 * suitable pages.
>  	 */

... actually, I don't know what is meant here.  Could it mean:

	/*
	 * The full zone was scanned for compaction, but didn't produce
	 * suitable pages.
	 */

>  	/*
> -	 * direct compaction has scanned part of the zone but wasn't successfull
> +	 * direct compaction has scanned part of the zone but wasn't successful
>  	 * to compact suitable pages.

	 * Zone compaction had to stop before scanning the full zone, and
	 * no suitable pages were produced.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] mm: fix typo in comment
@ 2019-08-01 15:47 Joel Savitz
  2019-08-01 15:55 ` Matthew Wilcox
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Savitz @ 2019-08-01 15:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Joel Savitz, Andrew Morton, Mel Gorman, Vlastimil Babka,
	Matthew Wilcox, Randy Dunlap, Yu Zhao, trivial

Fix spelling of successful (currently spelled successfull in kernel
source)

Signed-off-by: Joel Savitz <jsavitz@redhat.com>
---
 include/linux/compaction.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/compaction.h b/include/linux/compaction.h
index 9569e7c786d3..4122df65eb44 100644
--- a/include/linux/compaction.h
+++ b/include/linux/compaction.h
@@ -38,12 +38,12 @@ enum compact_result {
 	COMPACT_CONTINUE,
 
 	/*
-	 * The full zone was compacted scanned but wasn't successfull to compact
+	 * The full zone was compacted scanned but wasn't successful to compact
 	 * suitable pages.
 	 */
 	COMPACT_COMPLETE,
 	/*
-	 * direct compaction has scanned part of the zone but wasn't successfull
+	 * direct compaction has scanned part of the zone but wasn't successful
 	 * to compact suitable pages.
 	 */
 	COMPACT_PARTIAL_SKIPPED,
-- 
2.18.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-28  4:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-28  4:06 [PATCH] mm: fix typo in comment Wang Guangke
2026-10-28  4:33 ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2019-08-01 15:47 Joel Savitz
2019-08-01 15:55 ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®