[PATCH 0/2] dt-bindings: media: i2c: add GT9764 VCM and S5KJNS sensor

[PATCH 0/2] dt-bindings: media: i2c: add GT9764 VCM and S5KJNS sensor

[Qianhui Xu]

Two small camera-side DT bindings for an SM8750 based tablet (Lenovo
Legion Tab, TB322FC): the Giantec GT9764 VCM driver IC and the Samsung
S5KJNS image sensor.  The two devices sit on the same I2C bus and are used
together on that board, but the bindings themselves are independent, so
they are sent as one small series to keep the DT review together.

Each patch adds a schema only, plus its MAINTAINERS entry.  The
corresponding "media: i2c" driver patches (gt9764 VCM and s5kjns sensor)
will be posted as separate series; the bindings in this series are the ones
those drivers and the device DTS will reference.

Both schemas pass dt-doc-validate, and both patches are clean under
checkpatch.pl --strict.


Qianhui Xu (2):
  dt-bindings: media: i2c: add Giantec GT9764 camera lens actuator
  dt-bindings: media: i2c: add Samsung S5KJNS image sensor

 .../bindings/media/i2c/giantec,gt9764.yaml    |  71 +++++++++++
 .../bindings/media/i2c/samsung,s5kjns.yaml    | 120 ++++++++++++++++++
 MAINTAINERS                                   |  12 ++
 3 files changed, 203 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/giantec,gt9764.yaml
 create mode 100644 Documentation/devicetree/bindings/media/i2c/samsung,s5kjns.yaml

-- 
2.53.0

[PATCH 1/2] dt-bindings: media: i2c: add Giantec GT9764 camera lens actuator

[Qianhui Xu]

Add DT binding for the Giantec GT9764 I2C lens actuator. It provides a
10-bit position DAC and module-dependent advanced actuator control (AAC)
parameters.

Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
 MAINTAINERS                                        |    6 ++
 .../bindings/media/i2c/giantec,gt9764.yaml         |   71 ++++++++++++++++++++
 2 files changed, 77 insertions(+)
---
 .../bindings/media/i2c/giantec,gt9764.yaml    | 71 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++
 2 files changed, 77 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/giantec,gt9764.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/giantec,gt9764.yaml b/Documentation/devicetree/bindings/media/i2c/giantec,gt9764.yaml
new file mode 100644
index 000000000..febffa359
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/giantec,gt9764.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/giantec,gt9764.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Giantec GT9764 camera lens actuator
+
+maintainers:
+  - Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+
+description:
+  I2C-controlled lens actuator with a 10-bit position DAC and advanced actuator
+  control (AAC). AAC parameters depend on the lens module's mechanical response.
+
+properties:
+  compatible:
+    const: giantec,gt9764
+
+  reg:
+    maxItems: 1
+
+  vddio-supply:
+    description: Digital I/O supply.
+
+  vdd-supply:
+    description: Actuator supply, independently switched for the lens.
+
+  giantec,aac-mode:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    maximum: 255
+    description: Module-specified AAC mode configuration (register 0x06).
+
+  giantec,aac-timing:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    maximum: 255
+    description: Module-specified AAC timing configuration (register 0x07).
+
+  settling-time-us:
+    minimum: 1
+    description:
+      Minimum interval after programming a lens position before issuing
+      another position command, based on the lens module's damping response.
+
+required:
+  - compatible
+  - reg
+  - vddio-supply
+  - vdd-supply
+  - giantec,aac-mode
+  - giantec,aac-timing
+  - settling-time-us
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        lens@c {
+            compatible = "giantec,gt9764";
+            reg = <0x0c>;
+            vddio-supply = <&camera_io>;
+            vdd-supply = <&camera_af>;
+            giantec,aac-mode = <0x40>;
+            giantec,aac-timing = <0x7c>;
+            settling-time-us = <7000>;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index f53047aa8..6872ad5fe 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10866,6 +10866,12 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
 F:	drivers/media/i2c/gc08a3.c
 
+GIANTEC GT9764 LENS VOICE COIL DRIVER
+M:	Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+L:	linux-media@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/i2c/giantec,gt9764.yaml
+
 GALAXYCORE GC2145 SENSOR DRIVER
 M:	Alain Volmat <alain.volmat@foss.st.com>
 L:	linux-media@vger.kernel.org
-- 
2.53.0

Re: [PATCH 1/2] dt-bindings: media: i2c: add Giantec GT9764 camera lens actuator

[Krzysztof Kozlowski]

On Tue, Oct 27, 2026 at 01:10:47PM +0800, Qianhui Xu wrote:
> Add DT binding for the Giantec GT9764 I2C lens actuator. It provides a
> 10-bit position DAC and module-dependent advanced actuator control (AAC)
> parameters.
> 
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
>  MAINTAINERS                                        |    6 ++
>  .../bindings/media/i2c/giantec,gt9764.yaml         |   71 ++++++++++++++++++++

I don't understand why we need this. Where is any user of that?

Best regards,
Krzysztof

[PATCH 2/2] dt-bindings: media: i2c: add Samsung S5KJNS image sensor

[Qianhui Xu]

Add DT binding for the Samsung S5KJNS MIPI CSI-2 image sensor.

Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
 MAINTAINERS                                        |    6 +
 .../bindings/media/i2c/samsung,s5kjns.yaml         |  120 ++++++++++++++++++++
 2 files changed, 126 insertions(+)
---
 .../bindings/media/i2c/samsung,s5kjns.yaml    | 120 ++++++++++++++++++
 MAINTAINERS                                   |   6 +
 2 files changed, 126 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/samsung,s5kjns.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5kjns.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjns.yaml
new file mode 100644
index 000000000..6908c07c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjns.yaml
@@ -0,0 +1,120 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/samsung,s5kjns.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung S5KJNS image sensor
+
+maintainers:
+  - Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+
+description:
+  The s5kjns is a raw image sensor with an MIPI CSI-2 image data
+  interface and CCI (I2C compatible) control bus. The output format
+  is raw Bayer.
+
+allOf:
+  - $ref: /schemas/media/video-interface-devices.yaml#
+
+properties:
+  compatible:
+    const: samsung,s5kjns
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+    description: 19.2 MHz input clock.
+
+  dovdd-supply: true
+
+  avdd-supply: true
+
+  dvdd-supply: true
+
+  lens-focus: true
+
+  flash-leds: true
+
+  power-domains:
+    maxItems: 1
+
+  reset-gpios:
+    description: Reference to the GPIO connected to the RESETB pin.
+    maxItems: 1
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    additionalProperties: false
+    description:
+      Output port node, single endpoint describing the CSI-2 transmitter.
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            items:
+              - const: 1
+              - const: 2
+              - const: 3
+              - const: 4
+
+          link-frequencies:
+            items:
+              - const: 672000000
+
+        required:
+          - data-lanes
+          - link-frequencies
+
+    required:
+      - endpoint
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - dovdd-supply
+  - avdd-supply
+  - dvdd-supply
+  - reset-gpios
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@56 {
+            compatible = "samsung,s5kjns";
+            reg = <0x56>;
+
+            clocks = <&s5kjns_clk>;
+
+            reset-gpios = <&pio 19 GPIO_ACTIVE_LOW>;
+
+            avdd-supply = <&s5kjns_avdd>;
+            dovdd-supply = <&s5kjns_dovdd>;
+            dvdd-supply = <&s5kjns_dvdd>;
+
+            port {
+                sensor_out: endpoint {
+                    data-lanes = <1 2 3 4>;
+                    link-frequencies = /bits/ 64 <672000000>;
+                    remote-endpoint = <&seninf_csi_port_0_in>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 6872ad5fe..620fdef73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -24416,6 +24416,12 @@ T:	git git://linuxtv.org/media_tree.git
 F:	Documentation/devicetree/bindings/media/i2c/samsung,s5kjn1.yaml
 F:	drivers/media/i2c/s5kjn1.c
 
+SAMSUNG S5KJNS CAMERA DRIVER
+M:	Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+L:	linux-media@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/i2c/samsung,s5kjns.yaml
+
 SAMSUNG S5P Security SubSystem (SSS) DRIVER
 M:	Krzysztof Kozlowski <krzk@kernel.org>
 M:	Vladimir Zapolskiy <vz@mleia.com>
-- 
2.53.0

Re: [PATCH 2/2] dt-bindings: media: i2c: add Samsung S5KJNS image sensor

[Krzysztof Kozlowski]

On Tue, Oct 27, 2026 at 01:10:48PM +0800, Qianhui Xu wrote:
> Add DT binding for the Samsung S5KJNS MIPI CSI-2 image sensor.
> 
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>

You still send LLM-generated slop.

Please start using Git. If you cannot instruct your agent to use
standard tools like Git, then your work shall be deprioritized (see
maintainer's summit 2026 for some background).

Best regards,
Krzysztof