From: SJ Park <sj@kernel.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>
Cc: SJ Park <sj@kernel.org>,
corbet@lwn.net, damon@lists.linux.dev, jm5905938@gmail.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rdunlap@infradead.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2 1/2] Docs/admin-guide/mm/damon/reclaim: improve grammar and style
Date: Tue, 27 Oct 2026 17:06:36 -0700 [thread overview]
Message-ID: <20261028000637.157110-1-sj@kernel.org> (raw)
In-Reply-To: <20261027190503.2526945-2-manuelebnerli@mailbox.org>
On Tue, 27 Oct 2026 20:05:04 +0100 Manuel Ebner <manuelebnerli@mailbox.org> wrote:
> Fix upper case. Fix tenses. Replace 'set as' with 'set to'. Add space after
> sentence to make it double space.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> CC: Aveline Noir <jm5905938@gmail.com>
> ---
> @ -113,8 +113,8
> Choose as you wish.
>
> @ 20
> should be:
> -Free Pages Reporting [3]_ based
> +Free pages reporting [3]_ based
> or
> +'*Free Pages Reporting'* [3]_ based
> * the right kind of quoting/ kernel-doc highlighting.
> Choose as you wish.
> ---
> .../admin-guide/mm/damon/reclaim.rst | 36 +++++++++----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/damon/reclaim.rst b/Documentation/admin-guide/mm/damon/reclaim.rst
> index e4e2ffa52e..0bab2299ea 100644
> --- a/Documentation/admin-guide/mm/damon/reclaim.rst
> +++ b/Documentation/admin-guide/mm/damon/reclaim.rst
[...]
> @@ -30,12 +30,12 @@ guests could mitigate this problem.
> How It Works?
> =============
>
> -DAMON_RECLAIM finds memory regions that didn't accessed for specific time
> +DAMON_RECLAIM finds memory regions that weren't accessed for specific time
> duration and page out. To avoid it consuming too much CPU for the paging out
> operation, a speed limit can be configured. Under the speed limit, it pages
> -out memory regions that didn't accessed longer time first. System
> +out memory regions that weren't accessed longer time first. System
> administrators can also configure under what situation this scheme should
> -automatically activated and deactivated with three memory pressure watermarks.
> +automatically be activated and deactivated with three memory pressure watermarks.
Let's keep 80 columns limit. Same for below.
[...]
> @@ -113,10 +113,10 @@ quota_sz
>
> Limit of size of memory for the reclamation in bytes.
>
> -DAMON_RECLAIM charges amount of memory which it tried to reclaim within a time
> -window (quota_reset_interval_ms) and makes no more than this limit is tried.
> -This can be used for limiting consumption of CPU and IO. If this value is
> -zero, the limit is disabled.
> +DAMON_RECLAIM records the amount of memory which it tried to reclaim within a time
Didn't we agree to keep use "charge" ?
Other than the above two things, looks good to me.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-10-28 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 18:59 [PATCH v2 0/2] Docs/admin-guide/mm/damon/reclaim: improve language Manuel Ebner
2026-10-27 19:05 ` [PATCH v2 1/2] Docs/admin-guide/mm/damon/reclaim: improve grammar and style Manuel Ebner
2026-10-28 0:06 ` SJ Park [this message]
2026-10-27 19:06 ` [PATCH v2 2/2] Docs/admin-guide/mm/damon/reclaim: rewrite complex parts Manuel Ebner
2026-10-28 0:09 ` SJ Park
2026-10-27 21:23 ` Manuel Ebner
2026-10-28 0:19 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028000637.157110-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=jm5905938@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manuelebnerli@mailbox.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®