From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Oded Gabbay <ogabbay@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
sashiko-bot@kernel.org
Subject: [PATCH v4 00/31] accel: ethosu: Another batch of fixes
Date: Thu, 29 Oct 2026 08:35:47 -0500 [thread overview]
Message-ID: <20261029-ethosu-fixes-v4-0-4aa25e22578e@kernel.org> (raw)
This is another series of fixes to the ethosu driver. It's mostly probe
error paths and cmd stream validation fixes. It's a mixture of
AI reported issues, different solutions to other posted issues and
fixes[1] and my own fixes. The last 2 patches are additional operation
support.
The series adds rejecting OFM tranpose in cmd stream, but then a later
patch adds support for it. I did this so the rejection can be
backported, but maybe supporting OFM transpose is small enough that it
should just be backported too?
Sashiko keeps raising issues about IRQs, but the h/w only generates an
interrupt if a job was submitted. The scenarios sashiko talks about are
not possible.
Rob
[1] https://lore.kernel.org/all/20260717061145.1478139-1-zhaoguohan@kylinos.cn
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Changes in v4:
- More patches added for existing issues raised by Sashiko in v3 and
local runs
- Combined the 2 patches for unknown cmds and unhandled parameters into
one patch
- Link to v3: https://patch.msgid.link/20260908-ethosu-fixes-v3-0-490fe215286f@kernel.org
Changes in v3:
- Address Sashiko comments
- Another runtime-PM fix for driver remove()
- Add a fix for NHCWB16 bounds calculation
- Link to v2: https://patch.msgid.link/20260904-ethosu-fixes-v2-0-3767738756a4@kernel.org
Changes in v2:
- Dropped first 5 patches which are already applied
- Patches 11-17 and 19 are new patches with more cmd stream validation
- Add fix to diable clocks on PM setup failure
- Rework the runtime-PM to suspend after initialization and before
drm_dev_register(). This simplifies the error clean-up in probe.
- Handle quiescing jobs before scheduler teardown
- Rework the cmd stream register initialization tracking to use a bitmap
of registers instead of relying on initial state values.
- Handle U85 DMA 2D/3D modes correctly
- Link to v1: https://patch.msgid.link/20260827-ethosu-fixes-v1-0-346f9ea8791c@kernel.org
---
Rob Herring (Arm) (31):
accel: ethosu: Suspend after initialization
accel: ethosu: Ensure suspended on removal
accel: ethosu: Fix probe error cleanup
accel: ethosu: Disable clocks on PM setup failure
accel: ethosu: Quiesce jobs before scheduler teardown
accel: ethosu: Fix runtime PM get error handling
accel: ethosu: Limit perfmon counters to UAPI
accel: ethosu: Serialize job completion
accel: ethosu: Guard operations after unplug
accel: ethosu: Keep scheduler after unplug
accel: ethosu: Clear SRAM before submission
accel: ethosu: Validate timeout command offset
accel: ethosu: Prevent command stream export
accel: ethosu: Move DMA mode to src/dst struct
accel: ethosu: Track command stream register setup
accel: ethosu: Factor buffer bounds checks
accel: ethosu: Fix NHCWB16 bounds calculation
accel: ethosu: Validate secondary streams
accel: ethosu: Reject unsupported commands and params
accel: ethosu: Validate all feature map tiles
accel: ethosu: Account for feature map element size
accel: ethosu: Validate convolution parameter
accel: ethosu: Account for kernel dilation in IFM size
accel: ethosu: Validate accumulator input
accel: ethosu: Restrict dynamic IFM2 weights
accel: ethosu: Split U65 and U85 DMA length validation
accel: ethosu: Validate OFM transpose
accel: ethosu: Validate resize operations
accel: ethosu: Ensure cmd stream is multiple of 4 bytes
accel: ethosu: Require active weight streams setup
accel: ethosu: Support U85 IFM upscaling
drivers/accel/ethosu/ethosu_device.h | 40 ++
drivers/accel/ethosu/ethosu_drv.c | 56 +-
drivers/accel/ethosu/ethosu_drv.h | 6 +
drivers/accel/ethosu/ethosu_gem.c | 951 +++++++++++++++++++++++++++++++---
drivers/accel/ethosu/ethosu_job.c | 236 +++++++--
drivers/accel/ethosu/ethosu_job.h | 5 +-
drivers/accel/ethosu/ethosu_perfmon.c | 123 +++--
7 files changed, 1236 insertions(+), 181 deletions(-)
---
base-commit: 9a96e169c9267af918d28fb291df948d83112807
change-id: 20260827-ethosu-fixes-ee58386e9000
Best regards,
--
Rob Herring (Arm) <robh@kernel.org>
next reply other threads:[~2026-10-29 13:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 13:35 Rob Herring (Arm) [this message]
2026-10-29 13:35 ` [PATCH v4 01/31] accel: ethosu: Suspend after initialization Rob Herring (Arm)
2026-10-29 15:42 ` Frank Li
2026-10-29 13:35 ` [PATCH v4 02/31] accel: ethosu: Ensure suspended on removal Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 03/31] accel: ethosu: Fix probe error cleanup Rob Herring (Arm)
2026-10-29 15:52 ` Frank Li
2026-10-29 16:00 ` Rob Herring
2026-10-29 16:20 ` Frank Li
2026-10-29 13:35 ` [PATCH v4 04/31] accel: ethosu: Disable clocks on PM setup failure Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 05/31] accel: ethosu: Quiesce jobs before scheduler teardown Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 06/31] accel: ethosu: Fix runtime PM get error handling Rob Herring (Arm)
2026-10-29 16:03 ` Frank Li
2026-10-29 16:38 ` Frank Li
2026-10-29 13:35 ` [PATCH v4 07/31] accel: ethosu: Limit perfmon counters to UAPI Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 08/31] accel: ethosu: Serialize job completion Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 09/31] accel: ethosu: Guard operations after unplug Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 10/31] accel: ethosu: Keep scheduler " Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 11/31] accel: ethosu: Clear SRAM before submission Rob Herring (Arm)
2026-10-29 13:35 ` [PATCH v4 12/31] accel: ethosu: Validate timeout command offset Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 13/31] accel: ethosu: Prevent command stream export Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 14/31] accel: ethosu: Move DMA mode to src/dst struct Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 15/31] accel: ethosu: Track command stream register setup Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 16/31] accel: ethosu: Factor buffer bounds checks Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 17/31] accel: ethosu: Fix NHCWB16 bounds calculation Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 18/31] accel: ethosu: Validate secondary streams Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 19/31] accel: ethosu: Reject unsupported commands and params Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 20/31] accel: ethosu: Validate all feature map tiles Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 21/31] accel: ethosu: Account for feature map element size Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 22/31] accel: ethosu: Validate convolution parameter Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 23/31] accel: ethosu: Account for kernel dilation in IFM size Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 24/31] accel: ethosu: Validate accumulator input Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 25/31] accel: ethosu: Restrict dynamic IFM2 weights Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 26/31] accel: ethosu: Split U65 and U85 DMA length validation Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 27/31] accel: ethosu: Validate OFM transpose Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 28/31] accel: ethosu: Validate resize operations Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 29/31] accel: ethosu: Ensure cmd stream is multiple of 4 bytes Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 30/31] accel: ethosu: Require active weight streams setup Rob Herring (Arm)
2026-10-29 13:36 ` [PATCH v4 31/31] accel: ethosu: Support U85 IFM upscaling Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029-ethosu-fixes-v4-0-4aa25e22578e@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®