* [PATCH] drm/msm/adreno: Soften no-firmware message
@ 2026-10-29 0:16 Rob Clark
2026-10-29 1:51 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Rob Clark @ 2026-10-29 0:16 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-msm, freedreno, Rob Clark, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, open list
It isn't _necessarily_ an error, the driver will try again each time the
device file is opened. But if you don't have GPU fw in the initrd, you
end up seeing this error message at least once. Which seems to confuse
users. So try to re-word it slightly.
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 5832dc25d6bf..6db6cb7eb287 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -558,7 +558,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname)
adreno_gpu->fwloc = FW_LOCATION_NEW;
goto out;
} else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {
- DRM_DEV_ERROR(drm->dev, "failed to load %s: %d\n",
+ DRM_DEV_INFO(drm->dev, "failed to load %s: %d (will try again later)\n",
newname, ret);
fw = ERR_PTR(ret);
goto out;
@@ -578,7 +578,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname)
adreno_gpu->fwloc = FW_LOCATION_LEGACY;
goto out;
} else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {
- DRM_DEV_ERROR(drm->dev, "failed to load %s: %d\n",
+ DRM_DEV_INFO(drm->dev, "failed to load %s: %d (will try again later)\n",
fwname, ret);
fw = ERR_PTR(ret);
goto out;
@@ -599,14 +599,14 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname)
adreno_gpu->fwloc = FW_LOCATION_HELPER;
goto out;
} else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {
- DRM_DEV_ERROR(drm->dev, "failed to load %s: %d\n",
+ DRM_DEV_INFO(drm->dev, "failed to load %s: %d (will try again later)\n",
newname, ret);
fw = ERR_PTR(ret);
goto out;
}
}
- DRM_DEV_ERROR(drm->dev, "failed to load %s\n", fwname);
+ DRM_DEV_INFO(drm->dev, "failed to load %s (will try again later)\n", fwname);
fw = ERR_PTR(-ENOENT);
out:
kfree(newname);
--
2.56.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/msm/adreno: Soften no-firmware message
2026-10-29 0:16 [PATCH] drm/msm/adreno: Soften no-firmware message Rob Clark
@ 2026-10-29 1:51 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2026-10-29 1:51 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, freedreno, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, open list
On Wed, Oct 28, 2026 at 05:16:00PM -0700, Rob Clark wrote:
> It isn't _necessarily_ an error, the driver will try again each time the
> device file is opened. But if you don't have GPU fw in the initrd, you
> end up seeing this error message at least once. Which seems to confuse
> users. So try to re-word it slightly.
>
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-29 1:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 0:16 [PATCH] drm/msm/adreno: Soften no-firmware message Rob Clark
2026-10-29 1:51 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®