[PATCH 0/2] entry: Drive-by fixes for the entry code

[PATCH 0/2] entry: Drive-by fixes for the entry code

[Florian Bezdeka]

Hi all,

I had to debug and read a lot of the low level entry code today. While
doing so two minor things jumped at me. I hope those "fixes" are
valuable. Feel free to ignore.

Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
Florian Bezdeka (2):
      entry: Fix return type of syscall_trace_enter()
      entry: Complete syscall_enter_from_user_mode_work() to bool migration

 include/linux/entry-common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
base-commit: a39c950806213f6861d00f90729acaaa21f2d95a
change-id: 20261030-wip-flo-fixup-entry-code-6abd6e2a81fc

Best regards,
-- 
Florian Bezdeka <florian.bezdeka@siemens.com>

[PATCH 1/2] entry: Fix return type of syscall_trace_enter()

[Florian Bezdeka]

All return values of syscall_trace_enter() were migrated to bool in
commit 71ff30013f19 ("entry: Make return type of syscall_trace_enter() bool"),
but the function declaration has not been updated.

Fixing that up now.

Fixes: 71ff30013f19 ("entry: Make return type of syscall_trace_enter() bool")
Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
 include/linux/entry-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/entry-common.h b/include/linux/entry-common.h
index fa2854fed1f289b9d2dffbc4bf70ab9927f36917..a8b2430eadc5f8500195454e24f86cd9e0d06614 100644
--- a/include/linux/entry-common.h
+++ b/include/linux/entry-common.h
@@ -62,7 +62,7 @@ void trace_syscall_enter(struct pt_regs *regs);
 void trace_syscall_exit(struct pt_regs *regs, long ret);
 void syscall_enter_audit(struct pt_regs *regs);
 
-static __always_inline long syscall_trace_enter(struct pt_regs *regs, unsigned long work,
+static __always_inline bool syscall_trace_enter(struct pt_regs *regs, unsigned long work,
 						long syscall)
 {
 	/*

-- 
2.56.0

[PATCH 2/2] entry: Complete syscall_enter_from_user_mode_work() to bool migration

[Florian Bezdeka]

The return type of syscall_enter_from_user_mode_work() was changed to
bool in the commit referenced below, see Fixes: tag.

While doing so, one caller in
syscall_enter_from_user_mode_randomize_stack() was overlooked and
stayed at the previous type: long. Updating this caller accordingly
now.

Fixes: 05c033db7e9a ("entry, treewide: Make syscall_enter_from_user_mode[_work]() indicate syscall execution")
Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
 include/linux/entry-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/entry-common.h b/include/linux/entry-common.h
index a8b2430eadc5f8500195454e24f86cd9e0d06614..15278416f8860724d90bb2f8862017fdf678771e 100644
--- a/include/linux/entry-common.h
+++ b/include/linux/entry-common.h
@@ -202,7 +202,7 @@ do {									\
 									\
 	instrumentation_begin();					\
 	local_irq_enable();						\
-	long _ret = syscall_enter_from_user_mode_work(regs, syscall);	\
+	bool _ret = syscall_enter_from_user_mode_work(regs, syscall);	\
 	instrumentation_end();						\
 									\
 	_ret;								\

-- 
2.56.0