* [RFC PATCH] selftests/damon/sysfs_memcg_path_leak: define ksft_skip
@ 2026-10-30 4:46 SJ Park
0 siblings, 0 replies; only message in thread
From: SJ Park @ 2026-10-30 4:46 UTC (permalink / raw)
Cc: SJ Park, stable, Andrew Morton, Shuah Khan, damon, linux-kernel,
linux-kselftest, linux-mm
sysfs_memcg_path_leak test uses $ksft_skip without defining it. As a
result, the test is marked as passed while it was skipped, like below.
$ ./sysfs_memcg_path_leak.sh
Run as root
$ echo $?
0
Users who run the test could therefore wrongly believe the test was run
and passed while it was skipped.
Define the value at the beginning of the test. After this patch, the
exit code reflects the skip.
$ ./sysfs_memcg_path_leak.sh
Run as root
$ echo $?
4
Fixes: dfa3cf0bc018 ("selftets/damon: add a test for memcg_path leak")
Cc: <stable@vger.kernel.org> # 6.17.x
Closes: https://sashiko.dev/#/bug/linux-a0456336-0608-4fec-ac22-0ee61d1d6a91
Signed-off-by: SJ Park <sj@kernel.org>
---
tools/testing/selftests/damon/sysfs_memcg_path_leak.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh b/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh
index 34c37129c49fe..d407dddb879ec 100755
--- a/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh
+++ b/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh
@@ -1,6 +1,9 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
if [ $EUID -ne 0 ]
then
echo "Run as root"
base-commit: 20b1ca206f8a664a16ad3006262c63b5d37b1ecc
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-30 4:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-30 4:46 [RFC PATCH] selftests/damon/sysfs_memcg_path_leak: define ksft_skip SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®