* [PATCH v4 0/2] spmi: core: Add generic DebugFS interface for bus inspection
@ 2026-10-30 4:59 vamshi gajjela
2026-10-30 4:59 ` [PATCH v4 1/2] spmi: core: Rename spmi.c to spmi-core.c vamshi gajjela
2026-10-30 4:59 ` [PATCH v4 2/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
0 siblings, 2 replies; 5+ messages in thread
From: vamshi gajjela @ 2026-10-30 4:59 UTC (permalink / raw)
To: sboyd, abelvesa; +Cc: abel.vesa, jwylder, linux-kernel, vamshigajjela
From: Vamshi Gajjela <vamshigajjela@google.com>
This series introduces a generic, controller-agnostic DebugFS interface in the
SPMI core under /sys/kernel/debug/spmi/spmi-<nr>/ to inspect registered
controllers and perform SPMI transactions during board bringup and debugging.
Patch 1/2 renames drivers/spmi/spmi.c to spmi-core.c so that the core driver
and optional debugfs support can be linked into the spmi.ko composite module.
Patch 2/2 adds the DebugFS interface (name and xfer) along with its ABI
documentation under Documentation/ABI/testing/debugfs-spmi.
Changes in v4:
- Rebased onto spmi-next (8f70c729e68c).
- Split the rename of drivers/spmi/spmi.c -> spmi-core.c into a separate
preparatory patch.
- Removed the 'detect' debugfs entry as MIPI SPMI does not mandate a universal
register address across all slave devices, and probing 0x0000 fails on
controllers with channel/register access policies such as Qualcomm PMIC Arb.
- Dropped redundant Runtime PM calls from spmi-debugfs.c since SPMI controller
drivers manage their own runtime PM inside their transaction callbacks.
- Gated raw write ('w') and command ('c') operations behind
#undef SPMI_ALLOW_WRITE_DEBUGFS (matching regmap-debugfs.c) so that the
interface is read-only by default unless explicitly enabled in source.
- Updated Date and KernelVersion in Documentation/ABI/testing/debugfs-spmi.
- Link to v3: https://lore.kernel.org/r/20261019202107.888262-1-vamshigajjela@google.com
Changes in v3:
- Move internal SPMI core command helpers (spmi_cmd(), spmi_read_cmd(),
spmi_write_cmd()) and DebugFS prototypes out of the public
include/linux/spmi.h header into a local drivers/spmi/spmi-internal.h
header.
Changes in v2:
- Rename spmi.c to spmi-core.c and link spmi-debugfs.o into the composite
spmi.o module so CONFIG_SPMI=m builds cleanly with CONFIG_DEBUG_FS=y.
- Route DebugFS bus operations through spmi_read_cmd(), spmi_write_cmd(),
and spmi_cmd() instead of calling controller callbacks directly,
preserving SPMI tracepoints and core validation.
- Allocate a per-open-file struct spmi_xfer_ctx in open() instead of
sharing a controller-wide buffer, avoiding races across concurrent file
descriptors, and store struct dentry *debugfs directly on
struct spmi_controller.
- Reset *ppos = 0 on register read commands so repeated transactions on
the same open file descriptor work without manual seeking.
- Restrict SPMI_CMD_ZERO_WRITE at address 0x00 to 7-bit payloads
(data[0] <= 0x7f) per the MIPI SPMI specification, falling back to
SPMI_CMD_WRITE for 8-bit values.
- Parse register addresses with kstrtou16() so values above 0xffff are
rejected instead of silently truncated.
- Update Documentation/ABI/testing/debugfs-spmi to document per-fd xfer
buffers and 7-bit Zero Write opcode selection.
Vamshi Gajjela (2):
spmi: core: Rename spmi.c to spmi-core.c
spmi: core: Add generic DebugFS interface for bus inspection
Documentation/ABI/testing/debugfs-spmi | 68 +++++
MAINTAINERS | 1 +
drivers/spmi/Makefile | 2 +
drivers/spmi/{spmi.c => spmi-core.c} | 20 +-
drivers/spmi/spmi-debugfs.c | 341 +++++++++++++++++++++++++
drivers/spmi/spmi-internal.h | 28 ++
include/linux/spmi.h | 6 +
7 files changed, 460 insertions(+), 6 deletions(-)
create mode 100644 Documentation/ABI/testing/debugfs-spmi
rename drivers/spmi/{spmi.c => spmi-core.c} (97%)
create mode 100644 drivers/spmi/spmi-debugfs.c
create mode 100644 drivers/spmi/spmi-internal.h
--
2.56.0.317.g454f8302e1-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 1/2] spmi: core: Rename spmi.c to spmi-core.c
2026-10-30 4:59 [PATCH v4 0/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
@ 2026-10-30 4:59 ` vamshi gajjela
2026-10-30 16:37 ` Abel Vesa
2026-10-30 4:59 ` [PATCH v4 2/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
1 sibling, 1 reply; 5+ messages in thread
From: vamshi gajjela @ 2026-10-30 4:59 UTC (permalink / raw)
To: sboyd, abelvesa; +Cc: abel.vesa, jwylder, linux-kernel, vamshigajjela
From: Vamshi Gajjela <vamshigajjela@google.com>
Rename drivers/spmi/spmi.c to spmi-core.c and build it into the
composite spmi.o object to allow linking multiple files into the
spmi core module.
Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
---
drivers/spmi/Makefile | 1 +
drivers/spmi/{spmi.c => spmi-core.c} | 0
2 files changed, 1 insertion(+)
rename drivers/spmi/{spmi.c => spmi-core.c} (100%)
diff --git a/drivers/spmi/Makefile b/drivers/spmi/Makefile
index 38ac635645ba..190d560f692e 100644
--- a/drivers/spmi/Makefile
+++ b/drivers/spmi/Makefile
@@ -3,6 +3,7 @@
# Makefile for kernel SPMI framework.
#
obj-$(CONFIG_SPMI) += spmi.o spmi-devres.o
+spmi-y := spmi-core.o
obj-$(CONFIG_SPMI_APPLE) += spmi-apple-controller.o
obj-$(CONFIG_SPMI_HISI3670) += hisi-spmi-controller.o
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi-core.c
similarity index 100%
rename from drivers/spmi/spmi.c
rename to drivers/spmi/spmi-core.c
--
2.56.0.317.g454f8302e1-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 2/2] spmi: core: Add generic DebugFS interface for bus inspection
2026-10-30 4:59 [PATCH v4 0/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
2026-10-30 4:59 ` [PATCH v4 1/2] spmi: core: Rename spmi.c to spmi-core.c vamshi gajjela
@ 2026-10-30 4:59 ` vamshi gajjela
2026-10-30 16:45 ` Abel Vesa
1 sibling, 1 reply; 5+ messages in thread
From: vamshi gajjela @ 2026-10-30 4:59 UTC (permalink / raw)
To: sboyd, abelvesa; +Cc: abel.vesa, jwylder, linux-kernel, vamshigajjela
From: Vamshi Gajjela <vamshigajjela@google.com>
Introduce a generic, controller-agnostic DebugFS interface in the SPMI
core under /sys/kernel/debug/spmi/spmi-<nr>/:
- name: Displays the controller parent device name and OF node.
- xfer: Transactional interface supporting register reads, writes,
and directed command opcodes with automatic opcode selection.
Because raw writes and commands to PMICs can damage hardware and bypass
client drivers and their regmap caches, write ('w') and command ('c')
operations are disabled by default behind SPMI_ALLOW_WRITE_DEBUGFS. When
enabled, they restrict access to root (mode 0600) and mark the kernel
tainted with TAINT_USER.
Detailed interface syntax and parameters are documented in
Documentation/ABI/testing/debugfs-spmi.
Co-developed-by: Jim Wylder <jwylder@google.com>
Signed-off-by: Jim Wylder <jwylder@google.com>
Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
---
Documentation/ABI/testing/debugfs-spmi | 68 +++++
MAINTAINERS | 1 +
drivers/spmi/Makefile | 1 +
drivers/spmi/spmi-core.c | 20 +-
drivers/spmi/spmi-debugfs.c | 341 +++++++++++++++++++++++++
drivers/spmi/spmi-internal.h | 28 ++
include/linux/spmi.h | 6 +
7 files changed, 459 insertions(+), 6 deletions(-)
create mode 100644 Documentation/ABI/testing/debugfs-spmi
create mode 100644 drivers/spmi/spmi-debugfs.c
create mode 100644 drivers/spmi/spmi-internal.h
diff --git a/Documentation/ABI/testing/debugfs-spmi b/Documentation/ABI/testing/debugfs-spmi
new file mode 100644
index 000000000000..6a0bff9027a4
--- /dev/null
+++ b/Documentation/ABI/testing/debugfs-spmi
@@ -0,0 +1,68 @@
+What: /sys/kernel/debug/spmi/spmi-<nr>/name
+Date: October 2026
+KernelVersion: 7.4
+Contact: vamshi gajjela <vamshigajjela@google.com>
+Description:
+ Displays the SPMI controller parent device name and
+ associated Device Tree node.
+Users: Debugging, hardware diagnostics
+
+What: /sys/kernel/debug/spmi/spmi-<nr>/xfer
+Date: October 2026
+KernelVersion: 7.4
+Contact: vamshi gajjela <vamshigajjela@google.com>
+Description:
+ Transactional interface for raw SPMI bus operations:
+
+ - Register Read:
+ exec 3<> xfer && echo "r <sid> <addr> [len]" >&3 && cat <&3
+ Reads 1 to 16 bytes starting at <addr> from slave <sid>.
+ The optional [len] parameter defaults to 1 byte.
+ Output is formatted as:
+ 0x<addr>: <byte0> <byte1> ...
+ Each open file descriptor maintains an independent response
+ buffer. Reading from the same open file descriptor consumes
+ the response; subsequent reads return EOF (0 bytes) until a
+ new read command is written.
+
+ - Register Write (requires SPMI_ALLOW_WRITE_DEBUGFS):
+ echo "w <sid> <addr> <val...>" > xfer
+ Writes 1 to 16 bytes starting at <addr> to slave <sid>.
+ Values are separated by spaces (e.g. "w 0x4 0x8 0x12 0x34"
+ or "w 4 8 12 34"). Disabled by default (-EOPNOTSUPP) unless
+ SPMI_ALLOW_WRITE_DEBUGFS is defined at compile time.
+
+ - Command (requires SPMI_ALLOW_WRITE_DEBUGFS):
+ echo "c <sid> <opcode>" > xfer
+ Sends a single SPMI command opcode (e.g. RESET 0x10,
+ SLEEP 0x11, SHUTDOWN 0x12, WAKEUP 0x13) to slave <sid>.
+ Disabled by default (-EOPNOTSUPP) unless
+ SPMI_ALLOW_WRITE_DEBUGFS is defined at compile time.
+
+ Parameter Formatting & Validation:
+ - <sid>: 4-bit Slave Identifier (0x0 to 0xF, supports both
+ decimal "4" and hexadecimal "0x4").
+ - <addr>: 16-bit register address (0x0000 to 0xFFFF) parsed in
+ hexadecimal (supports both "0x12" and "12", as well as
+ "08", "09").
+ - [len]: Number of bytes to read (1 to 16 for 8-bit addresses,
+ up to 8 bytes for 16-bit extended addresses; default 1).
+ - <val...>: 1 to 16 hexadecimal byte values (0x00 to 0xFF,
+ up to 8 bytes for 16-bit extended addresses). Values
+ exceeding 0xFF or payloads exceeding 16 bytes are rejected
+ with -EINVAL.
+ - <opcode>: 1-byte command opcode parsed in hexadecimal
+ (0x00 to 0xFF, e.g. "0x10" or "10").
+ - Trailing unrecognized arguments return -EINVAL.
+
+ The interface automatically selects the optimal SPMI opcode
+ (Register Read/Write, Extended Register Read/Write, Extended
+ Register Read/Write Long, or 7-bit Zero Write at address 0x00)
+ based on the address, payload value, and burst length.
+
+ All write and command operations mark the kernel as tainted
+ with TAINT_USER. On failure, the write system call returns a
+ negative errno (e.g. -EIO on bus NACK/timeout, -EINVAL on
+ syntax/range error, -EOPNOTSUPP if disabled or unsupported by
+ the controller).
+Users: Debugging, hardware bringup, manufacturing test
diff --git a/MAINTAINERS b/MAINTAINERS
index eaeb60c1e1c2..aa9328b4d1c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25848,6 +25848,7 @@ M: Abel Vesa <abelvesa@kernel.org>
L: linux-kernel@vger.kernel.org
S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
+F: Documentation/ABI/testing/debugfs-spmi
F: Documentation/devicetree/bindings/spmi/
F: drivers/spmi/
F: include/dt-bindings/spmi/spmi.h
diff --git a/drivers/spmi/Makefile b/drivers/spmi/Makefile
index 190d560f692e..28737e793a50 100644
--- a/drivers/spmi/Makefile
+++ b/drivers/spmi/Makefile
@@ -4,6 +4,7 @@
#
obj-$(CONFIG_SPMI) += spmi.o spmi-devres.o
spmi-y := spmi-core.o
+spmi-$(CONFIG_DEBUG_FS) += spmi-debugfs.o
obj-$(CONFIG_SPMI_APPLE) += spmi-apple-controller.o
obj-$(CONFIG_SPMI_HISI3670) += hisi-spmi-controller.o
diff --git a/drivers/spmi/spmi-core.c b/drivers/spmi/spmi-core.c
index ec97f12046f5..c498bf84f38e 100644
--- a/drivers/spmi/spmi-core.c
+++ b/drivers/spmi/spmi-core.c
@@ -17,6 +17,8 @@
#define CREATE_TRACE_POINTS
#include <trace/events/spmi.h>
+#include "spmi-internal.h"
+
static bool is_registered;
static DEFINE_IDA(ctrl_ida);
static DEFINE_IDA(spmi_subdevice_ida);
@@ -114,8 +116,7 @@ void spmi_subdevice_remove(struct spmi_subdevice *sub_sdev)
}
EXPORT_SYMBOL_NS_GPL(spmi_subdevice_remove, "SPMI");
-static inline int
-spmi_cmd(struct spmi_controller *ctrl, u8 opcode, u8 sid)
+int spmi_cmd(struct spmi_controller *ctrl, u8 opcode, u8 sid)
{
int ret;
@@ -127,8 +128,8 @@ spmi_cmd(struct spmi_controller *ctrl, u8 opcode, u8 sid)
return ret;
}
-static inline int spmi_read_cmd(struct spmi_controller *ctrl, u8 opcode,
- u8 sid, u16 addr, u8 *buf, size_t len)
+int spmi_read_cmd(struct spmi_controller *ctrl, u8 opcode,
+ u8 sid, u16 addr, u8 *buf, size_t len)
{
int ret;
@@ -141,8 +142,8 @@ static inline int spmi_read_cmd(struct spmi_controller *ctrl, u8 opcode,
return ret;
}
-static inline int spmi_write_cmd(struct spmi_controller *ctrl, u8 opcode,
- u8 sid, u16 addr, const u8 *buf, size_t len)
+int spmi_write_cmd(struct spmi_controller *ctrl, u8 opcode,
+ u8 sid, u16 addr, const u8 *buf, size_t len)
{
int ret;
@@ -653,6 +654,8 @@ int spmi_controller_add(struct spmi_controller *ctrl)
dev_dbg(&ctrl->dev, "spmi-%d registered: dev:%p\n",
ctrl->nr, &ctrl->dev);
+ spmi_controller_debugfs_init(ctrl);
+
return 0;
};
EXPORT_SYMBOL_GPL(spmi_controller_add);
@@ -679,6 +682,8 @@ void spmi_controller_remove(struct spmi_controller *ctrl)
if (!ctrl)
return;
+ spmi_controller_debugfs_remove(ctrl);
+
device_for_each_child(&ctrl->dev, NULL, spmi_ctrl_remove_device);
device_del(&ctrl->dev);
}
@@ -702,6 +707,7 @@ EXPORT_SYMBOL_GPL(__spmi_driver_register);
static void __exit spmi_exit(void)
{
+ spmi_debugfs_exit();
bus_unregister(&spmi_bus_type);
}
module_exit(spmi_exit);
@@ -714,6 +720,8 @@ static int __init spmi_init(void)
if (ret)
return ret;
+ spmi_debugfs_init();
+
is_registered = true;
return 0;
}
diff --git a/drivers/spmi/spmi-debugfs.c b/drivers/spmi/spmi-debugfs.c
new file mode 100644
index 000000000000..9826b5a8137c
--- /dev/null
+++ b/drivers/spmi/spmi-debugfs.c
@@ -0,0 +1,341 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * SPMI core DebugFS interface
+ *
+ * Copyright (C) 2026 Google LLC
+ */
+
+#include <linux/ctype.h>
+#include <linux/debugfs.h>
+#include <linux/mutex.h>
+#include <linux/of.h>
+#include <linux/panic.h>
+#include <linux/seq_file.h>
+#include <linux/slab.h>
+#include <linux/spmi.h>
+#include <linux/string.h>
+#include <linux/uaccess.h>
+
+#include "spmi-internal.h"
+
+/*
+ * Raw writes and commands to PMICs can damage hardware and bypass
+ * client drivers. Keep them disabled by default.
+ */
+#undef SPMI_ALLOW_WRITE_DEBUGFS
+
+struct spmi_xfer_ctx {
+ struct spmi_controller *ctrl;
+ struct mutex lock; /* protects xfer_buf and xfer_len */
+ char xfer_buf[64];
+ size_t xfer_len;
+};
+
+/* Top-level SPMI debugfs directory (/sys/kernel/debug/spmi) */
+static struct dentry *spmi_debugfs_root;
+
+static int spmi_calc_read_opcode(u16 addr, size_t len, u8 *opc)
+{
+ if (len == 0)
+ return -EINVAL;
+
+ if (addr <= 0x1f && len == 1)
+ *opc = SPMI_CMD_READ;
+ else if (addr <= 0xff && len <= 16)
+ *opc = SPMI_CMD_EXT_READ;
+ else if (len <= 8)
+ *opc = SPMI_CMD_EXT_READL;
+ else
+ return -EINVAL;
+
+ return 0;
+}
+
+#ifdef SPMI_ALLOW_WRITE_DEBUGFS
+static int spmi_calc_write_opcode(u16 addr, const u8 *data, size_t len, u8 *opc)
+{
+ if (len == 0)
+ return -EINVAL;
+
+ if (addr == 0 && len == 1 && data[0] <= 0x7f)
+ *opc = SPMI_CMD_ZERO_WRITE;
+ else if (addr <= 0x1f && len == 1)
+ *opc = SPMI_CMD_WRITE;
+ else if (addr <= 0xff && len <= 16)
+ *opc = SPMI_CMD_EXT_WRITE;
+ else if (len <= 8)
+ *opc = SPMI_CMD_EXT_WRITEL;
+ else
+ return -EINVAL;
+
+ return 0;
+}
+#endif
+
+static int spmi_debugfs_name_show(struct seq_file *s, void *data)
+{
+ struct spmi_controller *ctrl = s->private;
+ struct device *parent = ctrl->dev.parent;
+
+ if (!parent)
+ return -ENODEV;
+
+ if (dev_of_node(parent))
+ seq_printf(s, "%s (%pOF)\n", dev_name(parent), dev_of_node(parent));
+ else
+ seq_printf(s, "%s\n", dev_name(parent));
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(spmi_debugfs_name);
+
+static int spmi_debugfs_xfer_open(struct inode *inode, struct file *file)
+{
+ struct spmi_xfer_ctx *ctx;
+
+ ctx = kzalloc_obj(*ctx);
+ if (!ctx)
+ return -ENOMEM;
+
+ ctx->ctrl = inode->i_private;
+ mutex_init(&ctx->lock);
+ file->private_data = ctx;
+
+ return 0;
+}
+
+static int spmi_debugfs_xfer_release(struct inode *inode, struct file *file)
+{
+ struct spmi_xfer_ctx *ctx = file->private_data;
+
+ mutex_destroy(&ctx->lock);
+ kfree(ctx);
+
+ return 0;
+}
+
+static ssize_t spmi_debugfs_xfer_read(struct file *file, char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ struct spmi_xfer_ctx *ctx = file->private_data;
+ ssize_t ret;
+
+ mutex_lock(&ctx->lock);
+ ret = simple_read_from_buffer(user_buf, count, ppos, ctx->xfer_buf, ctx->xfer_len);
+ if (ret > 0 && *ppos >= ctx->xfer_len)
+ ctx->xfer_len = 0;
+ mutex_unlock(&ctx->lock);
+
+ return ret;
+}
+
+static char *spmi_debugfs_next_tok(char **str)
+{
+ char *tok;
+
+ *str = skip_spaces(*str);
+ if (!**str)
+ return NULL;
+
+ tok = *str;
+ while (**str && !isspace(**str))
+ (*str)++;
+
+ if (**str) {
+ **str = '\0';
+ (*str)++;
+ }
+
+ return tok;
+}
+
+static ssize_t spmi_debugfs_xfer_write(struct file *file, const char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ struct spmi_xfer_ctx *ctx = file->private_data;
+ struct spmi_controller *ctrl = ctx->ctrl;
+ unsigned int sid, len;
+ char *str, *tok;
+ char kbuf[256];
+ int ret = 0, i;
+ u8 data[16];
+ size_t off;
+ u8 opcode;
+ u16 addr;
+ char type;
+
+ if (count == 0 || count >= sizeof(kbuf))
+ return -EINVAL;
+
+ if (copy_from_user(kbuf, user_buf, count))
+ return -EFAULT;
+ kbuf[count] = '\0';
+
+ str = strim(kbuf);
+ type = tolower(*str);
+ if (type != 'r' && type != 'w' && type != 'c')
+ return -EINVAL;
+ str = skip_spaces(str + 1);
+
+ tok = spmi_debugfs_next_tok(&str);
+ if (!tok || kstrtouint(tok, 0, &sid) || sid >= SPMI_MAX_SLAVE_ID)
+ return -EINVAL;
+
+ mutex_lock(&ctx->lock);
+ ctx->xfer_len = 0;
+
+ if (type == 'r') {
+ tok = spmi_debugfs_next_tok(&str);
+ if (!tok || kstrtou16(tok, 16, &addr)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ len = 1;
+ tok = spmi_debugfs_next_tok(&str);
+ if (tok) {
+ if (kstrtouint(tok, 0, &len) || len == 0 || len > sizeof(data)) {
+ ret = -EINVAL;
+ goto out;
+ }
+ if (spmi_debugfs_next_tok(&str)) {
+ ret = -EINVAL;
+ goto out;
+ }
+ }
+
+ if (!ctrl->read_cmd) {
+ ret = -EOPNOTSUPP;
+ goto out;
+ }
+
+ ret = spmi_calc_read_opcode(addr, len, &opcode);
+ if (ret)
+ goto out;
+
+ ret = spmi_read_cmd(ctrl, opcode, sid, addr, data, len);
+ if (!ret) {
+ off = scnprintf(ctx->xfer_buf, sizeof(ctx->xfer_buf),
+ "0x%04x:", addr);
+
+ for (i = 0; i < len; i++)
+ off += scnprintf(ctx->xfer_buf + off, sizeof(ctx->xfer_buf) - off,
+ " %02x", data[i]);
+ off += scnprintf(ctx->xfer_buf + off, sizeof(ctx->xfer_buf) - off, "\n");
+ ctx->xfer_len = off;
+ *ppos = 0;
+ }
+#ifdef SPMI_ALLOW_WRITE_DEBUGFS
+ } else if (type == 'w') {
+ unsigned int val;
+
+ tok = spmi_debugfs_next_tok(&str);
+ if (!tok || kstrtou16(tok, 16, &addr)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ len = 0;
+ while ((tok = spmi_debugfs_next_tok(&str)) != NULL) {
+ if (len >= sizeof(data) || kstrtouint(tok, 16, &val) || val > 0xff) {
+ ret = -EINVAL;
+ goto out;
+ }
+ data[len++] = val;
+ }
+
+ if (len == 0) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ if (!ctrl->write_cmd) {
+ ret = -EOPNOTSUPP;
+ goto out;
+ }
+
+ ret = spmi_calc_write_opcode(addr, data, len, &opcode);
+ if (ret)
+ goto out;
+
+ add_taint(TAINT_USER, LOCKDEP_STILL_OK);
+
+ ret = spmi_write_cmd(ctrl, opcode, sid, addr, data, len);
+ } else if (type == 'c') {
+ unsigned int cmd_opc;
+
+ tok = spmi_debugfs_next_tok(&str);
+ if (!tok || kstrtouint(tok, 16, &cmd_opc) || cmd_opc > 0xff) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ if (spmi_debugfs_next_tok(&str)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ if (!ctrl->cmd) {
+ ret = -EOPNOTSUPP;
+ goto out;
+ }
+
+ add_taint(TAINT_USER, LOCKDEP_STILL_OK);
+
+ ret = spmi_cmd(ctrl, cmd_opc, sid);
+#else
+ } else {
+ ret = -EOPNOTSUPP;
+#endif
+ }
+
+out:
+ mutex_unlock(&ctx->lock);
+
+ return ret ? ret : count;
+}
+
+static const struct file_operations spmi_debugfs_xfer_fops = {
+ .open = spmi_debugfs_xfer_open,
+ .release = spmi_debugfs_xfer_release,
+ .read = spmi_debugfs_xfer_read,
+ .write = spmi_debugfs_xfer_write,
+ .llseek = default_llseek,
+};
+
+void spmi_controller_debugfs_init(struct spmi_controller *ctrl)
+{
+ struct dentry *dentry;
+ char name[32];
+
+ if (IS_ERR_OR_NULL(spmi_debugfs_root))
+ return;
+
+ snprintf(name, sizeof(name), "spmi-%u", ctrl->nr);
+ dentry = debugfs_create_dir(name, spmi_debugfs_root);
+ if (IS_ERR_OR_NULL(dentry))
+ return;
+
+ debugfs_create_file("name", 0444, dentry, ctrl, &spmi_debugfs_name_fops);
+ debugfs_create_file("xfer", 0600, dentry, ctrl, &spmi_debugfs_xfer_fops);
+
+ ctrl->debugfs = dentry;
+}
+
+void spmi_controller_debugfs_remove(struct spmi_controller *ctrl)
+{
+ debugfs_remove(ctrl->debugfs);
+ ctrl->debugfs = NULL;
+}
+
+void spmi_debugfs_init(void)
+{
+ if (!spmi_debugfs_root)
+ spmi_debugfs_root = debugfs_create_dir("spmi", NULL);
+}
+
+void spmi_debugfs_exit(void)
+{
+ debugfs_remove(spmi_debugfs_root);
+ spmi_debugfs_root = NULL;
+}
diff --git a/drivers/spmi/spmi-internal.h b/drivers/spmi/spmi-internal.h
new file mode 100644
index 000000000000..6c2ae35200a8
--- /dev/null
+++ b/drivers/spmi/spmi-internal.h
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (C) 2026 Google LLC
+ */
+#ifndef _SPMI_INTERNAL_H
+#define _SPMI_INTERNAL_H
+
+#include <linux/spmi.h>
+
+int spmi_cmd(struct spmi_controller *ctrl, u8 opcode, u8 sid);
+int spmi_read_cmd(struct spmi_controller *ctrl, u8 opcode,
+ u8 sid, u16 addr, u8 *buf, size_t len);
+int spmi_write_cmd(struct spmi_controller *ctrl, u8 opcode,
+ u8 sid, u16 addr, const u8 *buf, size_t len);
+
+#if IS_ENABLED(CONFIG_DEBUG_FS)
+void spmi_debugfs_init(void);
+void spmi_debugfs_exit(void);
+void spmi_controller_debugfs_init(struct spmi_controller *ctrl);
+void spmi_controller_debugfs_remove(struct spmi_controller *ctrl);
+#else
+static inline void spmi_debugfs_init(void) {}
+static inline void spmi_debugfs_exit(void) {}
+static inline void spmi_controller_debugfs_init(struct spmi_controller *ctrl) {}
+static inline void spmi_controller_debugfs_remove(struct spmi_controller *ctrl) {}
+#endif
+
+#endif /* _SPMI_INTERNAL_H */
diff --git a/include/linux/spmi.h b/include/linux/spmi.h
index 4daebc980501..7dd62db255a4 100644
--- a/include/linux/spmi.h
+++ b/include/linux/spmi.h
@@ -85,6 +85,8 @@ void spmi_subdevice_remove(struct spmi_subdevice *sdev);
struct spmi_subdevice *devm_spmi_subdevice_alloc_and_add(struct device *dev,
struct spmi_device *sparent);
+struct dentry;
+
/**
* struct spmi_controller - interface to the SPMI master controller
* @dev: Driver model representation of the device.
@@ -92,6 +94,7 @@ struct spmi_subdevice *devm_spmi_subdevice_alloc_and_add(struct device *dev,
* @cmd: sends a non-data command sequence on the SPMI bus.
* @read_cmd: sends a register read command sequence on the SPMI bus.
* @write_cmd: sends a register write command sequence on the SPMI bus.
+ * @debugfs: debugfs dentry for this controller.
* @priv: array of private data.
*/
struct spmi_controller {
@@ -102,6 +105,9 @@ struct spmi_controller {
u8 sid, u16 addr, u8 *buf, size_t len);
int (*write_cmd)(struct spmi_controller *ctrl, u8 opcode,
u8 sid, u16 addr, const u8 *buf, size_t len);
+#if IS_ENABLED(CONFIG_DEBUG_FS)
+ struct dentry *debugfs;
+#endif
u8 priv[];
};
--
2.56.0.317.g454f8302e1-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/2] spmi: core: Rename spmi.c to spmi-core.c
2026-10-30 4:59 ` [PATCH v4 1/2] spmi: core: Rename spmi.c to spmi-core.c vamshi gajjela
@ 2026-10-30 16:37 ` Abel Vesa
0 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-10-30 16:37 UTC (permalink / raw)
To: vamshi gajjela; +Cc: sboyd, abelvesa, jwylder, linux-kernel
On 26-10-30 10:29:46, vamshi gajjela wrote:
> From: Vamshi Gajjela <vamshigajjela@google.com>
>
> Rename drivers/spmi/spmi.c to spmi-core.c and build it into the
> composite spmi.o object to allow linking multiple files into the
> spmi core module.
>
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
Subject prefix for SPMI core is just "spmi:", please drop the "core:".
I should've spotted that earlier. Sorry.
With that fixed:
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 2/2] spmi: core: Add generic DebugFS interface for bus inspection
2026-10-30 4:59 ` [PATCH v4 2/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
@ 2026-10-30 16:45 ` Abel Vesa
0 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-10-30 16:45 UTC (permalink / raw)
To: vamshi gajjela; +Cc: sboyd, abelvesa, jwylder, linux-kernel
On 26-10-30 10:29:47, vamshi gajjela wrote:
> From: Vamshi Gajjela <vamshigajjela@google.com>
>
> Introduce a generic, controller-agnostic DebugFS interface in the SPMI
> core under /sys/kernel/debug/spmi/spmi-<nr>/:
> - name: Displays the controller parent device name and OF node.
> - xfer: Transactional interface supporting register reads, writes,
> and directed command opcodes with automatic opcode selection.
>
> Because raw writes and commands to PMICs can damage hardware and bypass
> client drivers and their regmap caches, write ('w') and command ('c')
> operations are disabled by default behind SPMI_ALLOW_WRITE_DEBUGFS. When
> enabled, they restrict access to root (mode 0600) and mark the kernel
> tainted with TAINT_USER.
>
> Detailed interface syntax and parameters are documented in
> Documentation/ABI/testing/debugfs-spmi.
>
> Co-developed-by: Jim Wylder <jwylder@google.com>
> Signed-off-by: Jim Wylder <jwylder@google.com>
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> ---
> Documentation/ABI/testing/debugfs-spmi | 68 +++++
> MAINTAINERS | 1 +
> drivers/spmi/Makefile | 1 +
> drivers/spmi/spmi-core.c | 20 +-
> drivers/spmi/spmi-debugfs.c | 341 +++++++++++++++++++++++++
> drivers/spmi/spmi-internal.h | 28 ++
> include/linux/spmi.h | 6 +
> 7 files changed, 459 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/ABI/testing/debugfs-spmi
> create mode 100644 drivers/spmi/spmi-debugfs.c
> create mode 100644 drivers/spmi/spmi-internal.h
>
> diff --git a/Documentation/ABI/testing/debugfs-spmi b/Documentation/ABI/testing/debugfs-spmi
> new file mode 100644
> index 000000000000..6a0bff9027a4
> --- /dev/null
> +++ b/Documentation/ABI/testing/debugfs-spmi
> @@ -0,0 +1,68 @@
> +What: /sys/kernel/debug/spmi/spmi-<nr>/name
> +Date: October 2026
> +KernelVersion: 7.4
> +Contact: vamshi gajjela <vamshigajjela@google.com>
> +Description:
> + Displays the SPMI controller parent device name and
> + associated Device Tree node.
> +Users: Debugging, hardware diagnostics
> +
> +What: /sys/kernel/debug/spmi/spmi-<nr>/xfer
> +Date: October 2026
> +KernelVersion: 7.4
This patch won't make it into 7.4, so you can say 7.5 here.
> +Contact: vamshi gajjela <vamshigajjela@google.com>
> +Description:
> + Transactional interface for raw SPMI bus operations:
> +
> + - Register Read:
> + exec 3<> xfer && echo "r <sid> <addr> [len]" >&3 && cat <&3
> + Reads 1 to 16 bytes starting at <addr> from slave <sid>.
> + The optional [len] parameter defaults to 1 byte.
> + Output is formatted as:
> + 0x<addr>: <byte0> <byte1> ...
> + Each open file descriptor maintains an independent response
> + buffer. Reading from the same open file descriptor consumes
> + the response; subsequent reads return EOF (0 bytes) until a
> + new read command is written.
> +
[...]
> +
> +void spmi_controller_debugfs_init(struct spmi_controller *ctrl)
> +{
> + struct dentry *dentry;
> + char name[32];
> +
> + if (IS_ERR_OR_NULL(spmi_debugfs_root))
> + return;
> +
> + snprintf(name, sizeof(name), "spmi-%u", ctrl->nr);
> + dentry = debugfs_create_dir(name, spmi_debugfs_root);
> + if (IS_ERR_OR_NULL(dentry))
> + return;
No need to check debugfs return values, please drop these.
Also, the dir name is the same as dev_name(&ctrl->dev), so please use that.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-10-30 16:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-30 4:59 [PATCH v4 0/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
2026-10-30 4:59 ` [PATCH v4 1/2] spmi: core: Rename spmi.c to spmi-core.c vamshi gajjela
2026-10-30 16:37 ` Abel Vesa
2026-10-30 4:59 ` [PATCH v4 2/2] spmi: core: Add generic DebugFS interface for bus inspection vamshi gajjela
2026-10-30 16:45 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®