From: Mina Almasry <almasrymina@google.com>
To: "Hangbin Liu" <hangbin.liu@linux.dev>,
"Ömer Mete Kaya" <omermetekaya0@gmail.com>
Cc: Mina Almasry <almasrymina@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Joas Antonio dos Santos <joasantonio108@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
syzbot+88435e204734072bf39a@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] netdevsim: reject port addition and clean up ports after a failed reload
Date: Fri, 30 Oct 2026 06:42:45 +0000 [thread overview]
Message-ID: <20261030064245.4118081-1-almasrymina@google.com> (raw)
In-Reply-To: <auP7VyY3MGqOphL-@bogon>
On Fri, Oct 30, 2026 at 2:05 AM Hangbin Liu <hangbin.liu@linux.dev> wrote:
>
> Looks Joas has a same issue fix with yours a few hour earlier.
>
> https://lore.kernel.org/netdev/179324296598.34505.11070163314749859668@gmail.com/
>
> > ---
> > Tested with syzbot C reproducer.
> > v2: drop Cc:stable and target net-next.
...
> But yours have an extra guard in nsim_drv_port_add...
>
> Leave this to Jakub decide...
I prefer Ömer's version. Once reload_down has torn down the device and
reload_up has failed, the device is in an uninitialized state, so
rejecting new_port in nsim_drv_port_add() makes more sense than
allowing ports/netdevs to be registered on a half-torn-down nsim_dev
and only cleaning them up later.
--
Thanks,
Mina
next prev parent reply other threads:[~2026-10-30 6:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 0:13 Ömer Mete Kaya
2026-10-30 0:18 ` Mina Almasry
2026-10-30 0:28 ` Ömer Mete Kaya
2026-10-30 2:05 ` Hangbin Liu
2026-10-30 6:42 ` Mina Almasry [this message]
2026-10-30 7:26 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030064245.4118081-1-almasrymina@google.com \
--to=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hangbin.liu@linux.dev \
--cc=jiri@resnulli.us \
--cc=joasantonio108@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omermetekaya0@gmail.com \
--cc=pabeni@redhat.com \
--cc=syzbot+88435e204734072bf39a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®