From: Avi Weiss <thnkslprpt@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org, Avi Weiss <thnkslprpt@gmail.com>
Subject: [PATCH] gnss: sirf: keep wakeup IRQ enabled on failed suspend
Date: Fri, 30 Oct 2026 14:02:42 +0200 [thread overview]
Message-ID: <20261030120241.2313517-2-thnkslprpt@gmail.com> (raw)
sirf_suspend() disables the wakeup IRQ even if
sirf_runtime_suspend() fails. The PM core does not call
sirf_resume() when this device's suspend callback fails,
leaving the IRQ disabled.
Only disable the wakeup IRQ after a successful runtime suspend.
Fixes: d2efbbd18b1e2 ("gnss: add driver for sirfstar-based receivers")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
drivers/gnss/sirf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
index 79375d14bbb67..2ce96598bd4fe 100644
--- a/drivers/gnss/sirf.c
+++ b/drivers/gnss/sirf.c
@@ -354,7 +354,7 @@ static int __maybe_unused sirf_suspend(struct device *dev)
if (!pm_runtime_suspended(dev))
ret = sirf_runtime_suspend(dev);
- if (data->wakeup)
+ if (!ret && data->wakeup)
disable_irq(data->irq);
return ret;
base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
--
2.43.0
reply other threads:[~2026-10-30 12:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030120241.2313517-2-thnkslprpt@gmail.com \
--to=thnkslprpt@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®