* [PATCH] gnss: sirf: keep wakeup IRQ enabled on failed suspend
@ 2026-10-30 12:02 Avi Weiss
0 siblings, 0 replies; only message in thread
From: Avi Weiss @ 2026-10-30 12:02 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-kernel, Avi Weiss
sirf_suspend() disables the wakeup IRQ even if
sirf_runtime_suspend() fails. The PM core does not call
sirf_resume() when this device's suspend callback fails,
leaving the IRQ disabled.
Only disable the wakeup IRQ after a successful runtime suspend.
Fixes: d2efbbd18b1e2 ("gnss: add driver for sirfstar-based receivers")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
drivers/gnss/sirf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c
index 79375d14bbb67..2ce96598bd4fe 100644
--- a/drivers/gnss/sirf.c
+++ b/drivers/gnss/sirf.c
@@ -354,7 +354,7 @@ static int __maybe_unused sirf_suspend(struct device *dev)
if (!pm_runtime_suspended(dev))
ret = sirf_runtime_suspend(dev);
- if (data->wakeup)
+ if (!ret && data->wakeup)
disable_irq(data->irq);
return ret;
base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-30 12:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-30 12:02 [PATCH] gnss: sirf: keep wakeup IRQ enabled on failed suspend Avi Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®