[PATCH] gnss: serial: power down active receiver on deregistration

[PATCH] gnss: serial: power down active receiver on deregistration

[Avi Weiss]

When a GNSS device is removed with an open descriptor,
gnss_deregister_device() calls gnss_serial_close(), which releases its
runtime-PM reference asynchronously. gnss_serial_deregister() then
disables runtime PM and can cancel the pending suspend, leaving the
receiver supply enabled when the regulator handle is released.

Power off the receiver after disabling runtime PM if it is still active.
Leave an already-suspended receiver alone to avoid disabling its supply
twice.

Fixes: 37768b054f20 ("gnss: add generic serial driver")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
 drivers/gnss/serial.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gnss/serial.c b/drivers/gnss/serial.c
index 0e43bf6294f87..e1fb3dcc5f391 100644
--- a/drivers/gnss/serial.c
+++ b/drivers/gnss/serial.c
@@ -203,10 +203,12 @@ void gnss_serial_deregister(struct gnss_serial *gserial)
 
 	gnss_deregister_device(gserial->gdev);
 
-	if (IS_ENABLED(CONFIG_PM))
+	if (IS_ENABLED(CONFIG_PM)) {
 		pm_runtime_disable(&serdev->dev);
-	else
-		gnss_serial_set_power(gserial, GNSS_SERIAL_OFF);
+		if (pm_runtime_status_suspended(&serdev->dev))
+			return;
+	}
+	gnss_serial_set_power(gserial, GNSS_SERIAL_OFF);
 }
 EXPORT_SYMBOL_GPL(gnss_serial_deregister);
 

base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
-- 
2.43.0