From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>
Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] iommu/qcom: Use identity default domains for the MSM GPU and display
Date: Sat, 31 Oct 2026 00:04:58 +0200 [thread overview]
Message-ID: <20261031-msm-smmu-identity-v1-2-a2a70580eebd@oss.qualcomm.com> (raw)
In-Reply-To: <20261031-msm-smmu-identity-v1-0-a2a70580eebd@oss.qualcomm.com>
drm/msm writes the addresses dma_map_sgtable() returns for the DRM
device into its own page tables, so they have to be physical addresses,
i.e. the device must not use iommu-dma. qcom_iommu has no
def_domain_type, so the MDP5 and Adreno devices do get iommu-dma, the
buffers end up mapped at IOVAs of the unused default domain and the
db410c GPU fails to start.
Use identity default domains for these devices, as arm-smmu-qcom does.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/iommu/arm/arm-smmu/qcom_iommu.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index 54130c32056a..4a9c4cf63724 100644
--- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@ -22,6 +22,7 @@
#include <linux/init.h>
#include <linux/mutex.h>
#include <linux/of.h>
+#include <linux/of_device.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm.h>
@@ -531,6 +532,18 @@ static bool qcom_iommu_capable(struct device *dev, enum iommu_cap cap)
}
}
+static const struct of_device_id qcom_iommu_client_of_match[] = {
+ { .compatible = "qcom,adreno" },
+ { .compatible = "qcom,mdp5" },
+ { }
+};
+
+static int qcom_iommu_def_domain_type(struct device *dev)
+{
+ return of_match_device(qcom_iommu_client_of_match, dev) ?
+ IOMMU_DOMAIN_IDENTITY : 0;
+}
+
static struct iommu_device *qcom_iommu_probe_device(struct device *dev)
{
struct qcom_iommu_dev *qcom_iommu = dev_iommu_priv_get(dev);
@@ -602,6 +615,7 @@ static const struct iommu_ops qcom_iommu_ops = {
.capable = qcom_iommu_capable,
.domain_alloc_paging = qcom_iommu_domain_alloc_paging,
.probe_device = qcom_iommu_probe_device,
+ .def_domain_type = qcom_iommu_def_domain_type,
.device_group = generic_device_group,
.of_xlate = qcom_iommu_of_xlate,
.default_domain_ops = &(const struct iommu_domain_ops) {
--
2.47.3
next prev parent reply other threads:[~2026-10-30 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 22:04 [PATCH 0/3] iommu: qcom: Fix the MSM GPU and display with DMA-address based mappings Dmitry Baryshkov
2026-10-30 22:04 ` [PATCH 1/3] iommu/qcom: Invalidate the TLB in flush_iotlb_all Dmitry Baryshkov
2026-10-31 15:27 ` Rob Clark
2026-11-02 9:52 ` Konrad Dybcio
2026-11-10 7:13 ` Yijie Yang
2026-10-30 22:04 ` Dmitry Baryshkov [this message]
2026-10-31 15:28 ` [PATCH 2/3] iommu/qcom: Use identity default domains for the MSM GPU and display Rob Clark
2026-11-02 9:46 ` Konrad Dybcio
2026-10-30 22:04 ` [PATCH 3/3] iommu/arm-smmu-qcom: Use identity default domains for MDP5 Dmitry Baryshkov
2026-10-31 15:28 ` Rob Clark
2026-11-02 9:47 ` Konrad Dybcio
2026-10-31 15:33 ` [PATCH 0/3] iommu: qcom: Fix the MSM GPU and display with DMA-address based mappings Rob Clark
2026-11-02 9:58 ` Dmitry Baryshkov
2026-11-02 21:55 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261031-msm-smmu-identity-v1-2-a2a70580eebd@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®