From: William Breathitt Gray <wbg@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>, Michael Buesch <m@bues.ch>,
Andy Shevchenko <andy@kernel.org>,
Robert Richter <rric@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v4 22/23] gpio: Unify style of pci_device_id arrays
Date: Sat, 31 Oct 2026 14:12:44 -0400 [thread overview]
Message-ID: <20261031181250.3646047-1-wbg@kernel.org> (raw)
In-Reply-To: <4cfcd6189bf6f281487a2eeed4fa1b1fe5521550.1793097104.git.u.kleine-koenig@baylibre.com>
On Tue, Oct 27, 2026 at 11:48:59AM +0100, Uwe Kleine-König wrote:
> Update the various of_device_id arrays to conform to the most used and
> generally recommended coding style. That is:
>
> - no comma after the list terminator;
> - a comma after an initializer if (and only if) the closing } is not
> directly following;
> - no explicit zeros in the list terminator;
> - a space after an opening { and before a closing }, a single space in
> the list terminator;
> - at most one entry per line;
>
> Adapt the few offenders accordingly.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
For gpio-pci-idio-16 and gpio-pcie-idio-24,
Acked-by: William Breathitt Gray <wbg@kernel.org>
next prev parent reply other threads:[~2026-10-31 18:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 01/23] gpio: Remove __maybe_unused annotations from acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 02/23] gpio: fxl6408: Remove __maybe_unused annotations from of_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 03/23] gpio: Drop unused assignment of acpi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 04/23] gpio: max7301: Drop unused assignment of spi_device_id " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 05/23] gpio: mmio: Drop unused assignment of platform_device_id " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 06/23] gpio: ljca: Drop unused assignment of auxiliary_device_id " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 07/23] gpio: xgene: Add missing ACPI module annotation Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 08/23] gpio: sodaville: Add missing PCI module annotations Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 09/23] gpio: Add missing OF " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 10/23] gpio: pxa: Add missing platform " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 11/23] gpio: pl061: Use empty initializer for amba_id terminator Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 12/23] gpio: Use named initializers for acpi_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 11:01 ` Sakari Ailus
2026-10-27 10:48 ` [PATCH v4 14/23] gpio: pcf857x: Use named initializers for of_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 15/23] gpio: bd73800: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 16/23] gpio: Use named initializers for spi_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 17/23] gpio: virtio: Use a named initializer for virtio_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 18/23] gpio: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 19/23] gpio: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 20/23] gpio: max77620: Unify style of platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 21/23] gpio: Unify style of spi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 22/23] gpio: Unify style of pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-31 18:12 ` William Breathitt Gray [this message]
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261031181250.3646047-1-wbg@kernel.org \
--to=wbg@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=rric@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®