* [PATCH] drm/xe/xe_ras: Use xe_log_info to avoid passing zero as error code
@ 2026-11-01 22:52 Ethan Tidmore
0 siblings, 0 replies; only message in thread
From: Ethan Tidmore @ 2026-11-01 22:52 UTC (permalink / raw)
To: Riana Tauro, intel-xe
Cc: Tejas Upadhyay, Matthew Brost, Thomas Hellström,
Rodrigo Vivi, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Ethan Tidmore
xe_log_err() expects an error code, but in the case 0 branch of
handle_page_offline(), 'ret' is zero. Passing zero to a function
expecting an error code is incorrect.
Switch to xe_log_info() instead so that an error code is not
expected and zero is not passed.
Fixes: 12b427cf8bb0 ("drm/xe/xe_ras: Handle page offline requests for device memory ecc errors")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/gpu/drm/xe/xe_ras.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
index db3cbc186a51..7942a2a48887 100644
--- a/drivers/gpu/drm/xe/xe_ras.c
+++ b/drivers/gpu/drm/xe/xe_ras.c
@@ -304,9 +304,9 @@ static int handle_page_offline(struct xe_device *xe, u64 page_address, bool noti
switch (ret) {
case 0:
action = XE_RAS_PAGE_ACTION_REMOVE;
- xe_log_err(xe, DEVICE_MEMORY, ret,
- "Poison detected at physical address 0x%llx, page soft-offlined\n",
- page_address);
+ xe_log_info(xe, DEVICE_MEMORY,
+ "Poison detected at physical address 0x%llx, page soft-offlined\n",
+ page_address);
break;
case -EIO:
xe_log_err(xe, DEVICE_MEMORY, ret,
--
Thanks,
ET
https://github.com/sponsors/ethantidmore
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-01 22:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-01 22:52 [PATCH] drm/xe/xe_ras: Use xe_log_info to avoid passing zero as error code Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®