Re: [PATCH 0/3] lib: Add software mul/div helpers and use them from nios2

[Simon Schuster <schuster.simon@siemens-energy.com>]

Hello Arnd,

thank you for your comments!

On Fri, Oct 30, 2026 at 05:50:58PM +0100, Arnd Bergmann wrote:
> Just a few minor things that stood out:
> 
> - I don't see a need to add the files under arch/ first and then
>   move them to lib/, just start with the added files there

This is an artifact of (1) not wanting to touch or drop Dinh's patch
after picking it up and (2) being quite contend with someone with a
current Altera affiliation doing the initial Sign-off on that check in,
(even though this is, of course, not strictly required by license); if
you don't mind to much, I'd prefer to leave it that way?

> - I did not expect gccbcmp.c to be needed at all, the kernel
>   should handle the string functions internally. If you do need it,
>   there is of course no harm adding it, but probably need to
>   build with -ffreestanding to prevent it from recursively
>   ending up in bcmp()

Good point, as far as I can tell it was not part of my "quick & dirty"
testbuild against upstream libgcc, either. As that had passed
allyesconfig as well, I guess it is indeed unnecessary; I'll retest and
potentially re-roll into a v2.

Best regards
Simon